blacklist: Fix use of uninitialized variable
AbandonedPublic
Actions

Authored by jlduran on Mar 25 2025, 10:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 12, 10:53 PM

	Unknown Object (File)
	Tue, May 12, 8:12 PM

	Unknown Object (File)
	Thu, May 7, 1:51 AM

	Unknown Object (File)
	Wed, Apr 29, 5:39 AM

	Unknown Object (File)
	Wed, Apr 29, 5:39 AM

	Unknown Object (File)
	Mon, Apr 27, 8:15 PM

	Unknown Object (File)
	Apr 11 2026, 7:51 PM

	Unknown Object (File)
	Apr 11 2026, 2:59 PM

View All 55 Files

Subscribers

imp

Details

Reviewers

emaste
dch

Summary

The variables c.c_nfail and dbi.last can be used uninitialized when
getremoteaddress() fails while debugging.

This issue has been reported upstream, however this fix was not
proposed, because there are other ways to fix it. Once upstream
implements a fix, it can be safely reverted, if needed.

Coverity ID: 1473591
Coverity ID: 1473593

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63124
Build 60008: arc lint + arc unit

Event Timeline

jlduran created this revision.Mar 25 2025, 10:08 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2025, 10:08 PM

jlduran requested review of this revision.Mar 25 2025, 10:08 PM

Harbormaster completed remote builds in B63124: Diff 152676.Mar 25 2025, 10:08 PM

jlduran added a parent revision: D49507: blacklist: ftdp: Add a permission denied probe.Mar 25 2025, 10:08 PM

jlduran added a child revision: D49509: ftpd: Add an extra blacklist probe.

A fix has already been committed upstream.

Revision Contents
Changeset List

Path

Size

contrib/

blocklist/

bin/

blacklistd.c

7 lines

Diff 152676

View Options

contrib/blocklist/bin/blacklistd.c

blacklist: Fix use of uninitialized variableAbandonedPublicActions