kern.opts.mk: Remove EFI from riscv BROKEN OPTIONS
ClosedPublic
Actions

Authored by emaste on Mar 28 2025, 1:32 PM.

Details

Reviewers

jrtc27
mhorne

Commits

rG269cbe092da3: kern.opts.mk: Remove EFI from riscv BROKEN_OPTIONS

Summary

Make this consistent with EFI's per-arch defaults in src.opts.mk. We build EFI boot programs for RISC-V.

This discrepancy previously caused make makeman to warn riscv/riscv64: ignoring duplicate option EFI.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 28 2025, 1:32 PM

emaste created this revision.

emaste added a reviewer: mhorne.

Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.

This revision is now accepted and ready to land.Mar 28 2025, 5:11 PM

Yeah, my motivation here is just the warning from make makeman. I'll note in the commit message that this is NFC.

Closed by commit rG269cbe092da3: kern.opts.mk: Remove EFI from riscv BROKEN_OPTIONS (authored by emaste). · Explain WhyMar 28 2025, 5:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG269cbe092da3: kern.opts.mk: Remove EFI from riscv BROKEN_OPTIONS.

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2025, 5:57 PM

Shouldn't src.conf.5 (make makeman) be regenerated after this change?

Revision Contents
Changeset List

Path

Size

sys/

conf/

kern.opts.mk

4 lines

Diff 152804

View Options

kern.opts.mk: Remove EFI from riscv BROKEN OPTIONSClosedPublicActions