Page MenuHomeFreeBSD

makefs: Remove redundant 'stampst' checks in several backends
ClosedPublic

Authored by markj on Apr 1 2025, 11:44 AM.
Tags
None
Referenced Files
F133501292: D49601.id155733.diff
Sun, Oct 26, 6:12 AM
Unknown Object (File)
Tue, Sep 30, 9:40 AM
Unknown Object (File)
Sun, Sep 28, 1:22 AM
Unknown Object (File)
Sep 13 2025, 2:06 AM
Unknown Object (File)
Sep 12 2025, 9:33 PM
Unknown Object (File)
Sep 12 2025, 10:29 AM
Unknown Object (File)
Sep 11 2025, 5:49 AM
Unknown Object (File)
Sep 7 2025, 11:29 PM
Subscribers

Details

Summary

PR: 285630
Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

Originally yes.

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

I tried applying the entire revision stack, but other tests failed. My main concern was that the test described in https://reviews.freebsd.org/D49492#1131965 was missed, but that is no longer the case. Thank you!

This would break the test case mentioned in D49492, where makefs ignores the time in the mtree file.
If this is the desired behavior, the test should be updated accordingly.

Are you referring to the test case you sketched here? https://reviews.freebsd.org/D49492#1131965

Originally yes.

I'm having trouble seeing the problem, given that this revision is intended to apply after D49531 -- could you please explain further?

I tried applying the entire revision stack, but other tests failed.

I believe only because they're flagged as being expected to fail, but they no longer fail. I will take a closer look tomorrow.

My main concern was that the test described in https://reviews.freebsd.org/D49492#1131965 was missed, but that is no longer the case. Thank you!

This revision is now accepted and ready to land.Apr 30 2025, 1:29 PM
markj edited reviewers, added: bnovkov; removed: markj.
This revision now requires review to proceed.May 9 2025, 2:37 PM

Remove an incorrectly dropped timestamp setting.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2025, 9:51 AM
This revision was automatically updated to reflect the committed changes.