Page MenuHomeFreeBSD

jhb (John Baldwin)
User

Projects (10)

User Details

User Since
Mar 11 2014, 8:46 PM (616 w, 1 d)

Recent Activity

Yesterday

jhb updated the diff for D54399: swab: Correctly treat the data as misaligned.

Use memcpy

Wed, Dec 31, 12:53 PM
jhb updated the summary of D54399: swab: Correctly treat the data as misaligned.
Wed, Dec 31, 12:52 PM
jhb retitled D54399: swab: Correctly treat the data as misaligned from swab: Correctly annotate the data as misaligned. to swab: Correctly treat the data as misaligned.
Wed, Dec 31, 12:52 PM
jhb added a comment to D54399: swab: Correctly treat the data as misaligned.

The arm assembly for the memcpy() variant is identical FWIW.

Wed, Dec 31, 12:47 PM

Tue, Dec 30

jhb added a comment to D54399: swab: Correctly treat the data as misaligned.

Yes, I like the memcpy version better.

Tue, Dec 30, 7:17 PM
jhb updated the diff for D54162: netlink: Optimize growing the snl_writer message buffer.

Rebase on D54397

Tue, Dec 30, 4:32 PM
jhb updated the diff for D54397: netlink: Consistently use unsigned types for message and buffer lengths.

Pass tinderbox

Tue, Dec 30, 4:29 PM
jhb requested review of D54420: acpi: Add a function to deregister all ioctl commands using the same function.
Tue, Dec 30, 4:19 PM

Mon, Dec 29

jhb added a comment to D54399: swab: Correctly treat the data as misaligned.

Hmm, looking at the code both before and after this change on armv7, it is just using plain ldrh and strh which will fault on unaligned accesses?

Mon, Dec 29, 7:37 PM
jhb added a comment to D54399: swab: Correctly treat the data as misaligned.

I tried various permutations of alignas and that didn't work either. Also, alignas apparently can't weaken alignment, only strengthen it, and alignas can't be used in a typedef.

Mon, Dec 29, 5:37 PM
jhb requested review of D54399: swab: Correctly treat the data as misaligned.
Mon, Dec 29, 5:24 PM
jhb closed D53700: sys: Declare 'end' as an extern char so that &end is a char *.

D53898 is a duplicate (not sure how I ended up with two of these).

Mon, Dec 29, 4:38 PM
jhb requested review of D54397: netlink: Consistently use unsigned types for message and buffer lengths.
Mon, Dec 29, 4:26 PM

Fri, Dec 26

jhb added inline comments to D54376: cache: avoid hardcoded zone alignment.
Fri, Dec 26, 11:17 PM
jhb committed rGbd8296bd81d5: Build acpi kernel modules on aarch64 (authored by jhb).
Build acpi kernel modules on aarch64
Fri, Dec 26, 3:44 PM
jhb committed rGfe74d52de5dc: sys/modules/acpi/Makefile: One line per subdirectory (authored by jhb).
sys/modules/acpi/Makefile: One line per subdirectory
Fri, Dec 26, 3:44 PM
jhb committed rG11757b1487e3: acpi: Statically initialize acpi_ioctl_hooks (authored by jhb).
acpi: Statically initialize acpi_ioctl_hooks
Fri, Dec 26, 3:44 PM
jhb committed rG425b41f81634: acpi: Use M_WAITOK in acpi_register_ioctl (authored by jhb).
acpi: Use M_WAITOK in acpi_register_ioctl
Fri, Dec 26, 3:44 PM
jhb committed rG4eb560faa725: acpi: Reject duplicate handlers for ioctl commands (authored by jhb).
acpi: Reject duplicate handlers for ioctl commands
Fri, Dec 26, 3:44 PM
jhb committed rG88f8e3c5ab97: acpi_apei: Remove the hest member from the softc (authored by jhb).
acpi_apei: Remove the hest member from the softc
Fri, Dec 26, 3:44 PM
jhb closed D54314: sys/modules/acpi/Makefile: One line per subdirectory.
Fri, Dec 26, 3:44 PM
jhb closed D54315: Build acpi kernel modules on aarch64.
Fri, Dec 26, 3:44 PM
jhb committed rG5b39245ab6f3: acpi: Free ivars in bus_child_deleted method (authored by jhb).
acpi: Free ivars in bus_child_deleted method
Fri, Dec 26, 3:44 PM
jhb closed D54312: acpi: Use M_WAITOK in acpi_register_ioctl.
Fri, Dec 26, 3:44 PM
jhb closed D54313: acpi: Statically initialize acpi_ioctl_hooks.
Fri, Dec 26, 3:44 PM
jhb committed rG6b2e4da44300: acpidump: Extend the decoding of entries in the EINJ and ERST tables (authored by jhb).
acpidump: Extend the decoding of entries in the EINJ and ERST tables
Fri, Dec 26, 3:44 PM
jhb closed D54311: acpi: Reject duplicate handlers for ioctl commands.
Fri, Dec 26, 3:44 PM
jhb closed D54310: acpi_apei: Remove the hest member from the softc.
Fri, Dec 26, 3:44 PM
jhb closed D54309: acpi: Free ivars in bus_child_deleted method.
Fri, Dec 26, 3:44 PM
jhb closed D54308: acpidump: Extend the decoding of entries in the EINJ and ERST tables.
Fri, Dec 26, 3:44 PM

Mon, Dec 22

jhb added inline comments to D54276: cxgbe.4: Update for recent HARDWARE.
Mon, Dec 22, 4:32 PM
jhb added inline comments to D54332: bhyve(8): Fix consistency and terms in manpage.
Mon, Dec 22, 4:21 PM
jhb added inline comments to D54322: wg: add a more useful debug message for an unknown family.
Mon, Dec 22, 4:09 PM

Fri, Dec 19

jhb added a comment to D54307: arm64: Support non-DMAP addresses for pmap_map_io_transient.

I think those issues are not made any worse by your patch? And the fix is something that RISC-V and amd64 would need as well (well, RISC-V also needs this patch). I think you should just merge your current patch and let @markj fix both amd64 and aarch64 when he adds the new arena.

Fri, Dec 19, 6:25 PM
jhb added a comment to D54312: acpi: Use M_WAITOK in acpi_register_ioctl.

BTW, I've thought about adding an acpi_unregister_ioctl_all or the like that just takes the fn argument and unregisters all commands that use the same function. That would be a nicer way to handle unloading of a module that registers multiple handlers.

Fri, Dec 19, 6:19 PM
jhb added inline comments to D54309: acpi: Free ivars in bus_child_deleted method.
Fri, Dec 19, 6:17 PM
jhb added a reverting change for rGc759aca606ce: devinfo: Add support for libxo: rGed6612dea24f: Revert "devinfo: Add support for libxo".
Fri, Dec 19, 6:17 PM
jhb added a reverting change for rGe8d6b58ef5a4: devinfo: Fix some libxo errors: rGed6612dea24f: Revert "devinfo: Add support for libxo".
Fri, Dec 19, 6:17 PM
jhb added a reverting change for rG4cf5878d27dd: devinfo.8: Document libxo support: rGed6612dea24f: Revert "devinfo: Add support for libxo".
Fri, Dec 19, 6:17 PM
jhb committed rGed6612dea24f: Revert "devinfo: Add support for libxo" (authored by jhb).
Revert "devinfo: Add support for libxo"
Fri, Dec 19, 6:16 PM
jhb committed rG33bc1fb48e32: netlink: Don't overwrite existing data in a linear buffer in snl_writer (authored by jhb).
netlink: Don't overwrite existing data in a linear buffer in snl_writer
Fri, Dec 19, 4:56 PM
jhb committed rGb79115e13010: rman: Simplify initialization of internal globals (authored by jhb).
rman: Simplify initialization of internal globals
Fri, Dec 19, 3:33 PM
jhb committed rGbe89c92739ed: bsdinstall: Mount /dev and /packages after using the shell to partition disks (authored by jhb).
bsdinstall: Mount /dev and /packages after using the shell to partition disks
Fri, Dec 19, 3:33 PM
jhb committed rGc7cc4706504e: netlink: Don't overwrite existing data in a linear buffer in snl_writer (authored by jhb).
netlink: Don't overwrite existing data in a linear buffer in snl_writer
Fri, Dec 19, 3:33 PM
jhb committed rG7087adfd960a: proc0_post: Clear relevant thread stats directly (authored by jhb).
proc0_post: Clear relevant thread stats directly
Fri, Dec 19, 3:33 PM
jhb committed rGcdad10ea780f: thread0: Clear td_rux stats in proc0_post (authored by jhb).
thread0: Clear td_rux stats in proc0_post
Fri, Dec 19, 3:33 PM
jhb committed rG5685988838e4: ruxreset: Add an inline function to reset all the stats in rusage_ext (authored by jhb).
ruxreset: Add an inline function to reset all the stats in rusage_ext
Fri, Dec 19, 3:33 PM
jhb committed rG6a99a27d4345: rman: Simplify initialization of internal globals (authored by jhb).
rman: Simplify initialization of internal globals
Fri, Dec 19, 3:33 PM
jhb committed rG11b309c0a717: netlink: Don't overwrite existing data in a linear buffer in snl_writer (authored by jhb).
netlink: Don't overwrite existing data in a linear buffer in snl_writer
Fri, Dec 19, 3:33 PM
jhb committed rG444d2f9e2152: bsdinstall: Mount /dev and /packages after using the shell to partition disks (authored by jhb).
bsdinstall: Mount /dev and /packages after using the shell to partition disks
Fri, Dec 19, 3:33 PM
jhb committed rG84140c99e54b: nvmf_tcp.4: Don't quote the document description given to .Nd (authored by jhb).
nvmf_tcp.4: Don't quote the document description given to .Nd
Fri, Dec 19, 3:33 PM
jhb committed rGc358d6c0f350: proc0_post: Clear relevant thread stats directly (authored by jhb).
proc0_post: Clear relevant thread stats directly
Fri, Dec 19, 3:33 PM
jhb committed rGebb0e512d97e: thread0: Clear td_rux stats in proc0_post (authored by jhb).
thread0: Clear td_rux stats in proc0_post
Fri, Dec 19, 3:33 PM
jhb committed rGb35c6373910a: ruxreset: Add an inline function to reset all the stats in rusage_ext (authored by jhb).
ruxreset: Add an inline function to reset all the stats in rusage_ext
Fri, Dec 19, 3:32 PM
jhb committed rG6cafc75b3930: sys: Remove/update references to the swapper process in various comments (authored by jhb).
sys: Remove/update references to the swapper process in various comments
Fri, Dec 19, 3:32 PM
jhb committed rGc512446400fa: thread0: Stop calling thread0 "swapper" (authored by jhb).
thread0: Stop calling thread0 "swapper"
Fri, Dec 19, 3:32 PM
jhb requested review of D54315: Build acpi kernel modules on aarch64.
Fri, Dec 19, 3:27 PM
jhb requested review of D54314: sys/modules/acpi/Makefile: One line per subdirectory.
Fri, Dec 19, 3:27 PM
jhb requested review of D54313: acpi: Statically initialize acpi_ioctl_hooks.
Fri, Dec 19, 3:26 PM
jhb requested review of D54312: acpi: Use M_WAITOK in acpi_register_ioctl.
Fri, Dec 19, 3:26 PM
jhb requested review of D54311: acpi: Reject duplicate handlers for ioctl commands.
Fri, Dec 19, 3:26 PM
jhb requested review of D54309: acpi: Free ivars in bus_child_deleted method.
Fri, Dec 19, 3:26 PM
jhb requested review of D54310: acpi_apei: Remove the hest member from the softc.
Fri, Dec 19, 3:26 PM
jhb requested review of D54308: acpidump: Extend the decoding of entries in the EINJ and ERST tables.
Fri, Dec 19, 3:26 PM
jhb added a comment to D54307: arm64: Support non-DMAP addresses for pmap_map_io_transient.

This is more of a RFC than a commit candidate. When I tried to use /dev/mem to access a register I got a "system error abort" panic (but mapping the same memory region with new-bus as a struct resource worked fine). The use case for me was using dd if=/dev/mem iseek=<register physical address/4> bs=4 count=1 | hd is how I got the SERR# panic. I'm not sure if the difference is that I should be using a different memattr perhaps? On amd64, this code uses pmap_kenter for the !can_fault case to avoid TLB shutdowns. I'm not sure that is as important for arm64 since shutdowns are presumably a bit cheaper which is why I did the lazy thing.

Fri, Dec 19, 3:24 PM
jhb requested review of D54307: arm64: Support non-DMAP addresses for pmap_map_io_transient.
Fri, Dec 19, 3:20 PM

Thu, Dec 18

jhb committed rGa9d8eb9e2e3c: pcic.4: Remove stale manual (authored by bofh).
pcic.4: Remove stale manual
Thu, Dec 18, 10:59 PM
jhb committed rG0002b1d651c8: Retire pccard(4) (authored by bofh).
Retire pccard(4)
Thu, Dec 18, 10:59 PM
jhb committed rGc53d90c50c77: loader.efi.8: Minor formatting nits (authored by jhb).
loader.efi.8: Minor formatting nits
Thu, Dec 18, 10:59 PM
jhb committed rGbed9eb6af70a: arm64: Fix calculating kernel size for preload metadata (authored by Hesham Almatary <Hesham.Almatary@cl.cam.ac.uk>).
arm64: Fix calculating kernel size for preload metadata
Thu, Dec 18, 10:59 PM
jhb committed rGf2164d231f4f: apm(8): Drop MLINK to apmconf(8) (authored by jhb).
apm(8): Drop MLINK to apmconf(8)
Thu, Dec 18, 10:59 PM
jhb committed rG3a25f21eed6e: kmod.mk: Remove a trailing reference to pccarddevs.h (authored by jhb).
kmod.mk: Remove a trailing reference to pccarddevs.h
Thu, Dec 18, 10:59 PM
jhb committed rG400e08173e84: loader.efi.8: Minor formatting nits (authored by jhb).
loader.efi.8: Minor formatting nits
Thu, Dec 18, 10:58 PM
jhb committed rG37e9b420b23a: arm64: Fix calculating kernel size for preload metadata (authored by Hesham Almatary <Hesham.Almatary@cl.cam.ac.uk>).
arm64: Fix calculating kernel size for preload metadata
Thu, Dec 18, 10:58 PM
jhb committed rGfe9134294b22: apm(8): Drop MLINK to apmconf(8) (authored by jhb).
apm(8): Drop MLINK to apmconf(8)
Thu, Dec 18, 10:58 PM
jhb committed rGc6504647e06a: kmod.mk: Remove a trailing reference to pccarddevs.h (authored by jhb).
kmod.mk: Remove a trailing reference to pccarddevs.h
Thu, Dec 18, 10:58 PM
jhb added a comment to D54298: [PHB]: Only document __FreeBSD_version values for supported branches.

Ed noted that this file has grown very large, so this change trims it to only show entries for supported branches. In particular, if the goal (as I understand it) is to help porters know which versions to use when maintaining ports, then there isn't really a need to document values from unsupported branches.

Thu, Dec 18, 10:34 PM
jhb requested review of D54298: [PHB]: Only document __FreeBSD_version values for supported branches.
Thu, Dec 18, 10:33 PM
jhb committed R9:39cc0a2b2a41: Document __FreeBSD_version bumps 1500504 and 1403507 (authored by jhb).
Document __FreeBSD_version bumps 1500504 and 1403507
Thu, Dec 18, 10:22 PM
jhb committed R9:481fce462dc6: Document various missing __FreeBSD_version values. (authored by jhb).
Document various missing __FreeBSD_version values.
Thu, Dec 18, 10:22 PM
jhb committed rG3fbce8315ee2: bus_alloc_resource: First step in passing resource IDs by value (authored by jhb).
bus_alloc_resource: First step in passing resource IDs by value
Thu, Dec 18, 8:48 PM
jhb committed rG108b5d90bc1f: bus_alloc_resource: First step in passing resource IDs by value (authored by jhb).
bus_alloc_resource: First step in passing resource IDs by value
Thu, Dec 18, 8:48 PM
jhb committed rG857d3887e664: getconf: Report value of _SC_PHYS_PAGES (authored by jwb).
getconf: Report value of _SC_PHYS_PAGES
Thu, Dec 18, 7:14 PM
jhb committed rG7f33109a13f9: closefrom_test: Convert to atf-c(3) (authored by jhb).
closefrom_test: Convert to atf-c(3)
Thu, Dec 18, 7:14 PM
jhb committed rGee5ad300a0df: closefrom_test: Fix the first test (authored by jhb).
closefrom_test: Fix the first test
Thu, Dec 18, 7:14 PM
jhb committed rG1a9ecead726a: getconf: Report value of _SC_PHYS_PAGES (authored by jwb).
getconf: Report value of _SC_PHYS_PAGES
Thu, Dec 18, 7:14 PM
jhb committed rG319f32a1748e: Fix grammar error in test/sys/file/closefrom_test.c (authored by Yen-Cheng Chang <jonason2004@gmail.com>).
Fix grammar error in test/sys/file/closefrom_test.c
Thu, Dec 18, 7:14 PM
jhb committed rG1e6728be9380: closefrom_test: Convert to atf-c(3) (authored by jhb).
closefrom_test: Convert to atf-c(3)
Thu, Dec 18, 7:14 PM
jhb committed rG9207e31ba142: closefrom_test: Fix the first test (authored by jhb).
closefrom_test: Fix the first test
Thu, Dec 18, 7:14 PM
jhb committed rG198cd4912f30: ctld: Defer initialization of NVMeoF associations (authored by jhb).
ctld: Defer initialization of NVMeoF associations
Thu, Dec 18, 7:14 PM
jhb committed rGd866f1d4f968: aarch64: Save correct value of x18 on trapframe for nested faults (authored by def).
aarch64: Save correct value of x18 on trapframe for nested faults
Thu, Dec 18, 6:43 PM
jhb committed rGc9be34e2e6af: aarch64: Clarify the initial adjustments to sp for kernel exception entry (authored by jhb).
aarch64: Clarify the initial adjustments to sp for kernel exception entry
Thu, Dec 18, 6:42 PM
jhb committed rG051540a092d1: aarch64: Save correct value of x18 on trapframe for nested faults (authored by def).
aarch64: Save correct value of x18 on trapframe for nested faults
Thu, Dec 18, 6:42 PM
jhb committed rG186154414173: aarch64: Clarify the initial adjustments to sp for kernel exception entry (authored by jhb).
aarch64: Clarify the initial adjustments to sp for kernel exception entry
Thu, Dec 18, 6:42 PM
jhb committed rG7bf3b6d8e426: fcntl(F_SETFL): only allow one thread to perform F_SETFL (authored by kib).
fcntl(F_SETFL): only allow one thread to perform F_SETFL
Thu, Dec 18, 6:24 PM
jhb committed rG6acf7356d859: filedesc: Close race between fcntl(F_SETFL) and ioctl(FIONBIO/FIOASYNC) (authored by jhb).
filedesc: Close race between fcntl(F_SETFL) and ioctl(FIONBIO/FIOASYNC)
Thu, Dec 18, 6:23 PM
jhb committed rG11870bb24801: fcntl(F_SETFL): only allow one thread to perform F_SETFL (authored by kib).
fcntl(F_SETFL): only allow one thread to perform F_SETFL
Thu, Dec 18, 6:23 PM
jhb committed rG200e1ca48fdc: fcntlflags_test: Port to atf-c(3) (authored by jhb).
fcntlflags_test: Port to atf-c(3)
Thu, Dec 18, 6:23 PM
jhb committed rGb3aada5bfdb9: fcntl(F_SETFL): Don't unconditionally invoke FIONBIO and FIOASYNC (authored by jhb).
fcntl(F_SETFL): Don't unconditionally invoke FIONBIO and FIOASYNC
Thu, Dec 18, 6:23 PM
jhb committed rGf9c7de5c9c67: fcntlflags_test: Port to atf-c(3) (authored by jhb).
fcntlflags_test: Port to atf-c(3)
Thu, Dec 18, 6:23 PM