Differential D49266

acpi_pci: Use pci_has_pm and pci_clear_pme
ClosedPublic
Actions

Authored by jhb on Mar 6 2025, 6:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 1:57 AM

	Unknown Object (File)
	Sat, May 16, 1:56 AM

	Unknown Object (File)
	Sat, May 16, 1:56 AM

	Unknown Object (File)
	Mon, May 11, 3:14 AM

	Unknown Object (File)
	Wed, Apr 29, 6:22 PM

	Unknown Object (File)
	Tue, Apr 28, 4:28 PM

	Unknown Object (File)
	Tue, Apr 28, 4:25 PM

	Unknown Object (File)
	Thu, Apr 23, 2:34 AM

View All 100 Files

Subscribers

None

Details

Reviewers

cperciva
imp

Commits

rGa2de254b2007: acpi_pci: Use pci_has_pm and pci_clear_pme
rG931baeb62b03: acpi_pci: Use pci_has_pm and pci_clear_pme

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Mar 6 2025, 6:20 PM

jhb created this revision.

Harbormaster completed remote builds in B62802: Diff 151975.Mar 6 2025, 6:20 PM

jhb added a parent revision: D49251: dev: Use recently added improvements to PME# support to simplify drivers.Mar 6 2025, 6:23 PM

jhb added a child revision: D49267: pci: Use a single variable for the offset of the power management registers.

Looks reasonable to me. Should I test in EC2? (If yes, which other patches do I need?)

In D49266#1123513, @cperciva wrote:

Looks reasonable to me. Should I test in EC2? (If yes, which other patches do I need?)

You would need D49222 and D49250.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2025, 9:00 PM

Closed by commit rG931baeb62b03: acpi_pci: Use pci_has_pm and pci_clear_pme (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG931baeb62b03: acpi_pci: Use pci_has_pm and pci_clear_pme.

jhb added a commit: rGa2de254b2007: acpi_pci: Use pci_has_pm and pci_clear_pme.Apr 29 2025, 6:31 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

10 lines

Diff 152769

sys/dev/acpica/acpi_pci.c

Loading...