The thought was it would be better to have the ids in a file (rather than in code). This would allow masks too. And we could reuse it for pci.

Aarch64 can have 16k pages. There are Experimental patches for amd64 to have 32k pages. I'm not sure it matters though..

This looks good to me.

In D45404#1141958, @olce wrote:

Indeed, there is the question of whether the mapped memory could be used by the VM. russor_ruka.org implies it should not as it is removed from the BIOS SMAP.

I'm not aware of a common facility to exclude physical memory regions early, or one to do that after vm_page_startup() starts (and bases its actions upon phys_avail[] and vm_phys_early_segs[]). There are two ways finally leading to filling phys_avail[]: amd64 & i386 use physmap[] (see add_physmap_entry()/bios_add_smap_entries()), whereas arm64 (and riscv IIRC) use the facilities in subr_physmem.c (there is a physmem_exclude_region() function). If limited to amd64, this would have to go into machdep.c. I'm not sure if it's possible to query hints that early.

In D49970#1142028, @jhb wrote:

In D49970#1141843, @olce wrote:

In D49970#1141669, @jhb wrote:

Originally it ways always tab. The change to permit spaces is recent, and older code from BSD should probably stay as it was to avoid churn. It seems the recent additions to this file just failed to follow the part about "match the existing style".

FWIW, I've added the corresponding commit to .git-blame-ignore-revs (as requested by markj@) so that it doesn't show up in git blame (provided git is so configured).

Would you like me to switch to all tabs instead?

No, it is not worth the churn. Just check match the existing style in the future was my only real original point.

In D50016#1142030, @jhb wrote:

In D50016#1141998, @mhorne wrote:

Thanks, this is great.

To me it is preferable to replace the repeated #ifdef __arm__ instances with a named flag, e.g. #ifdef DEVMAP_HAS_STATIC. If it is annoying to achieve then no problem.

We could add a __HAVE_STATIC_DEVMAP in <machine/param.h>. Similar to what we do for __HAVE_ACPI.

update per kyle's suggestion