Page MenuHomeFreeBSD

efivar: Add some explicit casts to uuid_t
ClosedPublic

Authored by imp on Apr 25 2025, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 3:39 AM
Unknown Object (File)
Tue, Sep 30, 6:07 AM
Unknown Object (File)
Sep 4 2025, 12:14 PM
Unknown Object (File)
Aug 13 2025, 2:07 PM
Unknown Object (File)
Aug 9 2025, 4:32 AM
Unknown Object (File)
Aug 8 2025, 10:32 PM
Unknown Object (File)
Aug 8 2025, 5:57 AM
Unknown Object (File)
Aug 7 2025, 4:17 PM
Subscribers
None

Details

Summary

Since we know we're type-punning the EFI_GUID to a uuid_t, add some
explicit casts even though, at the moment, we typedef one to the other.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 25 2025, 7:33 PM
imp created this revision.

I would add some type-checking for the conversion. E.g you could define inlines uuid_t * efi_guid_to_uuid(efi_guid_t *) and const uuid_t *const_efi_guid_to_uuid(const efi_guid_t *) and use them instead of manually writing the cast.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2025, 6:06 PM
This revision was automatically updated to reflect the committed changes.