Page MenuHomeFreeBSD

efivar: Add some explicit casts to uuid_t
ClosedPublic

Authored by imp on Apr 25 2025, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 12, 3:01 PM
Unknown Object (File)
Sun, Feb 8, 5:38 AM
Unknown Object (File)
Sat, Feb 7, 6:06 PM
Unknown Object (File)
Sat, Jan 31, 6:14 AM
Unknown Object (File)
Sun, Jan 25, 10:05 AM
Unknown Object (File)
Tue, Jan 20, 3:10 PM
Unknown Object (File)
Sat, Jan 17, 1:52 PM
Unknown Object (File)
Jan 13 2026, 12:22 PM
Subscribers
None

Details

Summary

Since we know we're type-punning the EFI_GUID to a uuid_t, add some
explicit casts even though, at the moment, we typedef one to the other.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 25 2025, 7:33 PM
imp created this revision.

I would add some type-checking for the conversion. E.g you could define inlines uuid_t * efi_guid_to_uuid(efi_guid_t *) and const uuid_t *const_efi_guid_to_uuid(const efi_guid_t *) and use them instead of manually writing the cast.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2025, 6:06 PM
This revision was automatically updated to reflect the committed changes.