Paths

Table of Contentst

Differential D50034

efivar: Test uuid against zero
ClosedPublic
Actions

Authored by imp on Apr 25 2025, 7:33 PM.

Tags

None

Referenced Files

	F166569390: D50034.id154432.diff
	Fri, Aug 14, 2:24 PM

	Unknown Object (File)
	Mon, Aug 10, 8:26 PM

	Unknown Object (File)
	Mon, Aug 10, 6:56 PM

	Unknown Object (File)
	Mon, Aug 10, 6:56 PM

	Unknown Object (File)
	Mon, Aug 10, 6:55 PM

	Unknown Object (File)
	Wed, Aug 5, 8:59 PM

	Unknown Object (File)
	Wed, Aug 5, 5:08 AM

	Unknown Object (File)
	Wed, Aug 5, 4:51 AM

Subscribers

None

Details

Reviewers

tsoome
kevans
kib

Commits

rG5f2dd25a9e71: efivar: Test uuid against zero

Summary

Test the passed in GuID against a guid of all 0's. This removes another
place that has to worry about the difference between uuit_t and
EFI_GUID.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 25 2025, 7:33 PM

imp created this revision.

Harbormaster completed remote builds in B63739: Diff 154304.Apr 25 2025, 7:33 PM

imp added a parent revision: D50033: efivar: Use memcmp instead of uuid_ functions to compare.Apr 25 2025, 7:33 PM

imp added a child revision: D50035: efivar: Allow uuid_t and efi_guid_t to be different types..

kevans added inline comments.Apr 25 2025, 7:36 PM

lib/libefivar/efivar.c
295	Consider dropping `zero` in favor of `efi_guid_empty`

update per kyle's suggestion

Harbormaster completed remote builds in B63766: Diff 154432.Apr 29 2025, 2:05 AM

kib accepted this revision.Apr 29 2025, 10:19 AM

This revision is now accepted and ready to land.Apr 29 2025, 10:19 AM

Closed by commit rG5f2dd25a9e71: efivar: Test uuid against zero (authored by imp). · Explain WhyMay 1 2025, 6:06 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5f2dd25a9e71: efivar: Test uuid against zero.

Revision Contents
Changeset List

Path

Size

lib/

libefivar/

5 lines

Diff 154635

lib/libefivar/efivar.c

Loading...