Page MenuHomeFreeBSD

chandrakanth.patil_broadcom.com (chandrakanth patil)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2022, 6:23 AM (102 w, 51 m)

Recent Activity

Tue, Jul 9

chandrakanth.patil_broadcom.com added a comment to D45729: bnxt_re: Add Userspace Library Support for RoCE Driver.

Thank you all for reviewing the code.

Tue, Jul 9, 7:48 AM

Fri, Jul 5

chandrakanth.patil_broadcom.com updated the diff for D45729: bnxt_re: Add Userspace Library Support for RoCE Driver.
  • I missed updating the SPATH for CFLAGS in the Makefile. This has been corrected in the current revision.
Fri, Jul 5, 8:00 AM
chandrakanth.patil_broadcom.com updated the diff for D45729: bnxt_re: Add Userspace Library Support for RoCE Driver.
  • Updated the Makefile. Renamed the _spath varaible to SPATH
  • reordered the header files as per the style.9 man page standard
  • removed the manual #define of bool flags.
Fri, Jul 5, 7:47 AM
chandrakanth.patil_broadcom.com added inline comments to D45729: bnxt_re: Add Userspace Library Support for RoCE Driver.
Fri, Jul 5, 7:37 AM

Tue, Jun 25

chandrakanth.patil_broadcom.com requested review of D45729: bnxt_re: Add Userspace Library Support for RoCE Driver.
Tue, Jun 25, 10:36 AM

Jun 1 2024

chandrakanth.patil_broadcom.com added a comment to D45203: bnxt_re/bnxt_en: man page support for bnxt_re driver.

Hi Markj

Jun 1 2024, 7:33 AM
chandrakanth.patil_broadcom.com updated the diff for D45203: bnxt_re/bnxt_en: man page support for bnxt_re driver.
  • Accommodated all the review feedback
Jun 1 2024, 7:31 AM

May 15 2024

chandrakanth.patil_broadcom.com added reviewers for D45203: bnxt_re/bnxt_en: man page support for bnxt_re driver: imp, sumit.saxena_broadcom.com, markj.
May 15 2024, 7:27 AM
chandrakanth.patil_broadcom.com requested review of D45203: bnxt_re/bnxt_en: man page support for bnxt_re driver.
May 15 2024, 7:26 AM
chandrakanth.patil_broadcom.com requested review of D45202: bnxt_re/bnxt_en: Makefile update.
May 15 2024, 7:26 AM

May 8 2024

chandrakanth.patil_broadcom.com added a comment to D45011: RDMA/bnxt_re: Add bnxt_re RoCE driver.
In D45011#1028836, @imp wrote:

The build is good, modulo one quibble.
The rest looks OK, but is really too large for me to review.

May 8 2024, 8:54 AM
chandrakanth.patil_broadcom.com added a comment to D45011: RDMA/bnxt_re: Add bnxt_re RoCE driver.

Could you please add a manual page for the new drivers, or extend the existing share/man/man4/bnxt.4?

Thanks for the feedback! I'll create a new man page for the new RoCE drivers and submit it accordingly.

May 8 2024, 8:37 AM
chandrakanth.patil_broadcom.com added a comment to D45009: bnxt_en: Firmware header version update to 1.10.3.42.
In D45009#1028830, @imp wrote:

ah, mechanically generated code.

May 8 2024, 8:15 AM
chandrakanth.patil_broadcom.com added a comment to D45007: bnxt_en: Added support for priority queues extended stats.
In D45007#1028826, @imp wrote:

This looks straight forward enough that I'm happy ...

May 8 2024, 8:13 AM
chandrakanth.patil_broadcom.com added a comment to D45006: bnxt_en: L2-RoCE driver communication interface.

Thanks for the review! I will update the Makefile.

May 8 2024, 8:12 AM
chandrakanth.patil_broadcom.com added a comment to D45005: bnxt_en: Add PFC, ETS & App TLVs protocols support.
In D45005#1028822, @imp wrote:

The build stuff looks good.

Thank you. I am glad that the build changes are acceptable.

I can't speak to the hardware.

Thanks for the input! Regarding the hardware, I've tested the patch on relevant hardware and haven't encountered any issues. While I don't currently have documentation detailing the testing process, I can assure you that thorough testing has been conducted. If there's any specific information you need or if further testing is required on certain hardware configurations, please let me know, and I'll be happy to provide it

The extraneous (white space) changes are relatively low for vendor updates and don't get too much .

Thanks for your input! We'll address the whitespace in a separate cleanup patch after this patchset accepted.

May 8 2024, 7:19 AM

Apr 29 2024

chandrakanth.patil_broadcom.com requested review of D45011: RDMA/bnxt_re: Add bnxt_re RoCE driver.
Apr 29 2024, 12:27 PM
chandrakanth.patil_broadcom.com added reviewers for D45010: bnxt_en: Driver version update to 230.0.133.0: sumit.saxena_broadcom.com, imp.
Apr 29 2024, 12:25 PM
chandrakanth.patil_broadcom.com requested review of D45010: bnxt_en: Driver version update to 230.0.133.0.
Apr 29 2024, 12:25 PM
chandrakanth.patil_broadcom.com requested review of D45009: bnxt_en: Firmware header version update to 1.10.3.42.
Apr 29 2024, 12:24 PM
chandrakanth.patil_broadcom.com requested review of D45008: bnxt_en: Firmware error recovery support.
Apr 29 2024, 12:23 PM
chandrakanth.patil_broadcom.com requested review of D45007: bnxt_en: Added support for priority queues extended stats.
Apr 29 2024, 12:21 PM
chandrakanth.patil_broadcom.com requested review of D45006: bnxt_en: L2-RoCE driver communication interface.
Apr 29 2024, 12:19 PM
chandrakanth.patil_broadcom.com requested review of D45005: bnxt_en: Add PFC, ETS & App TLVs protocols support.
Apr 29 2024, 12:08 PM

Mar 25 2024

chandrakanth.patil_broadcom.com added a comment to D44494: mpi3r: Track IO per target counter during queue poll with local var.
In D44494#1014836, @imp wrote:

Change looks good, but you'll want to edit the 'subject' of the commit message to be < 70 characters

Mar 25 2024, 5:38 PM
chandrakanth.patil_broadcom.com retitled D44494: mpi3r: Track IO per target counter during queue poll with local var from mpi3r: Use a local variable for retrieving the IO outstanding counter per target when polling the reply queue to mpi3r: Track IO per target counter during queue poll with local var.
Mar 25 2024, 5:37 PM
chandrakanth.patil_broadcom.com added inline comments to D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.
Mar 25 2024, 6:07 AM
chandrakanth.patil_broadcom.com requested review of D44494: mpi3r: Track IO per target counter during queue poll with local var.
Mar 25 2024, 6:06 AM

Mar 22 2024

chandrakanth.patil_broadcom.com added inline comments to D44452: mpi3mr: Divert WriteSame IOs which has unmap and ndob bit set to firmware if its transfer length exceeds firmware limit..
Mar 22 2024, 9:50 AM
chandrakanth.patil_broadcom.com added a comment to D44422: mpi3mr: Add controller state check before enabling PEL.
In D44422#1013860, @mav wrote:

I am not a big fan of kernel printing something in response to arbitrary user requests, it makes logs messy. Is the error reporting to user is not enough here?

If we keep the printfs, while device_printf() is better than just printf() used in other places (that is dirty), shouldn't we better use mpi3mr_dprint(), respecting configured driver debug level? I see there even special MPI3MR_DEBUG_IOCTL level for IOCTL's.

Mar 22 2024, 9:46 AM
chandrakanth.patil_broadcom.com added inline comments to D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.
Mar 22 2024, 9:44 AM
chandrakanth.patil_broadcom.com added inline comments to D44425: mpi3mr: Update consumerindex of admin and op reply queues after every 100 replies.
Mar 22 2024, 8:00 AM
chandrakanth.patil_broadcom.com added a comment to D44426: mpi3mr: Consider Diagnostic Fault Reset Success Beyond 0xF000 fault Code.
In D44426#1013880, @mav wrote:

I don't have any chip documentation to know what is right here, so just wonder if unconditional printing a bunch of raw hex numbers is expected here. It feels mpi3mr_print_fault_info() is another candidate for mpi3mr_dprint().

Mar 22 2024, 7:54 AM
chandrakanth.patil_broadcom.com added inline comments to D44427: mpi3mr: Adding FreeBSD OS Type to Fault/Reset Reason Code.
Mar 22 2024, 7:47 AM

Mar 21 2024

chandrakanth.patil_broadcom.com requested review of D44452: mpi3mr: Divert WriteSame IOs which has unmap and ndob bit set to firmware if its transfer length exceeds firmware limit..
Mar 21 2024, 12:02 PM
chandrakanth.patil_broadcom.com added a comment to D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.
In D44423#1013705, @imp wrote:

Fine as it is if the same sort of redundancy is done elsewhere

Mar 21 2024, 11:18 AM
chandrakanth.patil_broadcom.com updated the summary of D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.
Mar 21 2024, 11:16 AM
chandrakanth.patil_broadcom.com added a comment to D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.

Need to adjust patch description a bit to keep code changes and description better aligned.

Mar 21 2024, 9:30 AM

Mar 19 2024

chandrakanth.patil_broadcom.com requested review of D44430: mpi3mr: Update driver version to 8.10.0.1.0.
Mar 19 2024, 11:42 AM
chandrakanth.patil_broadcom.com requested review of D44429: mpi3mr: Update copyright year to 2024.
Mar 19 2024, 11:41 AM
chandrakanth.patil_broadcom.com requested review of D44428: mpi3mr: Update mpi header to latest version.
Mar 19 2024, 11:40 AM
chandrakanth.patil_broadcom.com requested review of D44427: mpi3mr: Adding FreeBSD OS Type to Fault/Reset Reason Code.
Mar 19 2024, 11:37 AM
chandrakanth.patil_broadcom.com requested review of D44426: mpi3mr: Consider Diagnostic Fault Reset Success Beyond 0xF000 fault Code.
Mar 19 2024, 11:36 AM
chandrakanth.patil_broadcom.com requested review of D44425: mpi3mr: Update consumerindex of admin and op reply queues after every 100 replies.
Mar 19 2024, 11:35 AM
chandrakanth.patil_broadcom.com requested review of D44424: mpi3mr: Decrement per controller and per target IO counter post controller reset.
Mar 19 2024, 11:34 AM
chandrakanth.patil_broadcom.com requested review of D44423: mpi3mr: poll reply queue and add MPI3MR_DEV_REMOVE_HS_COMPLETED flag.
Mar 19 2024, 11:31 AM
chandrakanth.patil_broadcom.com requested review of D44422: mpi3mr: Add controller state check before enabling PEL.
Mar 19 2024, 11:29 AM
chandrakanth.patil_broadcom.com requested review of D44421: mpi3mr: Block devices persist despite being offlined during reset.
Mar 19 2024, 11:28 AM

Feb 8 2024

chandrakanth.patil_broadcom.com added a comment to D42955: if_bnxt: Update Firmware Header to Latest Version 1.10.2.136.

Hi Warner,

Feb 8 2024, 10:39 AM

Dec 7 2023

chandrakanth.patil_broadcom.com requested review of D42960: if_bnxt: Set 1G/10G baseT force speed as auto speeds.
Dec 7 2023, 12:40 PM
chandrakanth.patil_broadcom.com requested review of D42959: if_bnxt: 50G, 100G and 200G PAM4 support.
Dec 7 2023, 12:39 PM
chandrakanth.patil_broadcom.com requested review of D42958: if_bnxt: Pluggable Module Display Support.
Dec 7 2023, 12:38 PM
chandrakanth.patil_broadcom.com requested review of D42957: if_bnxt: Implementation of Extended Port Hardware Stats Support for THOR Controller.
Dec 7 2023, 12:37 PM
chandrakanth.patil_broadcom.com added reviewers for D42956: if_bnxt: Integrate AOC Cable Support into Current 40G PHY Speed: sumit.saxena_broadcom.com, imp.
Dec 7 2023, 12:36 PM
chandrakanth.patil_broadcom.com requested review of D42956: if_bnxt: Integrate AOC Cable Support into Current 40G PHY Speed.
Dec 7 2023, 12:35 PM
chandrakanth.patil_broadcom.com requested review of D42955: if_bnxt: Update Firmware Header to Latest Version 1.10.2.136.
Dec 7 2023, 12:34 PM
chandrakanth.patil_broadcom.com requested review of D42954: if_bnxt: Update Maximum Configurable MTU from 9000 to 9600.
Dec 7 2023, 12:33 PM
chandrakanth.patil_broadcom.com requested review of D42953: if_bnxt: Enabled support for 1G SX, CX, and LX forced speed settings.
Dec 7 2023, 12:31 PM
chandrakanth.patil_broadcom.com requested review of D42952: if_bnxt: Incorrect Labeling of Supported Medium in `ifconfig -m <inf>` Command.
Dec 7 2023, 12:30 PM
chandrakanth.patil_broadcom.com requested review of D42951: if_bnxt: Fix media speed update issue in "ifconfig -m" during PHY hot plug.
Dec 7 2023, 12:29 PM
chandrakanth.patil_broadcom.com requested review of D42950: if_bnxt: Correcting the firmware package version parsing logic..
Dec 7 2023, 12:27 PM