Page MenuHomeFreeBSD

mpi3mr: Consider Diagnostic Fault Reset Success Beyond 0xF000 fault Code
AcceptedPublic

Authored by chandrakanth.patil_broadcom.com on Mar 19 2024, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 4:37 PM
Unknown Object (File)
Mar 24 2024, 7:56 PM
Unknown Object (File)
Mar 22 2024, 7:47 PM
Unknown Object (File)
Mar 20 2024, 4:51 PM
Subscribers
None

Details

Summary

Accept any fault as successful for diagnostic fault reset, not just the 0xF000
code. print fault information and return.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Mar 21 2024, 8:16 AM

I don't have any chip documentation to know what is right here, so just wonder if unconditional printing a bunch of raw hex numbers is expected here. It feels mpi3mr_print_fault_info() is another candidate for mpi3mr_dprint().

In D44426#1013880, @mav wrote:

I don't have any chip documentation to know what is right here, so just wonder if unconditional printing a bunch of raw hex numbers is expected here. It feels mpi3mr_print_fault_info() is another candidate for mpi3mr_dprint().

Agreed. There are so many other places where we need to take care of this kind of printing so we are preparing the debug improvement patch and will submit it soon which will cover this as well.