loader.efi: add error printouts for chain command
Needs ReviewPublic
Actions

Authored by tsoome on May 1 2025, 7:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 12, 2:12 AM

	Unknown Object (File)
	Mon, Jun 30, 5:31 PM

	Unknown Object (File)
	Sun, Jun 29, 6:19 PM

	Unknown Object (File)
	Sun, Jun 29, 8:05 AM

	Unknown Object (File)
	Jun 13 2025, 9:57 AM

	Unknown Object (File)
	Jun 12 2025, 9:54 AM

	Unknown Object (File)
	Jun 10 2025, 3:46 AM

	Unknown Object (File)
	Jun 2 2025, 4:42 AM

Subscribers

Details

Reviewers

manu

Summary

Current loader.efi chain command can fail with mysterious
"LoadImage failed" or "StartImage failed". Since the error codes
may have multiple causes, print out the UEFI error codes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63815
Build 60699: arc lint + arc unit

Event Timeline

tsoome created this revision.May 1 2025, 7:37 AM

Herald added a reviewer: manu. · View Herald TranscriptMay 1 2025, 7:37 AM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

tsoome requested review of this revision.May 1 2025, 7:37 AM

Harbormaster completed remote builds in B63815: Diff 154606.May 1 2025, 7:37 AM

imp added inline comments.May 1 2025, 5:35 PM

stand/efi/loader/main.c
1907	Shouldn't we be also setting command_errmsg? I'm confused why you removed that...
1924	Either remove (void) entirely, or remove the space between it and the function call.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

main.c

11 lines

Diff 154606

View Options

loader.efi: add error printouts for chain commandNeeds ReviewPublicActions