Page MenuHomeFreeBSD

igoro (Igor Ostapenko)
User

Projects

User Details

User Since
Mar 2 2023, 11:30 AM (136 w, 3 d)

Recent Activity

Yesterday

igoro committed rG21716b6c3ed6: kyua: Make "test" command actually report about workdir cleanup issues (authored by igoro).
kyua: Make "test" command actually report about workdir cleanup issues
Sat, Oct 11, 1:17 PM
igoro closed D51136: kyua: Make "test" command actually report about workdir cleanup issues.
Sat, Oct 11, 1:17 PM
igoro committed rG771ee17c8810: mit-krb5.pc: Add missing -lkrb5profile (authored by igoro).
mit-krb5.pc: Add missing -lkrb5profile
Sat, Oct 11, 11:04 AM
igoro committed rG2d9fd2c573c3: mit-krb5.pc: Add missing -lkrb5profile (authored by igoro).
mit-krb5.pc: Add missing -lkrb5profile
Sat, Oct 11, 10:24 AM
igoro closed D52910: mit-krb5.pc: Add missing -lkrb5profile.
Sat, Oct 11, 10:24 AM

Fri, Oct 10

igoro added a comment to D52910: mit-krb5.pc: Add missing -lkrb5profile.
In D52910#1211188, @ivy wrote:

i'm not opposed to this, but i don't understand why it's required. is this an upstream bug, or are we building libkrb5 wrongly?

Fri, Oct 10, 9:35 AM

Sun, Oct 5

igoro added a comment to D48087: kyua: Add "prepare" command.

Thanks for your time and review.

Sun, Oct 5, 7:52 PM
igoro updated the diff for D48087: kyua: Add "prepare" command.

Tiny improvements

Sun, Oct 5, 7:50 PM

Sat, Oct 4

igoro added reviewers for D52910: mit-krb5.pc: Add missing -lkrb5profile: cy, security, dch.
Sat, Oct 4, 10:48 PM
igoro added a comment to D52910: mit-krb5.pc: Add missing -lkrb5profile.

This seems to be revealed with the recent switch to MIT version. For example, 15-CURRENT back in March had this:

# ldd /usr/lib/libkrb5.so
/usr/lib/libkrb5.so:
        libasn1.so.11 => /usr/lib/libasn1.so.11 (0x36e32d570000)
        libcom_err.so.5 => /usr/lib/libcom_err.so.5 (0x36e309956000)
        libcrypt.so.5 => /lib/libcrypt.so.5 (0x36e30a44a000)
        libcrypto.so.30 => /lib/libcrypto.so.30 (0x36e30a600000)
        libhx509.so.11 => /usr/lib/libhx509.so.11 (0x36e339780000)
        libroken.so.11 => /usr/lib/libroken.so.11 (0x36e30ac5a000)
        libwind.so.11 => /usr/lib/libwind.so.11 (0x36e33bec0000)
        libheimbase.so.11 => /usr/lib/libheimbase.so.11 (0x36e30834e000)
        libprivateheimipcc.so.11 => /usr/lib/libprivateheimipcc.so.11 (0x36e30ba76000)
        libc.so.7 => /lib/libc.so.7 (0x36e308e00000)
        libmd.so.7 => /lib/libmd.so.7 (0x36e30c885000)
        libthr.so.3 => /lib/libthr.so.3 (0x36e30d741000)
        libsys.so.7 => /lib/libsys.so.7 (0x36e318150000)
Sat, Oct 4, 10:45 PM
igoro requested review of D52910: mit-krb5.pc: Add missing -lkrb5profile.
Sat, Oct 4, 10:32 PM

Sun, Sep 21

igoro added a reviewer for D52642: kyua: Add "debug -x|--execute cmd" option: tests.
Sun, Sep 21, 4:15 PM

Sat, Sep 20

igoro added a reviewer for D52642: kyua: Add "debug -x|--execute cmd" option: markj.
Sat, Sep 20, 3:52 PM
igoro added a comment to D52642: kyua: Add "debug -x|--execute cmd" option.

The prototype has the following logic currently:

Sat, Sep 20, 3:52 PM
igoro updated the diff for D52642: kyua: Add "debug -x|--execute cmd" option.

Always attempt to use $SHELL

Sat, Sep 20, 3:49 PM
igoro requested review of D52642: kyua: Add "debug -x|--execute cmd" option.
Sat, Sep 20, 3:35 PM

Sep 6 2025

igoro updated the summary of D48087: kyua: Add "prepare" command.
Sep 6 2025, 12:35 AM

Sep 5 2025

igoro added a comment to D51136: kyua: Make "test" command actually report about workdir cleanup issues.

What was the behavior prior to this change?

It's turned out that kyua test catches issues with temporary dir/files cleanup but does not propagate it -- that's obvious from the code where test_result is not used actually. As a result, a test is marked as passed leaving garbage behind (tmp dirs/files), while by design and code comments it is expected to be broken instead.

Will this cause false positives with cleanup failures?

Sep 5 2025, 11:56 PM
igoro updated the diff for D48087: kyua: Add "prepare" command.

Rebase onto the latest kyua changes and rework from rr to prepare

Sep 5 2025, 11:49 PM

Aug 24 2025

igoro committed rG3eeeaf9cfbc1: pf tests: Improve assertion messaging of mbuf tests (authored by igoro).
pf tests: Improve assertion messaging of mbuf tests
Aug 24 2025, 7:49 PM
igoro closed D51716: pf tests: Improve assertion messaging of mbuf tests.
Aug 24 2025, 7:49 PM

Aug 16 2025

igoro committed rG939fec44a793: kyua: Improve required_kmods metadata (authored by igoro).
kyua: Improve required_kmods metadata
Aug 16 2025, 11:23 PM

Aug 3 2025

igoro added reviewers for D51716: pf tests: Improve assertion messaging of mbuf tests: kp, tests.
Aug 3 2025, 2:45 PM
igoro added a comment to D51716: pf tests: Improve assertion messaging of mbuf tests.

A minuscule improvement to get the following upon atf_check_equal failure:

Error Message:
1 != $(jexec alcatraz sysctl -n net.dummymbuf.hits) (1 != 2)

instead of this:

Error Message:
1 != 2 (1 != 2)
Aug 3 2025, 2:44 PM
igoro requested review of D51716: pf tests: Improve assertion messaging of mbuf tests.
Aug 3 2025, 2:38 PM

Aug 1 2025

igoro accepted D51680: kyua: Stop using readdir_r().

LGTM

Aug 1 2025, 10:56 PM

Jul 18 2025

igoro accepted D51408: pf tests: make mbuf:inet6_in_mbuf_len more robust.

Thank you very much for identifying the root cause. I've been monitoring the false positives on the CI since Oct-2024 -- 25 of them so far. And my TODO list is too deep.

Jul 18 2025, 1:45 PM

Jul 13 2025

igoro committed R11:5c085794be29: devel/git-extras: Update to 7.4.0 (authored by igoro).
devel/git-extras: Update to 7.4.0
Jul 13 2025, 10:49 AM

Jul 12 2025

igoro added a comment to D51136: kyua: Make "test" command actually report about workdir cleanup issues.

What was the behavior prior to this change?

Jul 12 2025, 5:42 PM

Jul 9 2025

igoro accepted D51229: kyua: Try harder to delete directories..

LGTM. And I had a successful testing on my side.

Jul 9 2025, 8:26 PM

Jul 2 2025

igoro added reviewers for D51136: kyua: Make "test" command actually report about workdir cleanup issues: ngie, tests.
Jul 2 2025, 9:56 PM
igoro requested review of D51136: kyua: Make "test" command actually report about workdir cleanup issues.
Jul 2 2025, 9:56 PM
igoro accepted D51034: atf: atf-check: stop using a sentinel to convey 'empty' status checks.

LGTM

Jul 2 2025, 4:31 PM
igoro added a comment to D51035: atf: libatf-c: widen our process status capabilities.

Please submit this upstream. We need to work through the porting issues with Linux/MacOS in order to land this to avoid having multiple different forks/mutations of this (ATF) code.

Jul 2 2025, 4:24 PM
igoro accepted D51035: atf: libatf-c: widen our process status capabilities.

LGTM

Jul 2 2025, 4:12 PM

Jun 8 2025

igoro accepted D50734: atf-c(3): fill in prototypes for functions.
Jun 8 2025, 11:34 AM

May 24 2025

igoro accepted D50499: kyua: increase cleanup_timeout to 300s.
May 24 2025, 11:28 AM

May 23 2025

igoro added a comment to D50476: tests/sys/net: run if_bridge_test in a jail.

The combinatorics seems to be as follows:

May 23 2025, 9:08 PM

May 17 2025

igoro committed rG6b8222793fbb: kyua: Add "kyua debug -p" option (authored by igoro).
kyua: Add "kyua debug -p" option
May 17 2025, 9:33 AM
igoro closed D49463: kyua: Add "kyua debug -p" option.
May 17 2025, 9:33 AM
igoro added inline comments to D49463: kyua: Add "kyua debug -p" option.
May 17 2025, 9:28 AM

May 11 2025

igoro added inline comments to D49463: kyua: Add "kyua debug -p" option.
May 11 2025, 4:57 PM
igoro updated the diff for D49463: kyua: Add "kyua debug -p" option.

Improve the man page wording

May 11 2025, 4:56 PM

May 10 2025

igoro accepted D50267: atf: Don't be deterred by weird umasks..

It looks fine that atf-check wants to verify that its temporary dir has enough access rights as it needs to store output files beneath. Why does it add so many code to handle it explicitly? Probably, a usual noperm file system error does not propagate nicely and leaves a test result reader guessing about the actual root cause. Why doesn't it "escape" the current umask instead (as this patch proposes)? Maybe, there was another reason to obey the current umask when ATF was just a separate project before Kyua introduction and it was invoked directly. I do not see answers in the code parts I've read.

May 10 2025, 11:47 PM
igoro added a comment to D49463: kyua: Add "kyua debug -p" option.

This feature can be refined, but I don’t want to get in the way of the utility of this change for folks like @kp, who need the debuggability. Let’s go forward with this change and refine things/sand down rough edges on GitHub.

May 10 2025, 8:06 PM
igoro added inline comments to D49463: kyua: Add "kyua debug -p" option.
May 10 2025, 7:39 PM
igoro updated the diff for D49463: kyua: Add "kyua debug -p" option.

Fix the man page format

May 10 2025, 7:38 PM
igoro added inline comments to D49463: kyua: Add "kyua debug -p" option.
May 10 2025, 6:20 PM
igoro added inline comments to D49463: kyua: Add "kyua debug -p" option.
May 10 2025, 6:18 PM

Apr 21 2025

igoro committed rGe64978ad5d7c: tests.7: Bump the date and improve the format (authored by igoro).
tests.7: Bump the date and improve the format
Apr 21 2025, 6:53 PM
igoro closed D49798: tests.7: Bump the date and improve the format.
Apr 21 2025, 6:53 PM

Apr 16 2025

igoro added a comment to D49788: lutok: Switch from std::auto_ptr<> to std::unique_ptr<>.

I remember ngie@ agreed in some past cases to go directly to the src while the expected vendor path could go in parallel at its own pace. The vendor branch seems to be non-updated since its import back in 2020, so the vendor path may face obstacles and could take time. I mention this just in case if there is a need to hit src sooner, so that an exception agreement could be considered.

Apr 16 2025, 9:13 AM
igoro accepted D49788: lutok: Switch from std::auto_ptr<> to std::unique_ptr<>.
Apr 16 2025, 8:58 AM

Apr 13 2025

igoro added a comment to D49798: tests.7: Bump the date and improve the format.

for format/typo changes, I don't bump the date.

Sorry for the oversight, this is correct. We should not bump the date here.

Apr 13 2025, 4:56 PM

Apr 12 2025

igoro requested review of D49798: tests.7: Bump the date and improve the format.
Apr 12 2025, 11:47 AM

Apr 8 2025

igoro closed D49586: Status/2025Q1/jailmeta.adoc: Add report.
Apr 8 2025, 12:02 PM
igoro committed R9:13aa8b9d6db4: Status/2025Q1/jailmeta.adoc: Add report (authored by igoro).
Status/2025Q1/jailmeta.adoc: Add report
Apr 8 2025, 12:02 PM

Apr 5 2025

igoro added a comment to D49586: Status/2025Q1/jailmeta.adoc: Add report.

Many thanks for review! It was a rush to meet the deadline, and there weren't enough rounds of self-check.

Apr 5 2025, 10:34 AM
igoro updated the diff for D49586: Status/2025Q1/jailmeta.adoc: Add report.

Fix format and style

Apr 5 2025, 10:28 AM
igoro retitled D49586: Status/2025Q1/jailmeta.adoc: Add report from Status/2025Q1: Add jailmeta report to Status/2025Q1/jailmeta.adoc: Add report.
Apr 5 2025, 10:28 AM

Apr 2 2025

igoro accepted D49633: tests: Require allow_network_access for tests needing name resolution.

It seems that as a temporary solution it is good to have them explicitly "tagged" to easily find the ones which need revising to avoid external dependencies.

Apr 2 2025, 2:28 PM

Apr 1 2025

igoro added a comment to D49594: tests.7: Announce allow_network_access test suite conf variable.

I am happy to see allow_network_access feature has been added to the test framework. I believe it would be useful in some cases that network access is mandatory. However, in the case of DNS resolving, I suggest we just using the built-in local unbound for a simple local resolver to serve the test needs.

Apr 1 2025, 10:00 PM
igoro added a comment to D49594: tests.7: Announce allow_network_access test suite conf variable.

Sorry for being late to this (well, the window is quite short and I have been busy with other things recently...)

While ideally tests should not depend on external things as much as possible to have more reproducible nature, some of them may require to reach external resources, let's say to fetch something or to talk to the world services like DNS, etc.

Indeed and that's also why I am still hesitated to enable internet access on the jails in builder (when doing builds with the patches come from external) and when running the tests in VM. It's not only the security reason but also the matter of tests stability and reliability.

Apr 1 2025, 9:50 PM
igoro committed rGea1e4a7dd9bc: tests.7: Announce allow_network_access test suite conf variable (authored by igoro).
tests.7: Announce allow_network_access test suite conf variable
Apr 1 2025, 5:10 PM
igoro closed D49594: tests.7: Announce allow_network_access test suite conf variable.
Apr 1 2025, 5:10 PM

Mar 31 2025

igoro added a comment to D49594: tests.7: Announce allow_network_access test suite conf variable.

We can do it later, but if you mark these variables up as It Va instead of It, they become searchable; e.g. apropos Va=allow_network.

Mar 31 2025, 9:18 PM
igoro added a reviewer for D49594: tests.7: Announce allow_network_access test suite conf variable: tests.
Mar 31 2025, 8:17 PM
igoro added a comment to D49594: tests.7: Announce allow_network_access test suite conf variable.

While ideally tests should not depend on external things as much as possible to have more reproducible nature, some of them may require to reach external resources, let's say to fetch something or to talk to the world services like DNS, etc.

Mar 31 2025, 8:17 PM
igoro requested review of D49594: tests.7: Announce allow_network_access test suite conf variable.
Mar 31 2025, 8:03 PM
igoro updated the diff for D49586: Status/2025Q1/jailmeta.adoc: Add report.

Add dch as a point of contact

Mar 31 2025, 9:53 AM
igoro requested review of D49586: Status/2025Q1/jailmeta.adoc: Add report.
Mar 31 2025, 9:48 AM
igoro closed D47668: jail: Add meta and env parameters.
Mar 31 2025, 9:20 AM
igoro committed rG30e6e008bc06: jail: Add meta and env parameters (authored by igoro).
jail: Add meta and env parameters
Mar 31 2025, 9:20 AM
igoro added a comment to D47668: jail: Add meta and env parameters.

Thank you, it was an interesting journey.

Mar 31 2025, 9:08 AM

Mar 30 2025

igoro added a comment to D47668: jail: Add meta and env parameters.

I'm not sure what the point of the soft/hard size limits is. I imagine I could find it in the code, but could you explain it to me? Something more than the one comment about it, but less detail than the code itself :-).

Mar 30 2025, 8:36 PM
igoro added a comment to D47668: jail: Add meta and env parameters.

I don't disagree that the way the character set is limited is efficient and doesn't add much to the code base. It's just the entire direction that I don't like. There are many places where sloppy text interpretation can cause problems. Environment variables come to mind - they too are passed between processes in the kernel. But user-level string injection has never been considered a kernel problem, and I don't see why it should start now. That's just not the kernel's job.

I you want to continue to push for this, I would suggest separating it from the main feature, adding another revision just for that. I like the general meta/env feature, but you'll just have to look elsewhere for buy-in to that one part.

Mar 30 2025, 7:45 PM
igoro updated the diff for D47668: jail: Add meta and env parameters.

Remove meta_allowedchars mechanism

Mar 30 2025, 7:37 PM

Mar 29 2025

igoro added a comment to D47668: jail: Add meta and env parameters.

Thanks for the confirmation.

Mar 29 2025, 1:23 AM

Mar 24 2025

igoro added a comment to D49463: kyua: Add "kyua debug -p" option.
  • Could you please verify that this doesn't regress Linux/MacOS?
Mar 24 2025, 10:46 PM
igoro updated the diff for D49463: kyua: Add "kyua debug -p" option.

Polish and apply the suggestions

Mar 24 2025, 10:24 PM
igoro added a comment to D49463: kyua: Add "kyua debug -p" option.

Well, it was a quick one hour patch, now it's time for polishing.

Mar 24 2025, 10:23 PM

Mar 23 2025

igoro added a comment to D49463: kyua: Add "kyua debug -p" option.

Whoa, nice. :)

What happens if tests are running in parallel? The behaviour I would naively expect is that other running tests will keep going, but new ones will not be scheduled until kyua is resumed.

Mar 23 2025, 11:19 PM
igoro updated the diff for D49463: kyua: Add "kyua debug -p" option.

Report test work dir

Mar 23 2025, 11:08 PM
igoro requested review of D49463: kyua: Add "kyua debug -p" option.
Mar 23 2025, 6:42 PM

Mar 16 2025

igoro committed rG40a8746a775c: kyua: Pass unprivileged user config prop to ATF using all known names (authored by igoro).
kyua: Pass unprivileged user config prop to ATF using all known names
Mar 16 2025, 10:57 AM

Mar 10 2025

igoro accepted D49277: net-mgmt/simplomon: NEW PORT - radically simple availability monitoring.

LGTM

Mar 10 2025, 10:47 AM

Mar 4 2025

igoro committed rG9383629ffc92: kyua: Support require.diskspace ATF metadata (authored by igoro).
kyua: Support require.diskspace ATF metadata
Mar 4 2025, 10:06 PM

Mar 2 2025

igoro added a comment to D48087: kyua: Add "prepare" command.

Could requires be used instead of the term prepare? I think that would align the concept and the command more with what is being reported on.

Mar 2 2025, 8:03 PM
igoro added a comment to D47668: jail: Add meta and env parameters.

I'm glad that turned out to be a workable option - thanks for adding it.

As to your comment that return an empty value for a nonexistent key instead of stopping the whole thing up with ENOENT, I see your point. But now I see another way: the NULL value, this time in the other direction. From the kernel interface side, it would be just the same as the setting direction, where receiving a NULL indicated attempted retrieval of a nonexistent key, while an empty string would only be for a key with an empty value.

It gets trickier on the user end though, where jls(8) only sometimes allows for a distinction. In particular, "jls -n meta.foo" or "jls -s meta.foo" could be made to show the same distinction between meta.foo="" and just meta.foo, but without the option there would be no way to tell. That's probably sufficient for those who care, though.

Mar 2 2025, 4:50 PM
igoro updated the diff for D47668: jail: Add meta and env parameters.

Communicate back a missing key

Mar 2 2025, 4:35 PM

Feb 27 2025

igoro committed rGdb06c8fd7f5b: kyuafile.5: ATF metadata mapping reference (authored by igoro).
kyuafile.5: ATF metadata mapping reference
Feb 27 2025, 9:49 PM

Feb 23 2025

igoro closed D49039: kyua: Pass unprivileged user config prop to ATF using all known names.
Feb 23 2025, 10:50 AM
igoro committed rG51a8eb641046: kyua: Pass unprivileged user config prop to ATF using all known names (authored by igoro).
kyua: Pass unprivileged user config prop to ATF using all known names
Feb 23 2025, 10:49 AM

Feb 22 2025

igoro updated the summary of D47668: jail: Add meta and env parameters.
Feb 22 2025, 6:32 PM
igoro added a comment to D47668: jail: Add meta and env parameters.

A few observations from actually running this:

Feb 22 2025, 6:30 PM
igoro updated the diff for D47668: jail: Add meta and env parameters.

Add key removal mechanism using NULL value as a trigger

Feb 22 2025, 5:21 PM

Feb 18 2025

igoro updated the diff for D49039: kyua: Pass unprivileged user config prop to ATF using all known names.

Add the respective code comment

Feb 18 2025, 11:22 PM
igoro added a comment to D49039: kyua: Pass unprivileged user config prop to ATF using all known names.

LGTM. Except that the commit message contains a typo: "uprivileged_user" => "unprivileged_user"

Feb 18 2025, 11:21 PM

Feb 17 2025

igoro added a comment to D49039: kyua: Pass unprivileged user config prop to ATF using all known names.

I guess it could be helpful for a couple of test cases from tests/sys/netinet/fibs_multibind_test.c and/or tests/sys/netinet/socket_afinet.c.

Feb 17 2025, 11:25 PM
igoro added a reviewer for D49039: kyua: Pass unprivileged user config prop to ATF using all known names: tests.
Feb 17 2025, 11:23 PM