Page MenuHomeFreeBSD

guest-jsollvander (Johan Söllvander)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2022, 7:39 AM (162 w, 4 d)

Recent Activity

Sun, Oct 19

guest-jsollvander added a comment to D53180: geom: fix glabel status after 0d4642a.

We should add the same check to status_one_geom() as well

Sun, Oct 19, 2:36 PM

Thu, Oct 16

guest-jsollvander added a reviewer for D53110: Fix failing multipath test caused by D37615: phil.
Thu, Oct 16, 8:10 AM
guest-jsollvander added a comment to D53110: Fix failing multipath test caused by D37615.

Would it be worth addressing these suggestions here as well?:
https://lists.freebsd.org/archives/dev-commits-src-main/2025-October/036657.html

Thu, Oct 16, 7:56 AM

Wed, Oct 15

guest-jsollvander added a comment to D53110: Fix failing multipath test caused by D37615.

Yes. I took a json sample before and after applying the patch locally and it looks ok. No extra ".".

Wed, Oct 15, 9:09 AM
guest-jsollvander requested review of D53110: Fix failing multipath test caused by D37615.
Wed, Oct 15, 8:55 AM
guest-jsollvander added a comment to D37615: geom <class> list/status --libxo support.

This patch seems to break several testcases in the sys/geom/class/multipath/misc test suite with this output:

===> sys/geom/class/multipath/misc:add
Result:     failed: ACTIVE !=  (ACTIVE != )

I'll take a look.

If you can come up with a fix in the next 24 hours, I will wait to apply it. If you cannot do it in that time frame, let me know, and I will revert the commit until you can sort it out.

Wed, Oct 15, 8:38 AM

Tue, Oct 14

guest-jsollvander added a comment to D37615: geom <class> list/status --libxo support.

This patch seems to break several testcases in the sys/geom/class/multipath/misc test suite with this output:

===> sys/geom/class/multipath/misc:add
Result:     failed: ACTIVE !=  (ACTIVE != )
Tue, Oct 14, 1:12 PM

May 30 2025

guest-jsollvander added a comment to D42150: bsdinstall: when installing UEFI, place the bootloader on all disks.

AFAIK this is still a problem

May 30 2025, 3:39 PM

Nov 1 2024

guest-jsollvander added a comment to D42150: bsdinstall: when installing UEFI, place the bootloader on all disks.

Sorry to bother people, but could we revive this review? I was recently talking to some people who noticed this the hard way and it would be great to get something merged that fixes it, even if it isn't perfect. I think this looks good enough and is definitely not "the ugliest kludge to make this work"

Nov 1 2024, 8:00 AM

Oct 18 2023

guest-jsollvander added a comment to D42150: bsdinstall: when installing UEFI, place the bootloader on all disks.

I see that bootconfig used to have code for adding ESPs to all ZFS/UFS boot disks, but it was removed in https://reviews.freebsd.org/D28897. @imp reviewed that one, maybe you could share your opinion here if we should bring parts of that code back? I think all disks that are configured as boot disks by the installer should a working ESP after installation. If the wrong boot disks die then you are left with a system without any ESPs at all.

Oct 18 2023, 1:34 PM

Dec 14 2022

guest-jsollvander added a comment to D37309: gmultipath: new command "gmultipath which".

Bump

Dec 14 2022, 5:45 PM

Dec 12 2022

guest-jsollvander updated the diff for D37615: geom <class> list/status --libxo support.

Updated diff to include context

Dec 12 2022, 8:28 AM

Dec 6 2022

guest-jsollvander requested review of D37615: geom <class> list/status --libxo support.
Dec 6 2022, 5:39 PM

Nov 10 2022

guest-jsollvander added a comment to D37309: gmultipath: new command "gmultipath which".

So I experimented a little and remade this as "geom -c <consumer>". But unless I figure out a good way to filter by class it is useless. Right now it will just pick whatever class the provider first appears in, like DEV. So the proper way, IMO, to do that would be "geom <class> which <consumer>" and not just add another flag. But then "which" would only exist when using "geom" directly and not when using "gmultipath"/"gpart"/"glabel" binaries which I think would look weird. What are your thoughts?

Nov 10 2022, 4:18 PM

Nov 9 2022

guest-jsollvander added a comment to D37309: gmultipath: new command "gmultipath which".
In D37309#847728, @mav wrote:

Not that I have specific objections against this, but I think it would be much better to implement a generic way to print all consumers connected to specified GEOM provider. This code does not look anyhow specific to gmultipath.

Nov 9 2022, 10:12 AM

Nov 8 2022

guest-jsollvander requested review of D37309: gmultipath: new command "gmultipath which".
Nov 8 2022, 5:20 PM

Oct 21 2022

emaste renamed guest-jsollvander from jsollvander_axcient.com to guest-jsollvander.
Oct 21 2022, 4:18 PM