Page MenuHomeFreeBSD

geom: fix glabel status after 0d4642a
Needs ReviewPublic

Authored by brd on Sat, Oct 18, 12:34 AM.
Tags
None
Referenced Files
F132775037: D53180.diff
Sun, Oct 19, 8:49 PM
Unknown Object (File)
Sat, Oct 18, 9:00 AM
Unknown Object (File)
Sat, Oct 18, 8:57 AM
Unknown Object (File)
Sat, Oct 18, 6:38 AM
Unknown Object (File)
Sat, Oct 18, 4:20 AM
Unknown Object (File)
Sat, Oct 18, 3:33 AM
Unknown Object (File)
Sat, Oct 18, 3:32 AM
Unknown Object (File)
Sat, Oct 18, 3:27 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67918
Build 64801: arc lint + arc unit

Event Timeline

brd requested review of this revision.Sat, Oct 18, 12:34 AM

before:

          Name  Status  Components
  gpt/efiboot0     N/A  N/A
msdosfs/EFISYS     N/A  N/A
  gpt/gptboot0     N/A  N/A
  gpt/efiboot1     N/A  N/A
  gpt/gptboot1     N/A  N/A

after:

          Name  Status  Components
  gpt/efiboot0     N/A  nda0p1
msdosfs/EFISYS     N/A  nda0p1
  gpt/gptboot0     N/A  nda0p2
  gpt/efiboot1     N/A  nda1p1
  gpt/gptboot1     N/A  nda1p2

Fix check if the provider is NULL

This looks good to me, but I will await a review from Johan before proceeding.

We should add the same check to status_one_geom() as well

Update status_one_geom() too

We should add the same check to status_one_geom() as well

OK, added.. Do you know which command would call through this function to verify this?

In D53180#1215263, @brd wrote:

We should add the same check to status_one_geom() as well

OK, added.. Do you know which command would call through this function to verify this?

Aha, geom label status -g.. OK, yes this fixes that as well.

markj added inline comments.
sbin/geom/core/geom.c
1219

There is also a typo here and above, compontent->component.

Please be sure to include 0d4642a as Fixes metadata so that it's clear they need to go together both for MFCs and downstreams that might be consuming main.

sbin/geom/core/geom.c
1196–1197

Might as well move this up prior to checking the status? Obviously they'll both return NULL anyways, but it seems more clear then that they won't be mutating state.

1265

Ditto here

brd marked 2 inline comments as done.

Address feedback from kevans

brd marked an inline comment as not done.Sun, Oct 19, 4:36 PM
brd added inline comments.
sbin/geom/core/geom.c
1196–1197

I was wondering about that myself.. Thanks!

1219

Should I do all of them in one commit? There are 10..

Fix typos as well since they are part of the original commit.

brd marked an inline comment as done.Sun, Oct 19, 5:43 PM