Details
Details
- Reviewers
mckusick guest-jsollvander
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 67918 Build 64801: arc lint + arc unit
Event Timeline
Comment Actions
before:
Name Status Components gpt/efiboot0 N/A N/A msdosfs/EFISYS N/A N/A gpt/gptboot0 N/A N/A gpt/efiboot1 N/A N/A gpt/gptboot1 N/A N/A
after:
Name Status Components gpt/efiboot0 N/A nda0p1 msdosfs/EFISYS N/A nda0p1 gpt/gptboot0 N/A nda0p2 gpt/efiboot1 N/A nda1p1 gpt/gptboot1 N/A nda1p2
Comment Actions
OK, added.. Do you know which command would call through this function to verify this?
sbin/geom/core/geom.c | ||
---|---|---|
1219 | There is also a typo here and above, compontent->component. |
Comment Actions
Please be sure to include 0d4642a as Fixes metadata so that it's clear they need to go together both for MFCs and downstreams that might be consuming main.
sbin/geom/core/geom.c | ||
---|---|---|
1196–1197 | Might as well move this up prior to checking the status? Obviously they'll both return NULL anyways, but it seems more clear then that they won't be mutating state. | |
1265 | Ditto here |