Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects

User Details

User Since
Jul 2 2021, 4:03 PM (223 w, 2 d)

Recent Activity

Sat, Oct 11

christos added a comment to D53029: Add kqueue(9) support to sound(4).

All the comments in dsp_read_filter() apply to dsp_write_filter() as well.

Sat, Oct 11, 1:29 PM

Fri, Oct 10

christos committed rG2a6c17544e00: virtual_oss: Clean up rcorder (authored by christos).
virtual_oss: Clean up rcorder
Fri, Oct 10, 9:24 PM
christos closed D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 8:33 PM
christos committed R11:47a060bc66e9: audio/sndio: Add virtual_oss to rcorder (authored by christos).
audio/sndio: Add virtual_oss to rcorder
Fri, Oct 10, 8:33 PM
christos added a comment to D53020: audio/sndio: Add virtual_oss to rcorder.

@arrowd Is it ready?

Fri, Oct 10, 3:43 PM
christos committed rG188ddc15e546: virtual_oss: Clean up rcorder (authored by christos).
virtual_oss: Clean up rcorder
Fri, Oct 10, 1:08 PM
christos closed D53019: virtual_oss: Clean up rcorder.
Fri, Oct 10, 1:07 PM
christos added inline comments to D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 1:00 PM
christos added a comment to D53019: virtual_oss: Clean up rcorder.

The short MFC time is so that it can land in BETA1.

Fri, Oct 10, 12:58 PM
christos added a comment to D53020: audio/sndio: Add virtual_oss to rcorder.

Doesn't virtual_oss rc script already contain BEFORE: sndiod? This forms a cycle.

Fri, Oct 10, 12:56 PM
christos updated the diff for D53019: virtual_oss: Clean up rcorder.

Address des@ comments.

Fri, Oct 10, 12:56 PM
christos retitled D53019: virtual_oss: Clean up rcorder from virtual_oss: Do not reference sndiod in rcorder to virtual_oss: Clean up rcorder.
Fri, Oct 10, 12:55 PM
christos added a comment to D53019: virtual_oss: Clean up rcorder.
In D53019#1211342, @des wrote:

The correct way to express that you need the network to be up is REQUIRE: NETWORKING.

Fri, Oct 10, 12:39 PM
christos added a comment to D53019: virtual_oss: Clean up rcorder.
In D53019#1211338, @des wrote:

While here, require DAEMON as well.

Why?

Fri, Oct 10, 12:22 PM
christos added a reviewer for D53020: audio/sndio: Add virtual_oss to rcorder: 0mp.
Fri, Oct 10, 11:57 AM
christos requested review of D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 11:56 AM
christos requested review of D53019: virtual_oss: Clean up rcorder.
Fri, Oct 10, 11:53 AM
christos accepted D53015: virtual_oss: Move plugins to the sound package.
Fri, Oct 10, 11:30 AM

Wed, Oct 8

christos committed rG44114a581fba: libsamplerate: Define as PRIVATELIB (authored by christos).
libsamplerate: Define as PRIVATELIB
Wed, Oct 8, 12:55 PM

Thu, Oct 2

christos closed D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Thu, Oct 2, 7:38 AM
christos committed R11:05b748dac1da: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066 (authored by christos).
audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066
Thu, Oct 2, 7:38 AM
christos committed rG57327328f141: snd_hda: Implement automatic redirection between associations (authored by christos).
snd_hda: Implement automatic redirection between associations
Thu, Oct 2, 7:33 AM
christos committed rG1cde8b0a257a: mixer(8): Update virtual_oss path (authored by christos).
mixer(8): Update virtual_oss path
Thu, Oct 2, 7:32 AM
christos committed rG5a31c623143f: virtual_oss: Port to base (authored by christos).
virtual_oss: Port to base
Thu, Oct 2, 7:32 AM

Wed, Oct 1

christos added a comment to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.

Perfect. :-)

Wed, Oct 1, 2:53 PM
christos added a comment to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.

Builds fine on CURRENT and 13.5

Wed, Oct 1, 2:46 PM
christos accepted D52823: packages: Add a sound package.

Approved by the committee.

Wed, Oct 1, 11:47 AM
christos updated the diff for D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.

Use proper __FreeBSD_version value. I have the stable/15 MFC ready for
commit, with __FreeBSD_version bumped to 1500066.

Wed, Oct 1, 11:36 AM
christos retitled D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066 from audio/virtual_oss_ctl: Do not depend on audio/virtual_oss on >= FreeBSD 15.0 to audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Wed, Oct 1, 11:35 AM
christos added inline comments to D52823: packages: Add a sound package.
Wed, Oct 1, 10:26 AM
christos committed rG5cc36854ee63: devd: Remove SND package (authored by christos).
devd: Remove SND package
Wed, Oct 1, 8:25 AM

Tue, Sep 30

christos committed rGf040ee6e4078: virtual_oss: Do not build if WITHOUT_CUSE is set (authored by christos).
virtual_oss: Do not build if WITHOUT_CUSE is set
Tue, Sep 30, 5:02 PM
christos closed D52807: virtual_oss: Do not build if WITHOUT_CUSE is set.
Tue, Sep 30, 5:02 PM
christos updated the summary of D52807: virtual_oss: Do not build if WITHOUT_CUSE is set.
Tue, Sep 30, 4:57 PM
christos added a comment to D52807: virtual_oss: Do not build if WITHOUT_CUSE is set.

I would like to land this today.

Tue, Sep 30, 4:55 PM
christos requested review of D52807: virtual_oss: Do not build if WITHOUT_CUSE is set.
Tue, Sep 30, 4:55 PM
christos added a comment to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.

LGTM, but I did not test this in Poudriere. @christos let me know if you want me to do it.

Tue, Sep 30, 4:29 PM
christos closed D52426: audio/virtual_oss_bluetooth: New port.
Tue, Sep 30, 3:41 PM
christos committed R11:2dcc66e8c6c4: audio/virtual_oss_bluetooth: New port (authored by christos).
audio/virtual_oss_bluetooth: New port
Tue, Sep 30, 3:41 PM
christos closed D52367: audio/virtual_oss: Ignore FreeBSD 15.
Tue, Sep 30, 3:41 PM
christos committed R11:9b26d309123a: audio/virtual_oss: Ignore FreeBSD 15 (authored by christos).
audio/virtual_oss: Ignore FreeBSD 15
Tue, Sep 30, 3:41 PM
christos closed D52366: audio/virtual_oss_equalizer: New port.
Tue, Sep 30, 3:41 PM
christos committed R11:35215c174c45: audio/virtual_oss_equalizer: New port (authored by christos).
audio/virtual_oss_equalizer: New port
Tue, Sep 30, 3:41 PM
christos closed D52365: audio/virtual_oss_sndio: New port.
Tue, Sep 30, 3:40 PM
christos committed R11:a9bbba1949a7: audio/virtual_oss_sndio: New port (authored by christos).
audio/virtual_oss_sndio: New port
Tue, Sep 30, 3:40 PM
christos added a comment to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.

I will bump stable/15's __FreeBSD_version once I MFC virtual_oss to stable/15 in the next days, and will update the port here accordingly.

Tue, Sep 30, 2:21 PM
christos added a comment to D52365: audio/virtual_oss_sndio: New port.

All right then, all three ports build fine in Poudriere.

Tue, Sep 30, 2:19 PM
christos added a comment to D52365: audio/virtual_oss_sndio: New port.

This is what we are doing already: https://cgit.freebsd.org/src/tree/usr.sbin/virtual_oss/virtual_oss/main.c#n1639

Or do you mean something else?

Yes, I mean that we can compile voss_sndio.so as part of the base build if it wouldn't need to link with libsndio.so directly. Replacing direct calls with dlsym'ed ones will untie voss_sndio.so from voss_sndio.so and all these ports would be unnecessary.

Tue, Sep 30, 2:00 PM
christos added a comment to D52365: audio/virtual_oss_sndio: New port.

I suppose if I MFC changes to releng/15.0 and stable/15 we should be safe? This way all releases will share the same code.

I don't think so. The builder might run 15.0-p0 and not getting any updates. And picking something into the releng branch isn't enough - it should go through some releng process, AFAIK.

If ABI guarantees can't be held, we should look into calling sndio via dlopen/dlsym to move the dependency to the run time.

Tue, Sep 30, 1:47 PM
christos added a comment to D52365: audio/virtual_oss_sndio: New port.

This leaves us with a requirement for the ABI compliance. @christos would it be possible to guarantee backward ABI compatibility for the OSS bits in base, so that ports compiled against 15.0 sources would work with 15.1 binaries?

Tue, Sep 30, 1:38 PM
christos committed rG8af6aee96ed6: virtual_oss(8): Remove floating point formats from preference list (authored by christos).
virtual_oss(8): Remove floating point formats from preference list
Tue, Sep 30, 1:27 PM
christos closed D52551: Status/2025Q3/audio.adoc: Add report.
Tue, Sep 30, 10:59 AM
christos committed R9:0beb2668debe: Status/2025Q3/audio.adoc: Add report (authored by christos).
Status/2025Q3/audio.adoc: Add report
Tue, Sep 30, 10:59 AM
christos committed rG2ffaca551eaf: snd_hda: Implement automatic redirection between associations (authored by christos).
snd_hda: Implement automatic redirection between associations
Tue, Sep 30, 10:53 AM
christos closed D50070: snd_hda: Implement automatic redirection between associations.
Tue, Sep 30, 10:53 AM
christos updated subscribers of D50070: snd_hda: Implement automatic redirection between associations.

I'm going to commit this today and also MFC it to stable/15 before 03.10 00:00 UTC (releng/15.0) as suggested by @cperciva, along with the virtual_oss patches. There are a few things that need addressing but I think it's not a problem to work them while in tree.

Tue, Sep 30, 10:39 AM
christos committed rGd0e8c9463126: sound: Implement COMPAT_FREEBSD32 shims (authored by damjan.jov_gmail.com).
sound: Implement COMPAT_FREEBSD32 shims
Tue, Sep 30, 9:19 AM
christos committed rGa8e11e3c6208: dtraceall: Enable kinst for aarch64 and riscv as well (authored by christos).
dtraceall: Enable kinst for aarch64 and riscv as well
Tue, Sep 30, 9:19 AM
christos committed rG782a376911eb: sound: Implement COMPAT_FREEBSD32 shims (authored by damjan.jov_gmail.com).
sound: Implement COMPAT_FREEBSD32 shims
Tue, Sep 30, 9:18 AM
christos committed rGabdd81f0a5d5: dtraceall: Enable kinst for aarch64 and riscv as well (authored by christos).
dtraceall: Enable kinst for aarch64 and riscv as well
Tue, Sep 30, 9:18 AM
christos committed rG25d551b5fb1d: virtual_bt_speaker(8): Do not build if WITHOUT_BLUETOOTH is set (authored by christos).
virtual_bt_speaker(8): Do not build if WITHOUT_BLUETOOTH is set
Tue, Sep 30, 9:14 AM

Mon, Sep 29

christos committed rG0532cd2d7713: virtual_oss(8): Fix GCC errors and warnings (authored by christos).
virtual_oss(8): Fix GCC errors and warnings
Mon, Sep 29, 4:18 PM
christos committed rG69ede18b950e: virtual_oss(8): Use proper format specifier for uintmax_t * (authored by christos).
virtual_oss(8): Use proper format specifier for uintmax_t *
Mon, Sep 29, 10:42 AM

Sun, Sep 28

christos committed rG86a7787e324b: virtual_bt_speaker(8): Fix aarch64 build (authored by christos).
virtual_bt_speaker(8): Fix aarch64 build
Sun, Sep 28, 3:41 PM
christos added a comment to D50070: snd_hda: Implement automatic redirection between associations.

15.0 is approaching, so I think we can go ahead and commit and work some of the issues I raised lately while in tree?

Sun, Sep 28, 10:14 AM
christos committed rG5c8835e5c0ce: mixer(8): Update virtual_oss path (authored by christos).
mixer(8): Update virtual_oss path
Sun, Sep 28, 10:00 AM
christos committed rGc457acb4ee82: RELNOTES: virtual_oss in base (authored by christos).
RELNOTES: virtual_oss in base
Sun, Sep 28, 10:00 AM
christos committed rG9cab9fde5eda: virtual_oss: Port to base (authored by christos).
virtual_oss: Port to base
Sun, Sep 28, 10:00 AM
christos closed D52322: mixer(8): Update virtual_oss path.
Sun, Sep 28, 9:59 AM
christos closed D52583: RELNOTES: virtual_oss in base.
Sun, Sep 28, 9:59 AM
christos closed D52308: virtual_oss: Port to base.
Sun, Sep 28, 9:59 AM
christos updated the diff for D52308: virtual_oss: Port to base.

Address Ed's comment.

Sun, Sep 28, 9:55 AM

Sat, Sep 27

christos added a comment to D52308: virtual_oss: Port to base.

If it builds fine and there are no further issues I think we can commit it.

Sat, Sep 27, 12:25 PM

Fri, Sep 26

christos updated the diff for D52308: virtual_oss: Port to base.

Address Ed's comment.

Fri, Sep 26, 10:22 PM
christos added a comment to D52308: virtual_oss: Port to base.
ld: error: unable to find library -lprivatesamplerate

Does @emaste 's suggestion in the inline comment fix this?

My comment is related to this, but I'm still getting this as well, looking..

Fri, Sep 26, 3:49 PM
christos added a comment to D52308: virtual_oss: Port to base.

I'm still getting

===> lib/virtual_oss (all)
===> lib/virtual_oss/null (all)
make[6]: /usr/obj/usr/src/amd64.amd64/lib/virtual_oss/null/.depend:1: ignoring stale .depend for /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libprivatesamplerate.a
Building shared library voss_null.so
cc -target x86_64-unknown-freebsd16.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin  -Wl,-zrelro    -fstack-protector-strong -shared -Wl,-x -Wl,--fatal-warnings -Wl,--warn-shared-textrel  -o voss_null.so.full -Wl,-soname,voss_null.so null.pico  -lprivatesamplerate 
ld: error: unable to find library -lprivatesamplerate

when trying to build this diff. It also does not apply with arc patch for me for some reason.

Fri, Sep 26, 3:24 PM
christos updated the diff for D52308: virtual_oss: Port to base.

Address commnets. Also got the script to an acceptable (better) state with the
help of Mateusz (0mp@) and shellcheck(1).

Fri, Sep 26, 3:23 PM

Tue, Sep 23

christos committed rG749a9266982b: sound: Implement COMPAT_FREEBSD32 shims (authored by damjan.jov_gmail.com).
sound: Implement COMPAT_FREEBSD32 shims
Tue, Sep 23, 7:01 PM
christos closed D52509: sound: Implement COMPAT_FREEBSD32 shims.
Tue, Sep 23, 7:00 PM
christos accepted D52509: sound: Implement COMPAT_FREEBSD32 shims.
Tue, Sep 23, 6:58 PM
christos retitled D52509: sound: Implement COMPAT_FREEBSD32 shims from sound: 32 bit compatibility to sound: Implement COMPAT_FREEBSD32 shims.
Tue, Sep 23, 6:58 PM

Mon, Sep 22

christos added a comment to D52308: virtual_oss: Port to base.

The patch is essentially finalized and IMHO ready to commit. Only thing remaining (but not really that important) are the rc script inline comments.

Also, since I'd like this to land in 15.0, I guess we'd need to bump __FreeBSD_version for stable/15, so that ports like D52593 can build only if the machine does have virtual_oss in base (related discussion there). @markj @emaste @cperciva What do you think?

Yes, go ahead with the __FreeBSD_version bump. But please get it done soon; I'll be creating releng/15.0 in 1.5 weeks and this probably can't go in after that point.

Mon, Sep 22, 9:31 PM

Sun, Sep 21

christos requested changes to D52509: sound: Implement COMPAT_FREEBSD32 shims.

I'm not sure if this compiles (see inline comment), but in any case, I will test the patch tomorrow. If you do not have a commit bit, I will also take care of it, and make sure it's MFC'd.

Sun, Sep 21, 7:54 PM

Sat, Sep 20

christos added a comment to D52509: sound: Implement COMPAT_FREEBSD32 shims.

This is just a quick draft, haven't tested that so take this with a grain of salt, but I guess something like this could work?

This corrupts memory and is a possible security exploit: zero-filling a smaller 32 bit struct with sizeof(larger 64 bit struct) zeroes, will writes zeroes beyond the end of the struct.

Sat, Sep 20, 9:43 AM

Fri, Sep 19

christos added reviewers for D52509: sound: Implement COMPAT_FREEBSD32 shims: emaste, kib.
Fri, Sep 19, 9:12 PM
christos added a comment to D52509: sound: Implement COMPAT_FREEBSD32 shims.

This is just a quick draft, haven't tested that so take this with a grain of salt, but I guess something like this could work?

Fri, Sep 19, 8:13 PM
christos added a comment to D52365: audio/virtual_oss_sndio: New port.

Sorry, ENOTIME. I will try to go over all the oss stuff this Sunday.

Fri, Sep 19, 3:33 PM
christos updated subscribers of D52308: virtual_oss: Port to base.

The patch is essentially finalized and IMHO ready to commit. Only thing remaining (but not really that important) are the rc script inline comments.

Fri, Sep 19, 1:02 PM

Thu, Sep 18

christos added inline comments to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Thu, Sep 18, 10:03 AM
christos committed rGe4fcd203f252: ng_btsocket_rfcomm: Mark a couple buffers as const in a helper function (authored by markj).
ng_btsocket_rfcomm: Mark a couple buffers as const in a helper function
Thu, Sep 18, 10:00 AM
christos committed rGeabd561d3a2a: sdp(3): Change bdaddr parameter type in sdp_register_service() (authored by christos).
sdp(3): Change bdaddr parameter type in sdp_register_service()
Thu, Sep 18, 9:59 AM
christos committed rG064006b78c90: ng_hci: Cast NG_HCI_BDADDR_ANY to const bdaddr_t * (authored by christos).
ng_hci: Cast NG_HCI_BDADDR_ANY to const bdaddr_t *
Thu, Sep 18, 9:59 AM
christos committed rG3ed893431075: ng_btsocket_rfcomm: Mark a couple buffers as const in a helper function (authored by markj).
ng_btsocket_rfcomm: Mark a couple buffers as const in a helper function
Thu, Sep 18, 9:59 AM
christos committed rG3501e2597e9e: sdp(3): Change bdaddr parameter type in sdp_register_service() (authored by christos).
sdp(3): Change bdaddr parameter type in sdp_register_service()
Thu, Sep 18, 9:58 AM
christos committed rG8813774cebc9: ng_hci: Cast NG_HCI_BDADDR_ANY to const bdaddr_t * (authored by christos).
ng_hci: Cast NG_HCI_BDADDR_ANY to const bdaddr_t *
Thu, Sep 18, 9:58 AM

Wed, Sep 17

christos added inline comments to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Wed, Sep 17, 7:51 PM
christos added inline comments to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Wed, Sep 17, 3:15 PM
christos added inline comments to D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Wed, Sep 17, 3:14 PM
christos requested review of D52593: audio/virtual_oss_ctl: Do not depend on audio/virtual_oss after 1500066.
Wed, Sep 17, 3:13 PM
christos added a comment to D52582: sdp(3): Change bdaddr parameter type in sdp_register_service().

The 1 day MFC is so that it coincides with the previous recent bluetooth fixes' MFC dates.

Wed, Sep 17, 2:13 PM