virtual_oss: Exit main loop cleanly on termination
ClosedPublic
Actions

Authored by christos on May 23 2025, 5:14 PM.

Details

Reviewers

adrian
emaste
markj

Summary

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

christos requested review of this revision.May 23 2025, 5:14 PM

christos created this revision.

christos added a child revision: D50493: virtual_oss: Clean up cuse on exit.

Rename signal handler to virtual_sig_exit().

It's quite hard to review this without context lines. Did you import virtual_oss into src, or?

virtual_main.c
1632	Better to use `sig_atomic_t` instead of `int`.

In D50492#1153167, @markj wrote:

It's quite hard to review this without context lines. Did you import virtual_oss into src, or?

I didn't. I just posted the diffs here manually without choosing a repo, but I forgot you need to generate them with git diff -U999999, so I just generated them with git format-patch.

virtual_main.c
1632	I only chose `int` to avoid including `signal.h` in the header file. But I see that `sig_atomic_t` is defined as either `int` or `long`.

Full diff.

markj added inline comments.May 25 2025, 5:37 PM

virtual_main.c
1632	What's wrong with including signal.h in an internal header file?

Define voss_exit as sig_atomic_t.

markj accepted this revision.May 27 2025, 1:01 PM

This revision is now accepted and ready to land.May 27 2025, 1:01 PM

christos retitled this revision from virtual_oss: Exit main looop cleanly on termination to virtual_oss: Exit main loop cleanly on termination.May 28 2025, 3:36 PM

Committed: https://github.com/freebsd/virtual_oss/commit/7b833e492e6ab1f112c0f5a88a3c767abc391485