Page MenuHomeFreeBSD

sndctl(8): Allow read-only sysctls
ClosedPublic

Authored by christos on May 17 2025, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:00 PM
Unknown Object (File)
Thu, Oct 9, 11:54 AM
Unknown Object (File)
Tue, Oct 7, 6:24 AM
Unknown Object (File)
Tue, Oct 7, 12:07 AM
Unknown Object (File)
Mon, Oct 6, 2:38 AM
Unknown Object (File)
Wed, Sep 24, 12:11 AM
Unknown Object (File)
Fri, Sep 19, 9:30 PM
Unknown Object (File)
Thu, Sep 18, 8:28 PM
Subscribers

Details

Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/sndctl/sndctl.c
676

For such simple code, it's IMO better to just use an if-statement:

if (arg != NULL) {
    n = strtol(...)
    ...
}
679

For this to work correctly, you need to set errno = 0 before the strtol() call.

christos marked 2 inline comments as done.

Address Mark's comments.

This revision is now accepted and ready to land.May 18 2025, 6:24 PM
This revision was automatically updated to reflect the committed changes.