Page MenuHomeFreeBSD

sndctl(8): Allow read-only sysctls
ClosedPublic

Authored by christos on May 17 2025, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 7:53 AM
Unknown Object (File)
Thu, Jan 15, 11:27 PM
Unknown Object (File)
Thu, Jan 15, 10:22 PM
Unknown Object (File)
Thu, Jan 15, 5:27 PM
Unknown Object (File)
Nov 30 2025, 2:50 AM
Unknown Object (File)
Nov 27 2025, 5:00 AM
Unknown Object (File)
Nov 10 2025, 3:07 AM
Unknown Object (File)
Nov 1 2025, 10:45 PM
Subscribers

Details

Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/sndctl/sndctl.c
676

For such simple code, it's IMO better to just use an if-statement:

if (arg != NULL) {
    n = strtol(...)
    ...
}
679

For this to work correctly, you need to set errno = 0 before the strtol() call.

christos marked 2 inline comments as done.

Address Mark's comments.

This revision is now accepted and ready to land.May 18 2025, 6:24 PM
This revision was automatically updated to reflect the committed changes.