Page MenuHomeFreeBSD

bnovkov (Bojan Novković)
User

Projects

User Details

User Since
Jan 29 2022, 5:50 PM (193 w, 4 d)

Recent Activity

Tue, Oct 14

bnovkov added a comment to D27220: libuvmem: usermode port of vmem(9).
In D27220#1212532, @kib wrote:

Hi, is there a concrete reason why this revision never landed or has it just slipped through the cracks?

I would really like to use libuvmem for one of my ongoing bhyve projects and would like to see this land, let me know if there a way I could help with that.

The intent of the libuvmem port was to use vmem allocator for bhyve to handle physical address space. That stalled, and I do not see a reason to add unused library to base.

Tue, Oct 14, 5:45 PM

Mon, Oct 13

bnovkov added a comment to D27220: libuvmem: usermode port of vmem(9).

Hi, is there a concrete reason why this revision never landed or has it just slipped through the cracks?

Mon, Oct 13, 5:39 PM

Sep 11 2025

bnovkov updated the test plan for D52491: pt: Switch to swi(9).
Sep 11 2025, 5:09 PM
bnovkov requested review of D52491: pt: Switch to swi(9).
Sep 11 2025, 5:08 PM

Sep 10 2025

bnovkov accepted D52441: uma_core: Rely on domainset iterator to wait on M_WAITOK.

LGTM overall (aside from the race issues that you'll handle in a separate PR).
I tested the changes with stress2 in a NUMA VM for a couple of hours and didn't run into any obvious issues.

Sep 10 2025, 5:04 PM

Sep 9 2025

bnovkov added inline comments to D52387: release: Add variables for makefs and mkimg arguments.
Sep 9 2025, 10:18 AM
bnovkov accepted D52388: release: Set default timestamps for makefs and mkimg outputs.
Sep 9 2025, 10:04 AM

Aug 28 2025

bnovkov abandoned D52201: db/hash_page.c: Reswap memory buffer in __put_page when dealing with a different byte order.
Aug 28 2025, 1:21 PM
bnovkov requested review of D52201: db/hash_page.c: Reswap memory buffer in __put_page when dealing with a different byte order.
Aug 28 2025, 11:18 AM

Aug 20 2025

bnovkov added a comment to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.

Is it possible that this broke grub2-bhyve built for older FreeBSD 15-CURRENT? https://lists.freebsd.org/archives/freebsd-current/2025-August/008456.html

Could we add something to RELNOTES/UPDATING to say this happened? Did we bump FreeBSD version for this one?

(a rebuilt ghub2-bhyve with libvmmapi.so.7 works fine)

Aug 20 2025, 6:17 PM
bnovkov committed rGba487345f85f: UPDATING: Add an entry covering recent libvmmapi ABI changes (authored by bnovkov).
UPDATING: Add an entry covering recent libvmmapi ABI changes
Aug 20 2025, 6:15 PM
bnovkov closed D52054: UPDATING: Add an entry covering recent libvmmapi ABI changes.
Aug 20 2025, 6:15 PM
bnovkov requested review of D52054: UPDATING: Add an entry covering recent libvmmapi ABI changes.
Aug 20 2025, 6:09 PM

Aug 7 2025

bnovkov accepted D51796: indent: Fix buffer overflow.
Aug 7 2025, 10:02 PM
bnovkov added inline comments to D51796: indent: Fix buffer overflow.
Aug 7 2025, 4:46 PM

Aug 1 2025

bnovkov committed rG092b70dadb1b: riscv: Add cvitek SoC files to the build (authored by bnovkov).
riscv: Add cvitek SoC files to the build
Aug 1 2025, 12:51 PM
bnovkov committed rGe9dd9f95f82f: riscv: Add the sdhci_fdt driver to the build (authored by bnovkov).
riscv: Add the sdhci_fdt driver to the build
Aug 1 2025, 12:51 PM
bnovkov closed D48534: riscv: Add the sdhci_fdt driver to the build.
Aug 1 2025, 12:51 PM
bnovkov closed D48533: riscv: Add cvitek SoC files to the build.
Aug 1 2025, 12:51 PM
bnovkov closed D48531: riscv: Add driver for the cvitek reset controller.
Aug 1 2025, 12:50 PM
bnovkov committed rG25b9b0b6bec9: riscv: Add driver for cvitek reset controller (authored by bnovkov).
riscv: Add driver for cvitek reset controller
Aug 1 2025, 12:46 PM
bnovkov committed rGe07254d1483f: riscv: Add driver for the cvitek reboot controller (authored by bnovkov).
riscv: Add driver for the cvitek reboot controller
Aug 1 2025, 12:46 PM
bnovkov committed rG7a9a15eaf917: if_dwc: Add support for cvitek ethernet controller (authored by bnovkov).
if_dwc: Add support for cvitek ethernet controller
Aug 1 2025, 12:46 PM
bnovkov committed rG89e650eacc9b: sdhci: Add driver for the cvitek sdhci controller (authored by bnovkov).
sdhci: Add driver for the cvitek sdhci controller
Aug 1 2025, 12:46 PM
bnovkov committed rG19643b415b2b: if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified (authored by bnovkov).
if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified
Aug 1 2025, 12:46 PM
bnovkov closed D48530: dwc: Add support for the cvitek ethernet controller.
Aug 1 2025, 12:45 PM
bnovkov closed D48528: sdhci: Add support for the cvitek sdhci controller.
Aug 1 2025, 12:45 PM
bnovkov committed rGaa05d1b2ef8b: db/hash.c: Fix flag check in hash_seq (authored by bnovkov).
db/hash.c: Fix flag check in hash_seq
Aug 1 2025, 9:34 AM

Jul 31 2025

bnovkov committed rG3a686b851f8f: dbm_nextkey: Always return an error if we've reached the end of the database (authored by bnovkov).
dbm_nextkey: Always return an error if we've reached the end of the database
Jul 31 2025, 3:29 PM
bnovkov closed D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 31 2025, 3:29 PM
bnovkov added inline comments to D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 31 2025, 2:55 PM
bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.

Address @markj 's comments.

Jul 31 2025, 2:55 PM

Jul 30 2025

bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.

Remove stray newline.

Jul 30 2025, 3:04 PM
bnovkov requested review of D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 30 2025, 2:57 PM
bnovkov committed rG14598537acec: db/hash.c: Allow O_WRONLY in dbm_open (authored by bnovkov).
db/hash.c: Allow O_WRONLY in dbm_open
Jul 30 2025, 9:32 AM
bnovkov closed D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 30 2025, 9:32 AM
bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 30 2025, 9:32 AM

Jul 29 2025

bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 29 2025, 6:06 PM
bnovkov updated the diff for D51514: db/hash.c: Allow O_WRONLY in dbm_open.

Add O_WRONLY check in hash_get and add corresponding tests.

Jul 29 2025, 6:05 PM

Jul 28 2025

bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 28 2025, 10:57 AM
bnovkov updated the diff for D51514: db/hash.c: Allow O_WRONLY in dbm_open.

Address @markj 's comments.

Jul 28 2025, 10:57 AM

Jul 27 2025

bnovkov added a comment to D46607: libutil: Move cpuset(1) domainset parsing code into libutil.

Looks ok to me with the man page nits fixed.

Jul 27 2025, 4:35 PM
bnovkov committed rGc7a1776752ec: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t (authored by bnovkov).
bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t
Jul 27 2025, 4:34 PM
bnovkov closed D51535: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t.
Jul 27 2025, 4:34 PM
bnovkov committed rG87ab222016a6: bhyve/acpi: Mark dsdt_line as 'printflike' (authored by bnovkov).
bhyve/acpi: Mark dsdt_line as 'printflike'
Jul 27 2025, 4:34 PM
bnovkov closed D51534: bhyve/acpi: Mark dsdt_line as 'printflike'.
Jul 27 2025, 4:34 PM
bnovkov committed rGf1d705d4f431: bhyve: Add support for specifying guest NUMA configuration (authored by bnovkov).
bhyve: Add support for specifying guest NUMA configuration
Jul 27 2025, 4:34 PM
bnovkov committed rG08c7dd2fbe4f: libvmmapi: Add support for setting up and configuring guest NUMA domains (authored by bnovkov).
libvmmapi: Add support for setting up and configuring guest NUMA domains
Jul 27 2025, 4:34 PM
bnovkov closed D44567: bhyve: Add support for specifying VM NUMA configuration.
Jul 27 2025, 4:34 PM
bnovkov closed D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Jul 27 2025, 4:34 PM
bnovkov committed rGa4197ea47777: vmm: Add support for guest NUMA emulation (authored by bnovkov).
vmm: Add support for guest NUMA emulation
Jul 27 2025, 4:33 PM
bnovkov closed D44565: vmm: Add support for specifying NUMA configuration.
Jul 27 2025, 4:33 PM
bnovkov closed D46608: kern_domainset: Split domainset validation logic into a separate function.
Jul 27 2025, 4:33 PM
bnovkov committed rGcf571e08503d: domainset(9): Split domainset validation logic into a separate function (authored by bnovkov).
domainset(9): Split domainset validation logic into a separate function
Jul 27 2025, 4:33 PM
bnovkov closed D46607: libutil: Move cpuset(1) domainset parsing code into libutil.
Jul 27 2025, 4:33 PM
bnovkov added inline comments to D44565: vmm: Add support for specifying NUMA configuration.
Jul 27 2025, 4:33 PM
bnovkov committed rGaae23170c8b5: libutil: Move cpuset(1) domain policy parsing code into libutil (authored by bnovkov).
libutil: Move cpuset(1) domain policy parsing code into libutil
Jul 27 2025, 4:33 PM
bnovkov updated the diff for D44567: bhyve: Add support for specifying VM NUMA configuration.

Rework and clarify interactions between the -m flag and individual domain memory sizes.

Jul 27 2025, 12:37 PM

Jul 26 2025

bnovkov closed D49488: makefs: Use timestamps provided by -T when adding RockRidge TF records.

Closing this since it was superseded by D49531.

Jul 26 2025, 9:20 AM

Jul 25 2025

bnovkov requested review of D51535: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t.
Jul 25 2025, 6:10 PM
bnovkov requested review of D51534: bhyve/acpi: Mark dsdt_line as 'printflike'.
Jul 25 2025, 6:09 PM
bnovkov requested review of D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 25 2025, 9:29 AM
bnovkov committed rGe1e77dd23ced: dbm: Add tests for dbm_open (authored by bnovkov).
dbm: Add tests for dbm_open
Jul 25 2025, 9:28 AM
bnovkov committed rG108e2d1137aa: db/hash.c: Do not return an error when opening a missing database with O_CREAT (authored by bnovkov).
db/hash.c: Do not return an error when opening a missing database with O_CREAT
Jul 25 2025, 9:28 AM
bnovkov closed D51492: dbm: Add tests for dbm_open.
Jul 25 2025, 9:28 AM
bnovkov closed D51491: db/hash.c: Do not return an error when opening a missing database with O_CREAT.
Jul 25 2025, 9:28 AM

Jul 24 2025

bnovkov requested review of D51491: db/hash.c: Do not return an error when opening a missing database with O_CREAT.
Jul 24 2025, 3:52 PM
bnovkov requested review of D51492: dbm: Add tests for dbm_open.
Jul 24 2025, 3:52 PM

Jul 19 2025

bnovkov added a comment to D44567: bhyve: Add support for specifying VM NUMA configuration.

Have you tried booting a Linux guest with NUMA configured?

Jul 19 2025, 10:07 PM
bnovkov updated the diff for D44567: bhyve: Add support for specifying VM NUMA configuration.

Address @markj's comments

Jul 19 2025, 10:05 PM
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Jul 19 2025, 9:42 PM
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.

Address @markj 's comments and fix an edge case where VM_LOWMEM_LIMIT == 0 .

Jul 19 2025, 9:42 PM

Jul 16 2025

bnovkov committed rG42d59ad1d63e: pt: Include missing sys/lock.h header (authored by bnovkov).
pt: Include missing sys/lock.h header
Jul 16 2025, 5:17 PM
bnovkov committed rG310162ea218a: hwt(4): Add Intel Processor Trace backend (authored by bnovkov).
hwt(4): Add Intel Processor Trace backend
Jul 16 2025, 4:42 PM
bnovkov closed D46397: amd64: Intel Processor Trace support.
Jul 16 2025, 4:41 PM
bnovkov committed rG636823cfd260: makefs: Correct license text in 'makefs_msdos_tests.sh' (authored by bnovkov).
makefs: Correct license text in 'makefs_msdos_tests.sh'
Jul 16 2025, 3:09 PM
bnovkov committed rG483ef23ebb72: release: Consistently use variables for invoking certain tools (authored by bnovkov).
release: Consistently use variables for invoking certain tools
Jul 16 2025, 3:09 PM
bnovkov committed rG06077dc327ea: makefs: Fix undefined behaviour in ffs.c (authored by bnovkov).
makefs: Fix undefined behaviour in ffs.c
Jul 16 2025, 3:09 PM
bnovkov closed D51037: makefs: Fix undefined behaviour in ffs.c.
Jul 16 2025, 3:09 PM
bnovkov committed rGceab09e3dbc2: release: Add a helper script for common tools (authored by bnovkov).
release: Add a helper script for common tools
Jul 16 2025, 3:09 PM
bnovkov closed D51039: release: Consistently use variables for invoking certain tools.
Jul 16 2025, 3:09 PM
bnovkov closed D51038: release: Add a helper script for common tools.
Jul 16 2025, 3:08 PM

Jul 13 2025

bnovkov added inline comments to D44565: vmm: Add support for specifying NUMA configuration.
Jul 13 2025, 5:36 PM
bnovkov updated the diff for D44565: vmm: Add support for specifying NUMA configuration.

Address @markj 's comments.

Jul 13 2025, 5:35 PM
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Jul 13 2025, 5:00 PM
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.

Address @markj 's comments:

  • Remove cpu affinity tracking
Jul 13 2025, 4:59 PM
bnovkov added a comment to D44567: bhyve: Add support for specifying VM NUMA configuration.

I have reworked the acpi.c changes in a way that simplifies tracking cpu affinities (and allows us to get rid of libvmmapi cpu affinity interfaces).

Jul 13 2025, 4:58 PM
bnovkov updated the diff for D44567: bhyve: Add support for specifying VM NUMA configuration.

Address @markj 's comments and rework acpi.c changes:

  • acpi.c now tracks each 'vCPUid->domain' mapping
  • New mappings can be added using acpi_add_vcpu_affinity
  • Manpage fixes
Jul 13 2025, 4:51 PM
bnovkov accepted D51276: tracing(7): Add hwt(4).
Jul 13 2025, 3:08 PM

Jul 12 2025

bnovkov added inline comments to D51276: tracing(7): Add hwt(4).
Jul 12 2025, 12:11 PM

Jul 11 2025

bnovkov added a comment to D50983: style.9: Add a C++ section.

One minor thing that wasn't mentioned here (and is likely be brought up in future C++ reviews) is the order of C++ includes. More specifically, should the C++ standard library includes come before or after /usr/include files?

Jul 11 2025, 5:31 PM

Jul 7 2025

bnovkov added a comment to D48199: Add ctfdiff.

I left a couple of comments about a few things that stood out in the first pass, I will likely have more as I dive into the internals.

Jul 7 2025, 6:13 PM
bnovkov added a member for srcmgr: bnovkov.
Jul 7 2025, 4:44 PM
bnovkov requested review of D51189: release/gce.conf: Fix incorrect '/etc/rc.d/growfs' path.
Jul 7 2025, 1:57 PM

Jul 3 2025

bnovkov added inline comments to D44567: bhyve: Add support for specifying VM NUMA configuration.
Jul 3 2025, 10:43 PM
bnovkov updated the diff for D44567: bhyve: Add support for specifying VM NUMA configuration.

Address @markj 's comments.

Jul 3 2025, 10:40 PM
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Jul 3 2025, 10:36 PM
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.

Address @markj 's comments.

Jul 3 2025, 10:28 PM
bnovkov added inline comments to D44565: vmm: Add support for specifying NUMA configuration.
Jul 3 2025, 10:26 PM
bnovkov updated the diff for D44565: vmm: Add support for specifying NUMA configuration.

Address @markj 's comments:

  • Move domainset parsing code to the ioctl handler
  • Add COMPAT handlers for pre-15.0 memory segments
Jul 3 2025, 10:24 PM