User Details
- User Since
- Jan 29 2022, 5:50 PM (193 w, 4 d)
Tue, Oct 14
Mon, Oct 13
Hi, is there a concrete reason why this revision never landed or has it just slipped through the cracks?
Sep 11 2025
Sep 10 2025
LGTM overall (aside from the race issues that you'll handle in a separate PR).
I tested the changes with stress2 in a NUMA VM for a couple of hours and didn't run into any obvious issues.
Sep 9 2025
Aug 28 2025
Aug 20 2025
Aug 7 2025
Aug 1 2025
Jul 31 2025
Address @markj 's comments.
Jul 30 2025
Remove stray newline.
Jul 29 2025
Add O_WRONLY check in hash_get and add corresponding tests.
Jul 28 2025
Address @markj 's comments.
Jul 27 2025
Rework and clarify interactions between the -m flag and individual domain memory sizes.
Jul 26 2025
Closing this since it was superseded by D49531.
Jul 25 2025
Jul 24 2025
Jul 19 2025
Address @markj's comments
Address @markj 's comments and fix an edge case where VM_LOWMEM_LIMIT == 0 .
Jul 16 2025
Jul 13 2025
Address @markj 's comments.
Address @markj 's comments:
- Remove cpu affinity tracking
I have reworked the acpi.c changes in a way that simplifies tracking cpu affinities (and allows us to get rid of libvmmapi cpu affinity interfaces).
Address @markj 's comments and rework acpi.c changes:
- acpi.c now tracks each 'vCPUid->domain' mapping
- New mappings can be added using acpi_add_vcpu_affinity
- Manpage fixes
Jul 12 2025
Jul 11 2025
One minor thing that wasn't mentioned here (and is likely be brought up in future C++ reviews) is the order of C++ includes. More specifically, should the C++ standard library includes come before or after /usr/include files?
Jul 7 2025
I left a couple of comments about a few things that stood out in the first pass, I will likely have more as I dive into the internals.
Jul 3 2025
Address @markj 's comments.
Address @markj 's comments.
Address @markj 's comments:
- Move domainset parsing code to the ioctl handler
- Add COMPAT handlers for pre-15.0 memory segments