Page MenuHomeFreeBSD

bnovkov (Bojan Novković)
User

Projects

User Details

User Since
Jan 29 2022, 5:50 PM (215 w, 4 d)

Recent Activity

Sun, Mar 15

bnovkov accepted D55869: Revert "bsd.own.mk: Deorbit compat include of bsd.compiler.mk".
Sun, Mar 15, 7:44 PM
bnovkov accepted D55867: bsd.own.mk: Deorbit compat include of bsd.compiler.mk.
Sun, Mar 15, 6:45 PM

Fri, Mar 13

bnovkov accepted D55370: alloca.3: Add entry about defining VLAs in same block as alloca() to BUGS.
Fri, Mar 13, 11:24 AM
bnovkov requested review of D55842: libc/db: Remove unused hash functions in hash_func.c.
Fri, Mar 13, 11:10 AM

Tue, Mar 3

bnovkov requested review of D55641: pmc: Import Intel Meteor Lake events.
Tue, Mar 3, 9:46 PM

Wed, Feb 25

bnovkov closed D55463: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors.
Wed, Feb 25, 11:31 AM
bnovkov committed rGbce0c14fe19d: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors (authored by bnovkov).
mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors
Wed, Feb 25, 11:31 AM

Tue, Feb 24

bnovkov accepted D55483: system(3): Clarify return values.
Tue, Feb 24, 2:25 PM
bnovkov accepted D55482: system(3): Write our own tests.
Tue, Feb 24, 2:19 PM
bnovkov accepted D55471: system(3): Improve signal handling.
Tue, Feb 24, 2:07 PM
bnovkov accepted D55484: system(3): Fix null case.
Tue, Feb 24, 1:52 PM

Mon, Feb 23

bnovkov added inline comments to D55463: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors.
Mon, Feb 23, 4:35 PM
bnovkov updated the diff for D55463: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors.

Remove redundant errno save

Mon, Feb 23, 4:35 PM
bnovkov requested review of D55463: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors.
Mon, Feb 23, 3:52 PM

Thu, Feb 19

bnovkov accepted D54741: vmm: Enable unprivileged bhyve.
Thu, Feb 19, 5:15 PM
bnovkov accepted D54742: vmm.4: Add information on VM access control.
Thu, Feb 19, 5:15 PM
bnovkov accepted D54740: vmm: Add privilege checks to vmmctl operations.
Thu, Feb 19, 5:14 PM
bnovkov accepted D55379: bhyveload: simplify cb_open() and eliminate minor TOCTOU.
Thu, Feb 19, 5:11 PM
bnovkov added inline comments to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.
Thu, Feb 19, 1:58 PM

Wed, Feb 18

bnovkov added a comment to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

I guess this mostly relates to support for legacy and 32-bit guest operating systems? I tend to think it's undesirable to break support for them, given that virtualizing legacy systems is a major reason to use bhyve in the first place, at least in principle.

Does it simplify things at all to use a single vmem arena for both 32-bit and 64-bit memory BARs, and apply constraints as needed when calling vmem_xalloc()?

Wed, Feb 18, 5:09 PM
bnovkov updated the diff for D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Fix PCI passthrough:

  • Introduce a state machine that tracks a BAR's address. This allows us to properly release and allocate BAR addresses from the appropriate pool when the guest starts migrating BARs
  • Comply with the remark in pci_emul_assign_bar and allocate small MEM64 BARs from the MEM32 pool
  • Allow the guest to move an already allocated BAR to a new address
Wed, Feb 18, 5:05 PM

Feb 10 2026

bnovkov added a comment to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Have you tested with PCI passthru configured? With just this patch applied, I get an assertion failure in update_bar_address(). Same result if I test your github branch.

Feb 10 2026, 11:04 PM

Feb 8 2026

bnovkov accepted D55158: sdhci_fdt_rockchip: Move ofw_bus_status_okay check.
Feb 8 2026, 4:39 PM
bnovkov accepted D55159: sdhci_fdt_rockchip: Don't return 0 from probe routine.

LGTM.

Feb 8 2026, 4:39 PM

Feb 7 2026

bnovkov updated the diff for D54648: Introduce libbhyve.

Address @markj 's comment - switch to INTERNALLIB

Feb 7 2026, 11:33 AM
bnovkov added inline comments to D54648: Introduce libbhyve.
Feb 7 2026, 11:33 AM

Feb 6 2026

bnovkov committed rG625ed651833e: pmc: Import Intel Granite Rapids events (authored by bnovkov).
pmc: Import Intel Granite Rapids events
Feb 6 2026, 3:21 PM
bnovkov committed rG808a573e6e14: pmc: Import Intel Granite Rapids events (authored by bnovkov).
pmc: Import Intel Granite Rapids events
Feb 6 2026, 3:20 PM

Feb 5 2026

bnovkov added inline comments to D54646: bhyve/pci_emul.c: Add handlers for ACPI PCI hotplug metadata.
Feb 5 2026, 6:20 PM
bnovkov updated the diff for D54646: bhyve/pci_emul.c: Add handlers for ACPI PCI hotplug metadata.

Address @markj 's comments.

Feb 5 2026, 6:20 PM
bnovkov added inline comments to D54643: bhyve: Refactor pci_irq_route.
Feb 5 2026, 6:07 PM
bnovkov updated the diff for D54643: bhyve: Refactor pci_irq_route.

Address @markj 's comments.

Feb 5 2026, 6:07 PM
bnovkov added a comment to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Have you tested with PCI passthru configured? With just this patch applied, I get an assertion failure in update_bar_address(). Same result if I test your github branch.

Feb 5 2026, 6:04 PM
bnovkov updated the diff for D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Address @markj 's comments.

Feb 5 2026, 6:03 PM
bnovkov updated the diff for D54644: bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slots.

Address @markj 's comments.

Feb 5 2026, 6:02 PM

Feb 4 2026

bnovkov committed rGa3ff85e11925: pmc: Import Intel Granite Rapids events (authored by bnovkov).
pmc: Import Intel Granite Rapids events
Feb 4 2026, 3:42 PM
bnovkov closed D55081: pmc: Import Intel Granite Rapids events.
Feb 4 2026, 3:41 PM

Feb 3 2026

bnovkov requested review of D55081: pmc: Import Intel Granite Rapids events.
Feb 3 2026, 3:33 PM
bnovkov accepted D55068: vmm: Fix a resource leak in an error path.
Feb 3 2026, 12:05 PM
bnovkov accepted D55069: vmm: Remove an unneeded NULL pointer check.
Feb 3 2026, 12:05 PM

Feb 1 2026

bnovkov requested review of D55041: login: install per-UID setrlimit(2) limits on login.
Feb 1 2026, 5:22 PM
bnovkov requested review of D55040: lib{c,sys}: Expose setrlimit_uid(2) as an interposed syscall.
Feb 1 2026, 5:22 PM
bnovkov requested review of D55039: Introduce setrlimit_uid(2).
Feb 1 2026, 5:22 PM
bnovkov requested review of D55038: kern_resource.c: Track per-UID resource limits in 'struct uidinfo'.
Feb 1 2026, 5:22 PM
bnovkov requested review of D55037: getrlimit.2: Add standards section.
Feb 1 2026, 5:22 PM

Jan 27 2026

bnovkov updated the diff for D54654: bhyve/net_backends: Source file descriptors from nvlists.

Use procdesc(4) to enable slirp backend hotplugging.

Jan 27 2026, 7:54 PM
bnovkov committed rG4bcc5a3cdc05: btree/bt_seq.c: Fix two NULL pointer dereferences (authored by bnovkov).
btree/bt_seq.c: Fix two NULL pointer dereferences
Jan 27 2026, 4:49 PM
bnovkov closed D54905: btree/bt_seq.c: Fix two NULL pointer dereferences.
Jan 27 2026, 4:49 PM
bnovkov requested review of D54905: btree/bt_seq.c: Fix two NULL pointer dereferences.
Jan 27 2026, 3:35 PM
bnovkov committed rG1e233e393ddd: btree/bt_split.c: Fix a misaligned if statement (authored by bnovkov).
btree/bt_split.c: Fix a misaligned if statement
Jan 27 2026, 1:53 PM

Jan 24 2026

bnovkov updated the diff for D54654: bhyve/net_backends: Source file descriptors from nvlists.

Fix slirp_init_fds.

Jan 24 2026, 7:10 PM
bnovkov updated the diff for D54648: Introduce libbhyve.

Fix the LIBBHYVEDIR variable.

Jan 24 2026, 7:07 PM

Jan 20 2026

bnovkov accepted D54743: vmm: Start using exterror.
Jan 20 2026, 2:37 PM
bnovkov accepted D54741: vmm: Enable unprivileged bhyve.
Jan 20 2026, 2:32 PM
bnovkov accepted D54740: vmm: Add privilege checks to vmmctl operations.
Jan 20 2026, 2:29 PM
bnovkov added inline comments to D54742: vmm.4: Add information on VM access control.
Jan 20 2026, 2:25 PM

Jan 18 2026

bnovkov updated the diff for D54651: bhyve/pci_emul.c: Add PCI hotplugging IPC commands.

Account for latest changes in D54650.

Jan 18 2026, 6:13 PM
bnovkov updated the diff for D54650: bhyve: Generalize the IPC thread.
  • constify command nvlist_t argument
  • adapt vm_do_checkpoint to use the new return type
Jan 18 2026, 6:08 PM
bnovkov added inline comments to D54650: bhyve: Generalize the IPC thread.
Jan 18 2026, 6:05 PM
bnovkov updated the diff for D54651: bhyve/pci_emul.c: Add PCI hotplugging IPC commands.

Account for latest changes in D54650.

Jan 18 2026, 5:58 PM
bnovkov updated the diff for D54650: bhyve: Generalize the IPC thread.

Address @rew 's comments - change IPC command return type to nvlist_t.

Jan 18 2026, 5:54 PM
bnovkov accepted D54750: vmm: Avoid clobbering errors from vmm_modinit().
Jan 18 2026, 1:17 PM
bnovkov added inline comments to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.
Jan 18 2026, 1:05 PM
bnovkov updated the diff for D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Address @rew 's comments.

Jan 18 2026, 1:04 PM

Jan 14 2026

bnovkov updated the diff for D54652: bhyvectl: Generalize bhyve IPC code.

Address @rew 's comments.

Jan 14 2026, 12:49 AM
bnovkov added inline comments to D54652: bhyvectl: Generalize bhyve IPC code.
Jan 14 2026, 12:49 AM
bnovkov added inline comments to D54641: bhyve/pci_emul: Use vmem to track BAR allocations.
Jan 14 2026, 12:49 AM
bnovkov updated the diff for D54641: bhyve/pci_emul: Use vmem to track BAR allocations.

Address @markj 's comments.

Jan 14 2026, 12:49 AM

Jan 11 2026

bnovkov requested review of D54656: bhyve/virtio-net: Make hotpluggable.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54655: bhyve/e82545: Make hotpluggable.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54654: bhyve/net_backends: Source file descriptors from nvlists.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54653: bhyvectl: Add device hotplugging options.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54652: bhyvectl: Generalize bhyve IPC code.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54651: bhyve/pci_emul.c: Add PCI hotplugging IPC commands.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54650: bhyve: Generalize the IPC thread.
Jan 11 2026, 1:33 PM
bnovkov requested review of D54649: bhyve/pci_emul_init: Allow runtime device initialization.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54648: Introduce libbhyve.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54647: bhyve/pci_emul.c: Introduce device teardown routines.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54646: bhyve/pci_emul.c: Add handlers for ACPI PCI hotplug metadata.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54645: bhyve/pci_emul.c: Emit ACPI methods for hotpluggable slots.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54644: bhyve/pci_emul.c: Setup fixed PCI irq mappings for hotpluggable slots.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54643: bhyve: Refactor pci_irq_route.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54642: bhyve/pci_emul.c: Introduce notion of fixed and hotpluggable slots.
Jan 11 2026, 1:32 PM
bnovkov requested review of D54641: bhyve/pci_emul: Use vmem to track BAR allocations.
Jan 11 2026, 1:32 PM
bnovkov added a member for bhyve: bnovkov.
Jan 11 2026, 1:04 PM

Jan 1 2026

bnovkov accepted D54429: makefs: tests: Fix timestamp-related tests.
Jan 1 2026, 3:58 PM

Dec 17 2025

bnovkov accepted D54273: limits: Unbreak after RLIMIT_VMM addition.
Dec 17 2025, 7:11 PM
bnovkov accepted D54273: limits: Unbreak after RLIMIT_VMM addition.
Dec 17 2025, 7:10 PM
bnovkov committed rGf892c97b6109: bhyve: Introduce monitor mode (authored by bnovkov).
bhyve: Introduce monitor mode
Dec 17 2025, 2:10 PM
bnovkov closed D53731: bhyve: Introduce monitor mode.
Dec 17 2025, 2:10 PM
bnovkov committed rG3c0686082df8: bhyve: Eliminate exit status magic numbers (authored by bnovkov).
bhyve: Eliminate exit status magic numbers
Dec 17 2025, 2:10 PM
bnovkov closed D53730: bhyve: Eliminate exit status magic numbers.
Dec 17 2025, 2:10 PM
bnovkov committed rGbd16bac27e7e: vmm: Add ability to destroy VMs on close (authored by bnovkov).
vmm: Add ability to destroy VMs on close
Dec 17 2025, 2:09 PM
bnovkov closed D53729: vmm: Add ability to destroy VMs on close.
Dec 17 2025, 2:09 PM
bnovkov closed D53728: kern: Introduce RLIMIT_VMM.
Dec 17 2025, 2:09 PM
bnovkov added inline comments to D54087: bhyve: change suspend exit code.
Dec 17 2025, 2:09 PM
bnovkov committed rG1092ec8b3375: kern: Introduce RLIMIT_VMM (authored by bnovkov).
kern: Introduce RLIMIT_VMM
Dec 17 2025, 2:09 PM

Dec 15 2025

bnovkov committed rG4f7436bf297b: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map (authored by bnovkov).
amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map
Dec 15 2025, 3:48 PM
bnovkov closed D54210: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map.
Dec 15 2025, 3:44 PM
bnovkov committed rGf1809eab82a7: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map (authored by bnovkov).
amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map
Dec 15 2025, 3:44 PM