Page MenuHomeFreeBSD

bnovkov (Bojan Novković)
User

Projects

User Details

User Since
Jan 29 2022, 5:50 PM (203 w, 5 d)

Recent Activity

Wed, Dec 17

bnovkov accepted D54273: limits: Unbreak after RLIMIT_VMM addition.
Wed, Dec 17, 7:11 PM
bnovkov accepted D54273: limits: Unbreak after RLIMIT_VMM addition.
Wed, Dec 17, 7:10 PM
bnovkov committed rGf892c97b6109: bhyve: Introduce monitor mode (authored by bnovkov).
bhyve: Introduce monitor mode
Wed, Dec 17, 2:10 PM
bnovkov closed D53731: bhyve: Introduce monitor mode.
Wed, Dec 17, 2:10 PM
bnovkov committed rG3c0686082df8: bhyve: Eliminate exit status magic numbers (authored by bnovkov).
bhyve: Eliminate exit status magic numbers
Wed, Dec 17, 2:10 PM
bnovkov closed D53730: bhyve: Eliminate exit status magic numbers.
Wed, Dec 17, 2:10 PM
bnovkov committed rGbd16bac27e7e: vmm: Add ability to destroy VMs on close (authored by bnovkov).
vmm: Add ability to destroy VMs on close
Wed, Dec 17, 2:09 PM
bnovkov closed D53729: vmm: Add ability to destroy VMs on close.
Wed, Dec 17, 2:09 PM
bnovkov closed D53728: kern: Introduce RLIMIT_VMM.
Wed, Dec 17, 2:09 PM
bnovkov added inline comments to D54087: bhyve: change suspend exit code.
Wed, Dec 17, 2:09 PM
bnovkov committed rG1092ec8b3375: kern: Introduce RLIMIT_VMM (authored by bnovkov).
kern: Introduce RLIMIT_VMM
Wed, Dec 17, 2:09 PM

Mon, Dec 15

bnovkov committed rG4f7436bf297b: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map (authored by bnovkov).
amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map
Mon, Dec 15, 3:48 PM
bnovkov closed D54210: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map.
Mon, Dec 15, 3:44 PM
bnovkov committed rGf1809eab82a7: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map (authored by bnovkov).
amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map
Mon, Dec 15, 3:44 PM

Sat, Dec 13

bnovkov requested review of D54210: amd64/vmm.c: Fix an incorrect memory segment check in vm_iommu_{un}map.
Sat, Dec 13, 3:05 PM

Thu, Dec 11

bnovkov accepted D54171: vm: Fix kstack alignment assertion.
Thu, Dec 11, 8:58 AM

Mon, Dec 1

bnovkov accepted D27220: libuvmem: usermode port of vmem(9).
In D27220#1233531, @kib wrote:

Any progress with testing?

Mon, Dec 1, 8:39 PM
bnovkov added a comment to D53728: kern: Introduce RLIMIT_VMM.

There are already inline comments asking for a comment on the current limit. If possible, I think it would be great also to explain the point of this resource limit. In particular, which resources a VMM consumes that is not already accounted into existing resource limits, such as for memory: RLIMIT_AS, RLIMIT_RSS, RLIMIT_STACK, or CPU: RLIMIT_CPU? I suspect some kernel memory? Are there hardware limitations to the number of VMs that can be created?

Mon, Dec 1, 8:27 PM
bnovkov updated the diff for D53728: kern: Introduce RLIMIT_VMM.

Address @olce 's comments.

Mon, Dec 1, 8:20 PM

Fri, Nov 28

bnovkov closed D48532: riscv: Add driver for the cvitek restart controller.
Fri, Nov 28, 9:59 PM
bnovkov closed D48529: if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified.
Fri, Nov 28, 9:58 PM

Nov 24 2025

bnovkov added inline comments to D53728: kern: Introduce RLIMIT_VMM.
Nov 24 2025, 5:18 PM
bnovkov updated the diff for D53728: kern: Introduce RLIMIT_VMM.
Nov 24 2025, 5:18 PM
bnovkov updated the diff for D53728: kern: Introduce RLIMIT_VMM.

Defer incrementing the vmm counter.

Nov 24 2025, 4:34 PM

Nov 21 2025

bnovkov added inline comments to D53729: vmm: Add ability to destroy VMs on close.
Nov 21 2025, 10:10 AM
bnovkov updated the diff for D53729: vmm: Add ability to destroy VMs on close.

Address @markj 's comments.

Nov 21 2025, 10:09 AM
bnovkov updated the diff for D53731: bhyve: Introduce monitor mode.

Address @markj 's comments.

Nov 21 2025, 10:08 AM
bnovkov updated the diff for D53728: kern: Introduce RLIMIT_VMM.

Address @markj 's comments

Nov 21 2025, 10:08 AM

Nov 19 2025

bnovkov updated the diff for D53731: bhyve: Introduce monitor mode.

Address @markj 's comments.

Nov 19 2025, 5:45 PM
bnovkov added inline comments to D53729: vmm: Add ability to destroy VMs on close.
Nov 19 2025, 5:42 PM
bnovkov updated the diff for D53729: vmm: Add ability to destroy VMs on close.

Address @markj 's comments.

Nov 19 2025, 5:42 PM

Nov 17 2025

bnovkov added inline comments to D53730: bhyve: Eliminate exit status magic numbers.
Nov 17 2025, 2:56 PM
bnovkov updated the diff for D53730: bhyve: Eliminate exit status magic numbers.

Address @emaste 's comment.

Nov 17 2025, 2:55 PM
bnovkov updated the diff for D53729: vmm: Add ability to destroy VMs on close.

Rebase.

Nov 17 2025, 2:51 PM
bnovkov added inline comments to D53728: kern: Introduce RLIMIT_VMM.
Nov 17 2025, 2:47 PM
bnovkov updated the diff for D53728: kern: Introduce RLIMIT_VMM.

Address @corvink 's comments.

Nov 17 2025, 2:45 PM

Nov 13 2025

bnovkov requested review of D53731: bhyve: Introduce monitor mode.
Nov 13 2025, 11:13 AM
bnovkov requested review of D53730: bhyve: Eliminate exit status magic numbers.
Nov 13 2025, 11:13 AM
bnovkov requested review of D53729: vmm: Add ability to destroy VMs on close.
Nov 13 2025, 11:13 AM
bnovkov requested review of D53728: kern: Introduce RLIMIT_VMM.
Nov 13 2025, 11:13 AM

Nov 5 2025

bnovkov accepted D52998: geom/zero: Add support for unmapped I/O.
Nov 5 2025, 10:50 AM

Oct 29 2025

bnovkov committed rG56b4719076b6: pt: Switch to swi(9) (authored by bnovkov).
pt: Switch to swi(9)
Oct 29 2025, 11:51 AM

Oct 17 2025

bnovkov committed rG96d82d2d133a: pt: Switch to swi(9) (authored by bnovkov).
pt: Switch to swi(9)
Oct 17 2025, 9:23 PM
bnovkov closed D52491: pt: Switch to swi(9).
Oct 17 2025, 9:23 PM

Oct 16 2025

bnovkov added a comment to D27220: libuvmem: usermode port of vmem(9).

One minor thing I've noticed is that we don't export M_NOWAIT.
I think it would be very useful to have a way of controlling whether we wait or exit on failure, but I'm not sure if accomplishing that is as straightforward as defining M_NOWAIT in sys/vmem.h.

Oct 16 2025, 2:18 PM

Oct 14 2025

bnovkov added a comment to D27220: libuvmem: usermode port of vmem(9).
In D27220#1212532, @kib wrote:

Hi, is there a concrete reason why this revision never landed or has it just slipped through the cracks?

I would really like to use libuvmem for one of my ongoing bhyve projects and would like to see this land, let me know if there a way I could help with that.

The intent of the libuvmem port was to use vmem allocator for bhyve to handle physical address space. That stalled, and I do not see a reason to add unused library to base.

Oct 14 2025, 5:45 PM

Oct 13 2025

bnovkov added a comment to D27220: libuvmem: usermode port of vmem(9).

Hi, is there a concrete reason why this revision never landed or has it just slipped through the cracks?

Oct 13 2025, 5:39 PM

Sep 11 2025

bnovkov updated the test plan for D52491: pt: Switch to swi(9).
Sep 11 2025, 5:09 PM
bnovkov requested review of D52491: pt: Switch to swi(9).
Sep 11 2025, 5:08 PM

Sep 10 2025

bnovkov accepted D52441: uma_core: Rely on domainset iterator to wait on M_WAITOK.

LGTM overall (aside from the race issues that you'll handle in a separate PR).
I tested the changes with stress2 in a NUMA VM for a couple of hours and didn't run into any obvious issues.

Sep 10 2025, 5:04 PM

Sep 9 2025

bnovkov added inline comments to D52387: release: Add variables for makefs and mkimg arguments.
Sep 9 2025, 10:18 AM
bnovkov accepted D52388: release: Set default timestamps for makefs and mkimg outputs.
Sep 9 2025, 10:04 AM

Aug 28 2025

bnovkov abandoned D52201: db/hash_page.c: Reswap memory buffer in __put_page when dealing with a different byte order.
Aug 28 2025, 1:21 PM
bnovkov requested review of D52201: db/hash_page.c: Reswap memory buffer in __put_page when dealing with a different byte order.
Aug 28 2025, 11:18 AM

Aug 20 2025

bnovkov added a comment to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.

Is it possible that this broke grub2-bhyve built for older FreeBSD 15-CURRENT? https://lists.freebsd.org/archives/freebsd-current/2025-August/008456.html

Could we add something to RELNOTES/UPDATING to say this happened? Did we bump FreeBSD version for this one?

(a rebuilt ghub2-bhyve with libvmmapi.so.7 works fine)

Aug 20 2025, 6:17 PM
bnovkov committed rGba487345f85f: UPDATING: Add an entry covering recent libvmmapi ABI changes (authored by bnovkov).
UPDATING: Add an entry covering recent libvmmapi ABI changes
Aug 20 2025, 6:15 PM
bnovkov closed D52054: UPDATING: Add an entry covering recent libvmmapi ABI changes.
Aug 20 2025, 6:15 PM
bnovkov requested review of D52054: UPDATING: Add an entry covering recent libvmmapi ABI changes.
Aug 20 2025, 6:09 PM

Aug 7 2025

bnovkov accepted D51796: indent: Fix buffer overflow.
Aug 7 2025, 10:02 PM
bnovkov added inline comments to D51796: indent: Fix buffer overflow.
Aug 7 2025, 4:46 PM

Aug 1 2025

bnovkov committed rG092b70dadb1b: riscv: Add cvitek SoC files to the build (authored by bnovkov).
riscv: Add cvitek SoC files to the build
Aug 1 2025, 12:51 PM
bnovkov committed rGe9dd9f95f82f: riscv: Add the sdhci_fdt driver to the build (authored by bnovkov).
riscv: Add the sdhci_fdt driver to the build
Aug 1 2025, 12:51 PM
bnovkov closed D48534: riscv: Add the sdhci_fdt driver to the build.
Aug 1 2025, 12:51 PM
bnovkov closed D48533: riscv: Add cvitek SoC files to the build.
Aug 1 2025, 12:51 PM
bnovkov closed D48531: riscv: Add driver for the cvitek reset controller.
Aug 1 2025, 12:50 PM
bnovkov committed rG25b9b0b6bec9: riscv: Add driver for cvitek reset controller (authored by bnovkov).
riscv: Add driver for cvitek reset controller
Aug 1 2025, 12:46 PM
bnovkov committed rGe07254d1483f: riscv: Add driver for the cvitek reboot controller (authored by bnovkov).
riscv: Add driver for the cvitek reboot controller
Aug 1 2025, 12:46 PM
bnovkov committed rG7a9a15eaf917: if_dwc: Add support for cvitek ethernet controller (authored by bnovkov).
if_dwc: Add support for cvitek ethernet controller
Aug 1 2025, 12:46 PM
bnovkov committed rG89e650eacc9b: sdhci: Add driver for the cvitek sdhci controller (authored by bnovkov).
sdhci: Add driver for the cvitek sdhci controller
Aug 1 2025, 12:46 PM
bnovkov committed rG19643b415b2b: if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified (authored by bnovkov).
if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified
Aug 1 2025, 12:46 PM
bnovkov closed D48530: dwc: Add support for the cvitek ethernet controller.
Aug 1 2025, 12:45 PM
bnovkov closed D48528: sdhci: Add support for the cvitek sdhci controller.
Aug 1 2025, 12:45 PM
bnovkov committed rGaa05d1b2ef8b: db/hash.c: Fix flag check in hash_seq (authored by bnovkov).
db/hash.c: Fix flag check in hash_seq
Aug 1 2025, 9:34 AM

Jul 31 2025

bnovkov committed rG3a686b851f8f: dbm_nextkey: Always return an error if we've reached the end of the database (authored by bnovkov).
dbm_nextkey: Always return an error if we've reached the end of the database
Jul 31 2025, 3:29 PM
bnovkov closed D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 31 2025, 3:29 PM
bnovkov added inline comments to D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 31 2025, 2:55 PM
bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.

Address @markj 's comments.

Jul 31 2025, 2:55 PM

Jul 30 2025

bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.

Remove stray newline.

Jul 30 2025, 3:04 PM
bnovkov requested review of D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Jul 30 2025, 2:57 PM
bnovkov committed rG14598537acec: db/hash.c: Allow O_WRONLY in dbm_open (authored by bnovkov).
db/hash.c: Allow O_WRONLY in dbm_open
Jul 30 2025, 9:32 AM
bnovkov closed D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 30 2025, 9:32 AM
bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 30 2025, 9:32 AM

Jul 29 2025

bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 29 2025, 6:06 PM
bnovkov updated the diff for D51514: db/hash.c: Allow O_WRONLY in dbm_open.

Add O_WRONLY check in hash_get and add corresponding tests.

Jul 29 2025, 6:05 PM

Jul 28 2025

bnovkov added inline comments to D51514: db/hash.c: Allow O_WRONLY in dbm_open.
Jul 28 2025, 10:57 AM
bnovkov updated the diff for D51514: db/hash.c: Allow O_WRONLY in dbm_open.

Address @markj 's comments.

Jul 28 2025, 10:57 AM

Jul 27 2025

bnovkov added a comment to D46607: libutil: Move cpuset(1) domainset parsing code into libutil.

Looks ok to me with the man page nits fixed.

Jul 27 2025, 4:35 PM
bnovkov committed rGc7a1776752ec: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t (authored by bnovkov).
bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t
Jul 27 2025, 4:34 PM
bnovkov closed D51535: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t.
Jul 27 2025, 4:34 PM
bnovkov committed rG87ab222016a6: bhyve/acpi: Mark dsdt_line as 'printflike' (authored by bnovkov).
bhyve/acpi: Mark dsdt_line as 'printflike'
Jul 27 2025, 4:34 PM
bnovkov closed D51534: bhyve/acpi: Mark dsdt_line as 'printflike'.
Jul 27 2025, 4:34 PM
bnovkov committed rGf1d705d4f431: bhyve: Add support for specifying guest NUMA configuration (authored by bnovkov).
bhyve: Add support for specifying guest NUMA configuration
Jul 27 2025, 4:34 PM
bnovkov committed rG08c7dd2fbe4f: libvmmapi: Add support for setting up and configuring guest NUMA domains (authored by bnovkov).
libvmmapi: Add support for setting up and configuring guest NUMA domains
Jul 27 2025, 4:34 PM
bnovkov closed D44567: bhyve: Add support for specifying VM NUMA configuration.
Jul 27 2025, 4:34 PM
bnovkov closed D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Jul 27 2025, 4:34 PM
bnovkov committed rGa4197ea47777: vmm: Add support for guest NUMA emulation (authored by bnovkov).
vmm: Add support for guest NUMA emulation
Jul 27 2025, 4:33 PM
bnovkov closed D44565: vmm: Add support for specifying NUMA configuration.
Jul 27 2025, 4:33 PM
bnovkov closed D46608: kern_domainset: Split domainset validation logic into a separate function.
Jul 27 2025, 4:33 PM
bnovkov committed rGcf571e08503d: domainset(9): Split domainset validation logic into a separate function (authored by bnovkov).
domainset(9): Split domainset validation logic into a separate function
Jul 27 2025, 4:33 PM
bnovkov closed D46607: libutil: Move cpuset(1) domainset parsing code into libutil.
Jul 27 2025, 4:33 PM