LGTM, let's wait for the maintainers before committing.

Could you add the whole, final commit message to the description here on Phab? I'd like to make sure you don't miss anything (please include Approved by: 0mp (mentor) but do not push the change upstream yet).

The change looks pretty good.

I've left a question in a comment but it's not blocking. I'm just curious :)

Thank you all for feedback! :)

• Add UPDATING entry
• Fix typos in rc.subr.8 and do some extra wordsmithing there

Considering that git-arc is now more portable thanks to the patches by @jlduran_gmail.com, I'm closing this revision. If we decide to start quoting variables in git-arc for the sake of defensive programming, we should review the whole file instead of just the echo cases.

I'm closing this revision as I landed @jlduran_gmail.com's patches instead:

I'll commit it soon.

In D47274#1077940, @jlduran_gmail.com wrote:

Thank you for making this tool more portable. This is a cousin commit of D46781 and D46767. I agree, echo (without -n is portable) and IMO, more readable than printf, because there is no need to add a new line at the end. The issue is only with echo -n.

I've got some reports from the NetBSD community that setting rc_fast_and_loose on NetBSD booting on vax simh makes rc finish in 109 seconds instead of 183 seconds (https://mastodon.sdf.org/@mrgtwentythree/113364676304360235).

In D26484#1004695, @unitrunker_gmail.com wrote:

This question terrifies me to even ask.

Are there rc scripts that make use of "breadcrumbs"? By breadcrumb, I mean an earlier script sets a variable that a later script uses.

In D47264#1077729, @markj wrote:

Approved.

This probably deserves an entry in UPDATING as well as the relnotes tag, since it breaks backward compatibility and applies to those who track main as well as release users.

Update docs and remove an unused boottrace function

Reviewed by: samba (0mp)

Thanks!

I'll set MFC to 2 weeks so that it does not land in 14.2.

Set exit status by calling exit in a subshell.

I opened a PR for investigating the rc_fast_and_loose support: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282255

The patch seems OK. Also, the release notes do not mention any breaking changes.

I opened a PR on Bugzilla for the community to have an easier way tracking this update: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282254

Check all invocations.

In D46862#1076197, @gshapiro wrote:

This is an improvement over the current functionality, but I think we would want all invocations to be checked. I wonder if it would be better to separate these into separate rc scripts instead of using one for four possible different daemons. That shouldn't prevent this change from going forward while alternatives are formulated.

If the port builds, I see no reason to prevent this updated from landing.

I see that there was no feedback from gnome@ (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281309) so Approved by: maintainer timeout applies.

Committed in https://cgit.freebsd.org/src/commit/?id=6fa42b91ca3f481912af98c4d49c44507eb1b8e1

Thanks!