Thanks!

?=

In D30315#1226268, @mat wrote:

In D30315#1225899, @mat wrote:

Also, ansible ahould probably not be using USE_PYTHON=concurrent

And I know I am the one who added it, but at the time, we did produce two packages for ansible, one for python 2 and one for python 3.

As we don't produce python 2 ports any more, concurrent should probably be removed from ports like ansible.

Looks OK.

Seems fine but would upstream accept it? What do you think?

Here are some updates:

• typo

• Improve the descirption. Point the reader to mdoc(5) for the defaults and additionally allow very specific files.
• Use X instead of %d.

• s/The each/each/
• Tag SPDX

Thank you for addressing the nit picks :)

The manual page changes and the code changes look OK. Thanks!

Could you also add a note to date.1 saying that %XN is now supported? A note in CAVEATS or BUGS that %-N is not supported would also be good.

I'd just rename SUDO_DEPEND to SUDO_DEPENDS to match the style used in other .mk files under Mk/Uses, but you can just do that right before the commit. No need to submit that style change to Phab again.

• Rebase onto recent main
• Fix a copy/paste mistake where I applied CTLFLAG_MPSAFE to SYSCTL_INT of kern.geom.zero.clear instead of applying it to SYSCTL_PROC of kern.geom.zero.byte. The reason for this confusion was that:
  • SYSCTL_PROC(_kern_geom_zero, ..., clear becomes SYSCTL_INT(_kern_geom_zero, ..., clear in my change because the clear flag no longer needs to be handled by a function.
  • SYSCTL_INT(_kern_geom_zero, ..., byte, becomes SYSCTL_PROC(_kern_geom_zero, ..., byte in my change because the fill byte now needs to fill the g_zero_buffer when the fill byte is changed.

Closed by https://cgit.freebsd.org/src/commit/?id=39acb7fd86eda721df402c2f1368b78cede161c3

I have no objections but ultimately it's up to the maintainer.

• fix order of sections
• add an example of how to benchmark geli(4) encryption

Thanks, Bojan! I'll wait a couple of days for Mark's feedback before committing.

Let's follow mat's advice. Here's what I propose:

Describe:

• rand()
• speculation()