In D3570#73558, @dvl wrote:

In D3570#73547, @wg wrote:

All python modules should start with py-, so py-pytimeparse, although looks ambiguous sounds like a better name for it.

Oh wait. I renamed the directory to py-pytimeparse. Did you mean PORTNAME instead, or both?

py-pytimeparse should be ordered alphabetically within devel/Makefile

All python modules should start with py-, so py-pytimeparse, although looks ambiguous sounds like a better name for it.

Yeah, I had a pending subliminal PR too, two birds one stone

Thanks for the work

looks good but you need kwm@ approval.

at a first glance looks good to me but I would get review from someone else as well since I am not familiar with this port.

There is a typo: CYRL_CMAKE_OFF=

Looks good, but I will need an updated py-libgit port with depends on this one.

Looks good to me.

Also a double line for MASTER_SITES

There is a missing new entry in textproc/Makefile

Dont you need django in your RUN_DEPENDS?

I dont like that header in the pkg-descr file, but other than that looks good.

antoine is right, silly me.

Looks good to me but I will leave it for mva since he wrote all this stuff.

Just a couple comments:

Plus can drop Reviewed by, its implied in Approved by.

Perfect, thank you.

What is the commit message you're going to use?

In D581#11, @danfe wrote:

Yes it looks natural, but @mva had explained it earlier:

The problem is a bit more complex. bsd.perl.mk was a fixed include in
bsd.port.mk prior to the conversion, while bsd.python.mk was and is not.
The compat code in bsd.port.mk right now does the following:

.if defined(USE_PYTHON) ...
USES+= python
.endif

Thus, .if ${USES:Mpython} is always valid.

Isn't there a way to check if we have USES=python to detect the old format instead of values?

Looks good to me.

Nice work, I love it! Very straightforward and clean.

There is still a @${CAT} ${PKGMESSAGE} as well.

In D364#11, @wg wrote:

In D364#9, @mat wrote:

In D364#8, @wg wrote:

Hi,

SEM_CONFIGURE_ON= ac_cv_posix_semaphores_enabled=yes
SEM_CONFIGURE_OFF= ac_cv_posix_semaphores_enabled=no

Shouldnt this be SEM_CONFIGURE_ENV_ON

?

Work both in the ENV and as an argument. (Also, we don't have *_CONFIGURE_ENV_*)

Yes, we do, see /usr/ports/Mk/bsd.options.mk _OPTIONS_FLAGS.

There are places using CONFIGURE_ENV_ON and other places using CONFIGURE_ON, just trying to understand why the discrepancy.

In D364#9, @mat wrote:

In D364#8, @wg wrote:

Hi,

SEM_CONFIGURE_ON= ac_cv_posix_semaphores_enabled=yes
SEM_CONFIGURE_OFF= ac_cv_posix_semaphores_enabled=no

Shouldnt this be SEM_CONFIGURE_ENV_ON

?

Work both in the ENV and as an argument. (Also, we don't have *_CONFIGURE_ENV_*)

SEM_CONFIGURE_ON= ac_cv_posix_semaphores_enabled=yes
SEM_CONFIGURE_OFF= ac_cv_posix_semaphores_enabled=no

Sounds good to me.