Page MenuHomeFreeBSD

devel/libgit2-glib: Updated to 0.23.4
ClosedPublic

Authored by andoriyu_gmail.com on Aug 27 2015, 6:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 9:12 AM
Unknown Object (File)
Feb 18 2024, 6:28 PM
Unknown Object (File)
Feb 18 2024, 6:28 PM
Unknown Object (File)
Feb 9 2024, 10:23 AM
Unknown Object (File)
Dec 1 2023, 7:00 PM
Unknown Object (File)
Nov 1 2023, 7:28 AM
Unknown Object (File)
Sep 25 2023, 12:23 PM
Unknown Object (File)
Jun 14 2023, 7:26 PM
Subscribers

Details

Reviewers
wg
kwm
Group Reviewers
gnome
Contributor Reviewers (ports)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

andoriyu_gmail.com retitled this revision from to devel/libgit2-glib: Updated to 0.23.4.
andoriyu_gmail.com updated this object.
andoriyu_gmail.com edited the test plan for this revision. (Show Details)

at a first glance looks good to me but I would get review from someone else as well since I am not familiar with this port.

kwm requested changes to this revision.Aug 28 2015, 8:49 AM
kwm added a reviewer: kwm.
kwm added a subscriber: kwm.

Like everything related to libgit2. This version is for libgit2 0.23 since it not API stable between 0.x releases.

The whole stack needs to be updated in one go. libgit2, libgit2-glib, gitg, py-pygit2 and rubygem-rugged. Like I did in https://svnweb.freebsd.org/changeset/ports/386103

This revision now requires changes to proceed.Aug 28 2015, 8:49 AM

Oh now I see the other ports. I think this would be more clear if there was 1 patch/review for all the ports instead of spreading them around in 1 review per patch. Since they depend quite closely with each other.

In D3499#71896, @kwm wrote:

Oh now I see the other ports. I think this would be more clear if there was 1 patch/review for all the ports instead of spreading them around in 1 review per patch. Since they depend quite closely with each other.

Do you want me to change it to one patch instead? I didn't know what the workflow for this situation and made one per port.

kwm edited edge metadata.

Approved if you add compiler:c11 to USES (at the beginning please, so it stays sorted) to deal with some code that gcc from base doesn't understand.

This revision is now accepted and ready to land.Sep 4 2015, 10:17 PM
andoriyu_gmail.com edited edge metadata.
andoriyu_gmail.com set the repository for this revision to rP FreeBSD ports repository.
This revision now requires review to proceed.Sep 6 2015, 8:18 PM
kwm edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2015, 8:55 PM