Page MenuHomeFreeBSD

multimedia/ffmpeg0: Use OPTIONS helpers, Honour CFLAGS
ClosedPublic

Authored by koobs on Jul 3 2015, 9:58 AM.

Details

Summary

Proposed commit log:

multimedia/ffmpeg0: Use OPTIONS helpers, Honour CFLAGS

- Use OPTIONS helpers for as many as conditional blocks as possible.
  Blocks with FFMPEG_* and other variables not supported by the helper
  framework are not modified. 
- Honour CFLAGS for armv6 (= -> ?=)
  
While I'm here:

- Sort and group common or related Makefile sections where it made sense
  to do so and improved readability. Put global things up the top and
  conditional blocks below.
- Improve whitespace alignment for readability.

Approved by: portmgr (blanket, options helpers)
Approved by: wg (maintainer)
Test Plan

portlint: No new warnings
testport: OK (with X264 option)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

koobs updated this revision to Diff 6663.Jul 3 2015, 9:58 AM
koobs retitled this revision from to multimedia/ffmpeg0: Use OPTIONS helpers, Honour CFLAGS.
koobs updated this object.
koobs edited the test plan for this revision. (Show Details)
koobs added reviewers: portmgr, wg.
wg accepted this revision.Jul 3 2015, 12:21 PM
wg edited edge metadata.
This revision is now accepted and ready to land.Jul 3 2015, 12:21 PM
This revision was automatically updated to reflect the committed changes.