Page MenuHomeFreeBSD
Differential D1168

refs #2688 - add jsonfield (py-django-jsonfield_rebase)
AbandonedPublic
Actions

Authored by alfred on Nov 15 2014, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 5:24 PM
Unknown Object (File)
Wed, Sep 23, 6:58 AM
Unknown Object (File)
Wed, Sep 23, 12:25 AM
Unknown Object (File)
Tue, Sep 22, 12:18 AM
Unknown Object (File)
Mon, Sep 21, 2:42 PM
Unknown Object (File)
Sun, Sep 20, 7:28 AM
Unknown Object (File)
Sun, Sep 20, 7:24 AM
Unknown Object (File)
Sat, Sep 12, 11:57 AM
View All Files
Subscribers
koobs
miwi
mva
wg
Python

Details

Reviewers
mva
koobs
Group Reviewers
Python

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 680
Build 680: arc lint + arc unit

Event Timeline

alfred updated this revision to Diff 2417.Nov 15 2014, 8:02 AM
alfred retitled this revision from to refs #2688 - add jsonfield.
alfred updated this object.
alfred edited the test plan for this revision. (Show Details)
alfred added a reviewer: Python.Nov 15 2014, 8:02 AM
alfred added a subscriber: Python.Nov 15 2014, 8:04 AM
mva requested changes to this revision.Nov 20 2014, 11:37 AM
mva added a reviewer: mva.
mva added a subscriber: mva.
mva added inline comments.
www/py-django-jsonfield/Makefile
16

As for your other review requests, use USES=python (do you have DEVELOPER=y set in your make.conf - it should warn you about that?)

www/py-django-jsonfield/pkg-descr
2

Remove all the empty lines (they make the description hard to read) and add WWW:

This revision now requires changes to proceed.Nov 20 2014, 11:37 AM
alfred updated this revision to Diff 2496.Nov 21 2014, 5:03 PM
alfred edited edge metadata.
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.
wg added a subscriber: wg.Nov 21 2014, 5:05 PM

Dont you need django in your RUN_DEPENDS?

koobs requested changes to this revision.Dec 2 2014, 9:12 AM
koobs added a reviewer: koobs.
koobs added a subscriber: koobs.
koobs added inline comments.
www/py-django-jsonfield/Makefile
12

COMMENT= JSONField for Django models [1]

(1) https://bitbucket.org/schinckel/django-jsonfield/src/c23af01172f0ee9e0712a729be805de1041eee63/setup.py?at=default#cl-7

14

LICENSE is BSD2CLAUSE [1][2]

(1) https://bitbucket.org/schinckel/django-jsonfield/src/c23af01172f0ee9e0712a729be805de1041eee63/setup.py?at=default#cl-18
(2) https://bitbucket.org/schinckel/django-jsonfield/src/c23af01172f0ee9e0712a729be805de1041eee63/LICENSE?at=default

15

Add RUN_DEPENDS on django

18

Add regression-test: target [1]

@cd ${WRKSRC} && {$PYTHON_CMD) ${PYDISTUTILS_SETUP} ${PYSETUP}

(1) https://bitbucket.org/schinckel/django-jsonfield/src/c23af01172f0ee9e0712a729be805de1041eee63/setup.py?at=default#cl-22

This revision now requires changes to proceed.Dec 2 2014, 9:12 AM
alfred updated this revision to Diff 3611.Feb 3 2015, 4:47 PM
alfred edited edge metadata.
  • refs #2688 - add jsonfield
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.
  • fix comment, license and run_depends+=django
  • Add regression test target
alfred retitled this revision from refs #2688 - add jsonfield to refs #2688 - add jsonfield (py-django-jsonfield_rebase).Feb 3 2015, 4:49 PM
alfred edited edge metadata.
koobs requested changes to this revision.Mar 11 2015, 11:28 AM
koobs edited edge metadata.
koobs added inline comments.
www/py-django-jsonfield/Makefile
14

Distribution file has a LICENSE file. Add LICENSE_FILE accordingly

17

Sort values by alpha

19

Only = assignment is needed here

21

Nice! :)

www/py-django-jsonfield/pkg-descr
9

Homepage "url" field in setup.py says

url = "http://bitbucket.org/schinckel/django-jsonfield/",

Lint: Match what upstream says

This revision now requires changes to proceed.Mar 11 2015, 11:28 AM
alfred updated this revision to Diff 9148.Oct 4 2015, 9:07 PM
alfred edited edge metadata.
  • refs #2688 - add jsonfield
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.
  • fix comment, license and run_depends+=django
  • Update to 1.0.3, address review comments.
alfred updated this revision to Diff 9149.Oct 4 2015, 9:08 PM
alfred edited edge metadata.
  • Update www from review
miwi added a subscriber: miwi.Jan 2 2016, 3:28 PM

any update on this one :)?

alfred abandoned this revision.Dec 31 2017, 6:10 PM

Not sure what happened here, but someone added this port already, so I'm dropping this.

Revision Contents
Changeset List

PathSize
www/
py-django-jsonfield/
23 lines
2 lines
8 lines

Diff 9149

View Options

www/py-django-jsonfield/Makefile

Loading...
View Options

www/py-django-jsonfield/distinfo

Loading...
View Options

www/py-django-jsonfield/pkg-descr

Loading...