Page MenuHomeFreeBSD

refs #2688 - add jsonfield (py-django-jsonfield_rebase)
AbandonedPublic

Authored by alfred on Nov 15 2014, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Mon, Apr 29, 4:18 AM
Unknown Object (File)
Sat, Apr 27, 12:26 AM
Unknown Object (File)
Sat, Apr 20, 4:26 PM
Unknown Object (File)
Mon, Apr 8, 10:02 AM
Unknown Object (File)
Mon, Apr 8, 9:58 AM
Unknown Object (File)
Mar 18 2024, 4:56 PM
Unknown Object (File)
Mar 16 2024, 11:27 AM

Details

Reviewers
mva
koobs
Group Reviewers
Python

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

alfred retitled this revision from to refs #2688 - add jsonfield.
alfred updated this object.
alfred edited the test plan for this revision. (Show Details)
mva requested changes to this revision.Nov 20 2014, 11:37 AM
mva added a reviewer: mva.
mva added a subscriber: mva.
mva added inline comments.
www/py-django-jsonfield/Makefile
15

As for your other review requests, use USES=python (do you have DEVELOPER=y set in your make.conf - it should warn you about that?)

www/py-django-jsonfield/pkg-descr
1

Remove all the empty lines (they make the description hard to read) and add WWW:

This revision now requires changes to proceed.Nov 20 2014, 11:37 AM
alfred edited edge metadata.
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.

Dont you need django in your RUN_DEPENDS?

This revision now requires changes to proceed.Dec 2 2014, 9:12 AM
alfred edited edge metadata.
  • refs #2688 - add jsonfield
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.
  • fix comment, license and run_depends+=django
  • Add regression test target
alfred retitled this revision from refs #2688 - add jsonfield to refs #2688 - add jsonfield (py-django-jsonfield_rebase).Feb 3 2015, 4:49 PM
alfred edited edge metadata.
koobs requested changes to this revision.Mar 11 2015, 11:28 AM
koobs edited edge metadata.
koobs added inline comments.
www/py-django-jsonfield/Makefile
14

Distribution file has a LICENSE file. Add LICENSE_FILE accordingly

17

Sort values by alpha

19

Only = assignment is needed here

21

Nice! :)

www/py-django-jsonfield/pkg-descr
9

Homepage "url" field in setup.py says

url = "http://bitbucket.org/schinckel/django-jsonfield/",

Lint: Match what upstream says

This revision now requires changes to proceed.Mar 11 2015, 11:28 AM
alfred edited edge metadata.
  • refs #2688 - add jsonfield
  • D1168#4 - Fixup USES.
  • D1168#4 - cleanup pkg-descr: add WWW, and text formatting.
  • fix comment, license and run_depends+=django
  • Update to 1.0.3, address review comments.
alfred edited edge metadata.
  • Update www from review

any update on this one :)?

Not sure what happened here, but someone added this port already, so I'm dropping this.