Stage bacula-docs and upgrade to 7.0.3 (latest version)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
The patch to sysutils/bacula5-docs/Makefile is accidental. It will not be included in the commit.
Comment Actions
Just a couple comments:
- Be careful adding contiguous blank lines, they are included in the diff and add no value (ports-mgmt/portlint can be very useful for caughting some mistakes like this)
- You might as well change the maintainer address to your FreeBSD email
Are you testing these changes using poudriere or redports? I think it would add a lot of value if you could attach the build log at least for now. Maybe I am being too paranoid but it helped me to prevent mistakes when I was starting as a committer.
Thanks!
Comment Actions
- Those lines were added in because I was comparing bacula-docs with bacula5-docs, which was already staged. Removed.
- Changed my MAINTAINER email address
- run through redports: https://redports.org/buildarchive/20140821153501-47412/
Comment Actions
Commit message would be:
- Stage bacula-docs and upgrade to 7.0.3 (latest version)
- use my @FreeBSD.org address for MAINTAINER