Page MenuHomeFreeBSD

Make security/py-crits use www/py-django16
ClosedPublic

Authored by dvl on Jun 26 2015, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 3:32 PM
Unknown Object (File)
Jan 19 2024, 2:40 PM
Unknown Object (File)
Dec 22 2023, 9:11 PM
Unknown Object (File)
Dec 13 2023, 11:37 PM
Unknown Object (File)
Dec 13 2023, 3:37 AM
Unknown Object (File)
Dec 12 2023, 8:39 PM
Unknown Object (File)
Dec 11 2023, 2:55 PM
Unknown Object (File)
Dec 11 2023, 8:55 AM
Subscribers
None

Details

Summary

security/py-crits must use django v1.6 and will not work with v1.8
Two dependencies bring in www/py-django so I have created two new slave ports which
use www/py-django16

  • devel/py-django-tastypie-mongoengine allowed you to select django 1.6 or 1.8 in the options It now uses only 1.8
  • add slave port devel/py-django16-tastypie-mongoengine which uses django 1.6
  • www/py-django-tastypie now sets RUN_DEPENDS only if not already set
  • add slave www/py-django16-tastypie which uses django 1.6
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dvl retitled this revision from to Make security/py-crits use www/py-django16.
dvl updated this object.
dvl edited the test plan for this revision. (Show Details)
dvl added reviewers: wg, mat.
wg edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2015, 9:25 PM

I forgot to update the Makefiles.

dvl edited edge metadata.

Update www and devel Makefiles for new ports

This revision now requires review to proceed.Jun 29 2015, 12:31 AM

I was about to do this all as one commit, but that would rob the new ports of a 'Add X, insert description here' first commit.

In D2913#57255, @dvl wrote:

I was about to do this all as one commit, but that would rob the new ports of a 'Add X, insert description here' first commit.

It's not really a new port, it's a subport, (which I think should be added using svn copy py-django-tastypie-mongoengine py-django16-tastypie-mongoengine and svn cp www/py-django-tastypie www/py-django16-tastypie removing the unneeded files), and if all this change is a whole, then it should go in as one commit.

www/py-django-tastypie/Makefile
18 ↗(On Diff #6530)

This is wrong, do not do that, it will not do what you think it will. If you need to assign the same thing to BUILD_DEPENDS and RUN_DEPENDS, create another variable and assign it to both (as per 5.8.2 of the Porter's Handbook)

www/py-django16-tastypie/Makefile
12 ↗(On Diff #6530)

Same here, do not assign BUILD_DEPENDS to RUN_DEPENDS, ever.

dvl edited edge metadata.
  • do a better RUN_DEPENDS
  • specify the correct package names
dvl marked 2 inline comments as done.Jun 29 2015, 1:36 PM
dvl added inline comments.
security/py-crits/Makefile
50 ↗(On Diff #6544)

Fixed the package name...

Mmm, it really should have the same package name and directory name, django16-tastypie -> django-tastypie16 is not really good. django16-tastypie makes more sense as 16 is related to django, I don't know how the python ports bits work in order to achieve that though.

mat edited edge metadata.

Check that it works, and commit :-)

This revision is now accepted and ready to land.Jun 30 2015, 1:56 PM
In D2913#57394, @mat wrote:

Mmm, it really should have the same package name and directory name, django16-tastypie -> django-tastypie16 is not really good. django16-tastypie makes more sense as 16 is related to django, I don't know how the python ports bits work in order to achieve that though.

After discussion on IRC, decided to proceed with this as is, then work on getting DEFAULT_VERSIONS implemented for django, which will fix this problem without using slave ports. The port directory != package name issue then disappears.

This revision was automatically updated to reflect the committed changes.