Page MenuHomeFreeBSD
Differential D1167

Add django bootstrap forms. (branch: py-django-bootstrap-forms_rebase)
ClosedPublic
Actions

Authored by alfred on Nov 15 2014, 7:56 AM.
Tags
None
Referenced Files
F133227510: D1167.id.diff
Fri, Oct 24, 3:40 AM
Unknown Object (File)
Fri, Oct 17, 5:24 AM
Unknown Object (File)
Wed, Oct 15, 6:19 AM
Unknown Object (File)
Mon, Oct 13, 12:52 PM
Unknown Object (File)
Sat, Oct 11, 5:13 AM
Unknown Object (File)
Fri, Oct 10, 11:39 PM
Unknown Object (File)
Thu, Oct 9, 11:13 AM
Unknown Object (File)
Mon, Oct 6, 12:23 AM
View All Files
Subscribers
koobs
mva
sbz
wg
Python

Details

Reviewers
mva
sbz
koobs
wg
Group Reviewers
Python
Commits
rP401084: new port: django bootstrap forms

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alfred updated this revision to Diff 2416.Nov 15 2014, 7:56 AM
alfred retitled this revision from to Add django bootstrap forms..
alfred updated this object.
alfred edited the test plan for this revision. (Show Details)
alfred added a reviewer: Python.Nov 15 2014, 7:56 AM
alfred added a subscriber: Python.Nov 15 2014, 8:05 AM
mva requested changes to this revision.Nov 20 2014, 11:35 AM
mva added a reviewer: mva.
mva added a subscriber: mva.
mva added inline comments.
www/py-django-bootstrap-form/Makefile
6 ↗(On Diff #2416)

Wrong categories. This should start with www.

15 ↗(On Diff #2416)

Use the new USES=python syntax instead.

20 ↗(On Diff #2416)

Unstaged ports are not allowed anymore.

21 ↗(On Diff #2416)

Superfluous include

www/py-django-bootstrap-form/pkg-descr
1 ↗(On Diff #2416)

This pkg-descr does not seem to belong to the port.

This revision now requires changes to proceed.Nov 20 2014, 11:35 AM
alfred updated this revision to Diff 2494.Nov 21 2014, 4:57 PM
alfred edited edge metadata.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
wg accepted this revision.Nov 21 2014, 5:01 PM
wg added a reviewer: wg.
wg added a subscriber: wg.

lgtm

mva added a comment.Nov 21 2014, 5:59 PM

Does not it need django as well?

koobs added a subscriber: koobs.Dec 2 2014, 9:14 AM
In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

koobs requested changes to this revision.Dec 2 2014, 9:14 AM
koobs added a reviewer: koobs.
In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

This revision now requires changes to proceed.Dec 2 2014, 9:14 AM
alfred updated this revision to Diff 3610.Feb 3 2015, 4:26 PM
alfred edited edge metadata.
  • Add django bootstrap forms.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
  • Add django as rundepends
alfred added a comment.Feb 3 2015, 4:27 PM
In D1167#18, @koobs wrote:
In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

OK that is now done.

alfred retitled this revision from Add django bootstrap forms. to Add django bootstrap forms. (branch: py-django-bootstrap-forms_rebase).Feb 3 2015, 4:50 PM
alfred edited edge metadata.
koobs requested changes to this revision.Mar 11 2015, 11:14 AM
koobs edited edge metadata.

Additionally (to inline comments), the python package has test_suite defined in it's setup.py file. [1]. That means the 'pythonX.Y setup.py test' command will run the test suite.

This output is great for QA. Add it here if you can.

[1] https://github.com/tzangms/django-bootstrap-form/blob/master/setup.py#L24

www/py-django-bootstrap-form/Makefile
11 ↗(On Diff #3610)

I'd capitalise Django

16 ↗(On Diff #3610)

Sort these values by alpha

18 ↗(On Diff #3610)

Only = is needed here.

18 ↗(On Diff #3610)

Match upstream dependencies as closely as possible:

setup.py says django>=1.3 [1]

[1] https://github.com/tzangms/django-bootstrap-form/blob/master/setup.py#L26

This revision now requires changes to proceed.Mar 11 2015, 11:14 AM
alfred updated this revision to Diff 9151.Oct 4 2015, 11:10 PM
alfred edited edge metadata.
alfred marked an inline comment as done.
  • Add django bootstrap forms.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
  • sort USE_PYTHON, fix RUN_DEPENDS & COMMENT caps
  • Update to latest version
alfred added a comment.Oct 4 2015, 11:11 PM

Ok, this is ready for another review. Thank you all.

www/py-django-bootstrap-form/pkg-descr
2 ↗(On Diff #9151)

It does... why do you think so?

sbz added a subscriber: sbz.Nov 4 2015, 12:38 AM

According to your last changes

lgtm

sbz accepted this revision.Nov 4 2015, 12:39 AM
sbz added a reviewer: sbz.
Closed by commit rP401084: new port: django bootstrap forms (authored by alfred). · Explain WhyNov 9 2015, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
www/
1 line
py-django-bootstrap-form/
21 lines
2 lines
6 lines

Diff 10052

View Options

head/www/Makefile

Loading...
View Options

head/www/py-django-bootstrap-form/Makefile

Loading...
View Options

head/www/py-django-bootstrap-form/distinfo

Loading...
View Options

head/www/py-django-bootstrap-form/pkg-descr

Loading...