Page MenuHomeFreeBSD

Add django bootstrap forms. (branch: py-django-bootstrap-forms_rebase)
ClosedPublic

Authored by alfred on Nov 15 2014, 7:56 AM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

alfred retitled this revision from to Add django bootstrap forms..
alfred updated this object.
alfred edited the test plan for this revision. (Show Details)
mva requested changes to this revision.Nov 20 2014, 11:35 AM
mva added a reviewer: mva.
mva added a subscriber: mva.
mva added inline comments.
www/py-django-bootstrap-form/Makefile
6

Wrong categories. This should start with www.

15

Use the new USES=python syntax instead.

20

Unstaged ports are not allowed anymore.

21

Superfluous include

www/py-django-bootstrap-form/pkg-descr
1

This pkg-descr does not seem to belong to the port.

This revision now requires changes to proceed.Nov 20 2014, 11:35 AM
alfred edited edge metadata.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
wg added a reviewer: wg.
wg added a subscriber: wg.

lgtm

Does not it need django as well?

In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

koobs requested changes to this revision.Dec 2 2014, 9:14 AM
koobs added a reviewer: koobs.
In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

This revision now requires changes to proceed.Dec 2 2014, 9:14 AM
alfred edited edge metadata.
  • Add django bootstrap forms.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
  • Add django as rundepends
In D1167#18, @koobs wrote:
In D1167#15, @mva wrote:

Does not it need django as well?

Yes it does :)

OK that is now done.

alfred retitled this revision from Add django bootstrap forms. to Add django bootstrap forms. (branch: py-django-bootstrap-forms_rebase).Feb 3 2015, 4:50 PM
alfred edited edge metadata.
koobs requested changes to this revision.Mar 11 2015, 11:14 AM
koobs edited edge metadata.

Additionally (to inline comments), the python package has test_suite defined in it's setup.py file. [1]. That means the 'pythonX.Y setup.py test' command will run the test suite.

This output is great for QA. Add it here if you can.

[1] https://github.com/tzangms/django-bootstrap-form/blob/master/setup.py#L24

www/py-django-bootstrap-form/Makefile
11

I'd capitalise Django

16

Sort these values by alpha

18

Only = is needed here.

18

Match upstream dependencies as closely as possible:

setup.py says django>=1.3 [1]

[1] https://github.com/tzangms/django-bootstrap-form/blob/master/setup.py#L26

This revision now requires changes to proceed.Mar 11 2015, 11:14 AM
alfred edited edge metadata.
alfred marked an inline comment as done.
  • Add django bootstrap forms.
  • D1167#4 - fix category to www
  • D1167#4 - new USES syntax, NO_STAGE not needed.
  • D1167#4 - Make pkg-descr reflect the actual package.
  • sort USE_PYTHON, fix RUN_DEPENDS & COMMENT caps
  • Update to latest version

Ok, this is ready for another review. Thank you all.

www/py-django-bootstrap-form/pkg-descr
2

It does... why do you think so?

According to your last changes

lgtm

sbz added a reviewer: sbz.
This revision was automatically updated to reflect the committed changes.