Page MenuHomeFreeBSD
Feed Advanced Search

Jan 16 2019

glebius committed rS343100: Do not reserve KVA for paging bufs in vm_ksubmap_init(), since now.
Do not reserve KVA for paging bufs in vm_ksubmap_init(), since now
Jan 16 2019, 8:14 PM
glebius committed rS343080: Whitespace..
Whitespace.
Jan 16 2019, 4:02 AM

Jan 15 2019

glebius committed rS343058: Fix compilation failures on different arches that have vm_machdep.c not.
Fix compilation failures on different arches that have vm_machdep.c not
Jan 15 2019, 7:34 PM
glebius committed rS343055: style(9): break long line..
style(9): break long line.
Jan 15 2019, 6:50 PM
glebius committed rS343054: Remove harmless leftover from code that cycles over zone's kegs. Just use +.
Remove harmless leftover from code that cycles over zone's kegs. Just use +
Jan 15 2019, 6:49 PM
glebius committed rS343053: This was missed in r343051: make uz_allocs, uz_frees and uz_fails counter(9)..
This was missed in r343051: make uz_allocs, uz_frees and uz_fails counter(9).
Jan 15 2019, 6:47 PM
glebius committed rS343052: Only do uz_items accounting for zones that have a limit set in uz_max_items..
Only do uz_items accounting for zones that have a limit set in uz_max_items.
Jan 15 2019, 6:32 PM
glebius committed rS343051: Make uz_allocs, uz_frees and uz_fails counter(9). This removes some.
Make uz_allocs, uz_frees and uz_fails counter(9). This removes some
Jan 15 2019, 6:24 PM
glebius committed rS343037: Fix compilation on 32-bit..
Fix compilation on 32-bit.
Jan 15 2019, 3:44 AM
glebius committed rS343031: Remove pbuf(9) manual page that is now nearly 100% outdated..
Remove pbuf(9) manual page that is now nearly 100% outdated.
Jan 15 2019, 1:19 AM
glebius committed rS343030: Allocate pager bufs from UMA instead of 80-ish mutex protected linked list..
Allocate pager bufs from UMA instead of 80-ish mutex protected linked list.
Jan 15 2019, 1:02 AM
glebius committed rS343027: Add flag LK_NEW for lockinit() that is converted to LO_NEW and passed.
Add flag LK_NEW for lockinit() that is converted to LO_NEW and passed
Jan 15 2019, 12:35 AM
glebius committed rS343026: o Move zone limit from keg level up to zone level. This means that now.
o Move zone limit from keg level up to zone level. This means that now
Jan 15 2019, 12:02 AM
glebius closed D17773: UMA limits in zone & more.
Jan 15 2019, 12:02 AM

Jan 14 2019

glebius added inline comments to D17773: UMA limits in zone & more.
Jan 14 2019, 11:42 PM

Jan 11 2019

glebius committed rS342923: Remove recursive NET_EPOCH_ENTER() from sysctl_ifmalist(), missed in r342872..
Remove recursive NET_EPOCH_ENTER() from sysctl_ifmalist(), missed in r342872.
Jan 11 2019, 12:45 AM

Jan 10 2019

glebius committed rS342922: Remove support for FreeBSD 9 kernel, which used to change byte order.
Remove support for FreeBSD 9 kernel, which used to change byte order
Jan 10 2019, 11:27 PM
glebius committed rS342907: Remove unnecessary ifdef. With INVARIANTS all KASSERTs are empty statements,.
Remove unnecessary ifdef. With INVARIANTS all KASSERTs are empty statements,
Jan 10 2019, 12:52 AM
glebius committed rS342906: Bring the comment up to date..
Bring the comment up to date.
Jan 10 2019, 12:37 AM
glebius committed rS342905: Simplify sosetopt() so that function has single return point. No.
Simplify sosetopt() so that function has single return point. No
Jan 10 2019, 12:25 AM

Jan 9 2019

glebius committed rS342877: Timer interval is correctly counted in ticks (1/100 s) in.
Timer interval is correctly counted in ticks (1/100 s) in
Jan 9 2019, 5:54 AM
glebius committed rS342872: Mechanical cleanup of epoch(9) usage in network stack..
Mechanical cleanup of epoch(9) usage in network stack.
Jan 9 2019, 1:11 AM
glebius committed rS342870: Remove part of comment that doesn't match reality..
Remove part of comment that doesn't match reality.
Jan 9 2019, 12:38 AM

Jan 8 2019

glebius committed rP489747: Remove patch that I missed to add to commit index in r489641..
Remove patch that I missed to add to commit index in r489641.
Jan 8 2019, 11:35 PM
glebius committed rP489641: Upgrade minidlna to current snapshot in my repo..
Upgrade minidlna to current snapshot in my repo.
Jan 8 2019, 4:15 AM

Jan 7 2019

glebius committed rS342854: Fix regression in r331368, that broke dumping of UMA startup pages.
Fix regression in r331368, that broke dumping of UMA startup pages
Jan 7 2019, 11:17 PM

Dec 18 2018

glebius committed rS342197: Use mbufq instead of ifqueue to queue mbufs..
Use mbufq instead of ifqueue to queue mbufs.
Dec 18 2018, 7:38 PM

Dec 14 2018

glebius added inline comments to D17773: UMA limits in zone & more.
Dec 14 2018, 9:01 PM

Dec 13 2018

glebius accepted D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.

I would like to see a generic code in netgraph that marks hooks with DLT. So, no special messages to be needed, nodes will autosense what's connected to them. However, this is just a wish not a blocker for this change.

Dec 13 2018, 6:55 PM · network
glebius added inline comments to D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.
Dec 13 2018, 6:55 PM · network

Dec 7 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move the sleep into zone_alloc_item_locked() and put it into a loop.
Dec 7 2018, 11:04 PM
glebius added a comment to D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.

As said, I'm not seeking for a review & approval so that I commit it. I'm not a ports committer. I'm seeking for a person who can finalize this ugly patch and commit. Thanks!

Dec 7 2018, 10:27 PM

Dec 5 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Rewrite uma_zalloc_arg() so that there is a single sleeping point.
Dec 5 2018, 11:39 PM

Dec 4 2018

glebius accepted D17803: Clamp porthash_max to IPPORT_MAX..
Dec 4 2018, 10:08 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 4 2018, 12:37 AM
glebius updated the diff for D17773: UMA limits in zone & more.
  • Improve comment on why uk_lock needs to be first.
Dec 4 2018, 12:26 AM
glebius removed 1 blocking reviewer(s) for D18426: USE_SOURCEFORGE and first port to use it - net/minidlna: portmgr.
Dec 4 2018, 12:23 AM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 4 2018, 12:23 AM
glebius created D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.
Dec 4 2018, 12:19 AM

Dec 3 2018

glebius updated the diff for D17773: UMA limits in zone & more.

Address Mark's review.

Dec 3 2018, 11:50 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 3 2018, 11:19 PM

Nov 28 2018

glebius accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Nov 28 2018, 8:08 PM
glebius committed rS341163: Fix yet another edge case in uma_startup_count(). If zone size fits into.
Fix yet another edge case in uma_startup_count(). If zone size fits into
Nov 28 2018, 7:54 PM
glebius committed rS341162: For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff.
For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff
Nov 28 2018, 7:20 PM

Nov 27 2018

glebius added inline comments to D17773: UMA limits in zone & more.
Nov 27 2018, 11:37 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Nov 27 2018, 11:12 PM

Nov 26 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move assertion to beginning of the function.
  • Remove unlock avoidance in uma_zfree_arg(). Can't remember why it was
Nov 26 2018, 9:32 PM
glebius accepted D17994: pfsync: Insert static trace points.

P.S. In pf itself, the dtrace probing should just substitute existing printf(9) debugging.

Nov 26 2018, 8:57 PM
glebius abandoned D1887: Generic code for mbuf(9) queues..

Committed years ago.

Nov 26 2018, 5:01 PM

Nov 14 2018

glebius updated the diff for D17773: UMA limits in zone & more.

Merge remote-tracking branch 'FreeBSD/master' into pbuf to take
in and resolve with recent D16666 check-in.

Nov 14 2018, 8:35 PM
glebius committed rS340443: Initialize compatibility epoch tracker for thread0. Fixes.
Initialize compatibility epoch tracker for thread0. Fixes
Nov 14 2018, 7:10 PM
glebius committed rS340423: Fix build on some architectures after r340413. On amd64 epoch.h.
Fix build on some architectures after r340413. On amd64 epoch.h
Nov 14 2018, 12:33 AM

Nov 13 2018

glebius committed rS340419: style(9), mostly adjusting overly long lines..
style(9), mostly adjusting overly long lines.
Nov 13 2018, 11:57 PM
glebius committed rS340417: With epoch not inlined, there is no point in using _lite KPI. While here,.
With epoch not inlined, there is no point in using _lite KPI. While here,
Nov 13 2018, 11:45 PM
glebius committed rS340416: Plug build break after r340411..
Plug build break after r340411.
Nov 13 2018, 11:44 PM
glebius committed rS340415: The dualism between epoch_tracker and epoch_thread is fragile and.
The dualism between epoch_tracker and epoch_thread is fragile and
Nov 13 2018, 11:21 PM
glebius committed rS340413: For compatibility KPI functions like if_addr_rlock() that used to have.
For compatibility KPI functions like if_addr_rlock() that used to have
Nov 13 2018, 10:58 PM
glebius committed rS340404: Uninline epoch(9) entrance and exit. There is no proof that modern.
Uninline epoch(9) entrance and exit. There is no proof that modern
Nov 13 2018, 7:02 PM
glebius closed D17879: First part of D17787:.
Nov 13 2018, 7:02 PM
glebius accepted D17922: More IPv4 fragment checks.
Nov 13 2018, 12:36 AM

Nov 7 2018

glebius added inline comments to D17879: First part of D17787:.
Nov 7 2018, 9:23 PM

Nov 6 2018

glebius created D17879: First part of D17787:.
Nov 6 2018, 11:17 PM

Oct 31 2018

glebius committed rS339976: MFhead r339643:.
MFhead r339643:
Oct 31 2018, 11:06 PM
glebius committed rS339975: MFhead r339643:.
MFhead r339643:
Oct 31 2018, 11:03 PM
glebius created D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In....
Oct 31 2018, 10:55 PM
glebius committed rS339970: Remove unnecessary include from libstand..
Remove unnecessary include from libstand.
Oct 31 2018, 7:59 PM
glebius committed rS339969: Define QMD_SAVELINK() only for QUEUE_MACRO_DEBUG_TRASH case. Otherwise.
Define QMD_SAVELINK() only for QUEUE_MACRO_DEBUG_TRASH case. Otherwise
Oct 31 2018, 7:37 PM
glebius committed rS339963: MFhead r339596:.
MFhead r339596:
Oct 31 2018, 6:01 PM

Oct 30 2018

glebius created D17773: UMA limits in zone & more.
Oct 30 2018, 11:56 PM
glebius added a comment to D16666: Add some accounting to the per-domain full bucket caches..

My current patchset for UMA has something similar. I also have zone_put_bucket() although named differently, to keep accounting of all items for a zone in buckets. So this change goes in line with my changes. At Netflix we also run the vm_page_cache zone with certain bucket limit, instead of no buckets at all.

Oct 30 2018, 8:16 PM
glebius added a comment to D17505: pfsync: Allow module to be unloaded.

I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

Oct 30 2018, 8:05 PM
glebius accepted D17502: pfsync: Handle syncdev going away.
Oct 30 2018, 8:02 PM
glebius requested changes to D16769: Remove AppleTalk protocols from services(5).

Doesn't make sense to remove it from services(5) database. It isn't a database of protocols FreeBSD supports. It is just database of port numbers that are well known.

Oct 30 2018, 7:59 PM
glebius requested changes to D17665: Ensure mbuf send tags don't trigger on ifnets.

This is extremely hacky. The only proper fix is to find situations when rcvif isn't cleared for a packet that is reused for transmit and fix them.

Oct 30 2018, 7:56 PM

Oct 29 2018

glebius committed rS339889: Add a note that epoch(9) may change, to untie our hands for any future MFCs..
Add a note that epoch(9) may change, to untie our hands for any future MFCs.
Oct 29 2018, 10:11 PM

Oct 24 2018

glebius committed rS339695: Remove code that is dead since r287197. Today wlan(4) interfaces aren't.
Remove code that is dead since r287197. Today wlan(4) interfaces aren't
Oct 24 2018, 8:50 PM

Oct 23 2018

glebius committed rS339643: Fix ipw_start(), where logic was reverted in r287197..
Fix ipw_start(), where logic was reverted in r287197.
Oct 23 2018, 12:53 PM

Oct 22 2018

glebius committed rS339596: If we lost race or were migrated during bucket allocation for the per-CPU.
If we lost race or were migrated during bucket allocation for the per-CPU
Oct 22 2018, 3:48 PM

Oct 21 2018

glebius committed rS339532: Fix exiting an epoch(9) we never entered. May happen only with MAC..
Fix exiting an epoch(9) we never entered. May happen only with MAC.
Oct 21 2018, 12:39 PM

Oct 18 2018

glebius accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 6:18 PM
glebius added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

syncache_chkrst() isn't a public function, so no worries on KBI.

Oct 18 2018, 6:14 PM

Oct 16 2018

glebius committed rS339379: Plug sendfile(2) on a listening socket with proper error code..
Plug sendfile(2) on a listening socket with proper error code.
Oct 16 2018, 3:57 PM

Oct 15 2018

glebius committed rS339370: Avoid OOB reads in memmem(3)..
Avoid OOB reads in memmem(3).
Oct 15 2018, 8:21 PM

Oct 3 2018

glebius committed rS339170: In PR 227259, a user is reporting that they have code which is using.
In PR 227259, a user is reporting that they have code which is using
Oct 3 2018, 5:40 PM
glebius closed D15019: Wakup applications with shutdown on listen sockets.
Oct 3 2018, 5:40 PM

Sep 6 2018

glebius added a comment to D17062: Cleanup unused inpcb fields/flags.

Since struct inpcb is no longer exported to the userland, the spare field can be removed.

Sep 6 2018, 11:29 PM

Aug 31 2018

glebius committed rP478606: Unbreak nVidia drivers on recent -CURRENT, after change to.
Unbreak nVidia drivers on recent -CURRENT, after change to
Aug 31 2018, 7:45 PM

Aug 24 2018

glebius committed rS338302: Either "free" or "allocated" is misleading here, since an item.
Either "free" or "allocated" is misleading here, since an item
Aug 24 2018, 6:48 PM

Aug 23 2018

glebius committed rS338284: Fix comment. The actual meaning of ub_cnt is the opposite..
Fix comment. The actual meaning of ub_cnt is the opposite.
Aug 23 2018, 11:24 PM

Aug 21 2018

glebius committed rP477761: Unbreak nVidia drivers on recent -CURRENT, after change to.
Unbreak nVidia drivers on recent -CURRENT, after change to
Aug 21 2018, 10:59 PM

Aug 4 2018

glebius committed rS337279: Now that after r335979 the kernel addresses in API structures are.
Now that after r335979 the kernel addresses in API structures are
Aug 4 2018, 12:03 AM

Aug 3 2018

glebius committed rS337278: Use if_tunnel_check_nesting() for ng_iface(4)..
Use if_tunnel_check_nesting() for ng_iface(4).
Aug 3 2018, 10:56 PM

Jun 27 2018

glebius committed rS335749: Check the inp_flags under inp lock. Looks like the race was hidden.
Check the inp_flags under inp lock. Looks like the race was hidden
Jun 27 2018, 10:02 PM
glebius committed rS335748: Correct r335242. Use unsigned cast instead of abs(). Using abs() gives.
Correct r335242. Use unsigned cast instead of abs(). Using abs() gives
Jun 27 2018, 10:01 PM

Jun 23 2018

glebius committed rS335577: Revert r334843, and partially revert r335180..
Revert r334843, and partially revert r335180.
Jun 23 2018, 6:54 AM

Jun 15 2018

glebius committed rS335242: Since 'ticks' is an int, it may wrap around and cr_ticks at a certain.
Since 'ticks' is an int, it may wrap around and cr_ticks at a certain
Jun 15 2018, 9:36 PM

Jun 14 2018

glebius committed rS335180: TCPOUTFLAGS no longer exists since r334843..
TCPOUTFLAGS no longer exists since r334843.
Jun 14 2018, 10:25 PM

Jun 8 2018

glebius committed rS334819: UMA memory debugging enabled with INVARIANTS consists of two things:.
UMA memory debugging enabled with INVARIANTS consists of two things:
Jun 8 2018, 12:15 AM
glebius closed D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.
Jun 8 2018, 12:15 AM

Jun 7 2018

glebius committed rS334817: Add new functionality and syntax to cron(1) to allow to run jobs at a.
Add new functionality and syntax to cron(1) to allow to run jobs at a
Jun 7 2018, 10:38 PM