Page MenuHomeFreeBSD

Clamp porthash_max to IPPORT_MAX.
ClosedPublic

Authored by markj on Nov 1 2018, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 5:05 PM
Unknown Object (File)
Sat, Sep 20, 3:41 AM
Unknown Object (File)
Sep 14 2025, 11:59 AM
Unknown Object (File)
Sep 11 2025, 3:32 PM
Unknown Object (File)
Aug 30 2025, 2:58 AM
Unknown Object (File)
Aug 30 2025, 1:40 AM
Unknown Object (File)
Aug 30 2025, 1:39 AM
Unknown Object (File)
Aug 29 2025, 8:42 PM
Subscribers

Details

Summary

The port hash function is just (lport & mask), so it makes no sense to
permit more than IPPORT_MAX hash table entries. On larger-memory
systems this just ends up wasting memory.

Also change the lbgroup hash table size to porthash_max, since it uses
the lport as a hash.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Fix an off-by-one.
  • Retire INP_PCBLBGROUP_PORTHASH. It's identical to INP_PCBPORTHASH, and because we now size the hash tables accurately, it would be nice to consistently use the same port hash everywhere.
This revision is now accepted and ready to land.Dec 4 2018, 10:08 PM
This revision was automatically updated to reflect the committed changes.