Page MenuHomeFreeBSD

USE_SOURCEFORGE and first port to use it - net/minidlna
Needs ReviewPublic

Authored by glebius on Tue, Dec 4, 12:17 AM.

Details

Reviewers
krion
sunpoet
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Just like with github, sometimes it is desired to make a port
of a non-released code from sourceforge, specified by git tag.

Almost a year ago I have created a lot of improvements for minidlna
on FreeBSD, and they were accepted upstream, but after that the project
leader disappeared and looks like we aren't going to see a release
soon.

That's why I suggest to use a today's tip of minidlna git for the
port.

I know my patch to bsd.port.mk is rather ugly, but nevertheless
krion@ suggested me to post a review so that somebody can pick
that and finish.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21350
Build 20677: arc lint + arc unit

Event Timeline

glebius created this revision.Tue, Dec 4, 12:17 AM
glebius removed 1 blocking reviewer(s): portmgr.Tue, Dec 4, 12:21 AM
mat added inline comments.Thu, Dec 6, 3:52 PM
Mk/bsd.sites.mk
1062–1063

You should probably use a new literal, SOURCEFORGE is already used, maybe SOURCEFORGE_GIT, and SFGIT.

1064

This looks like a bad idea, it would probably be better to make it more like USE_GITHUB and create the full URL in one go.

1066

Does it not support tar.gz?

net/minidlna/Makefile
9–10

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

sunpoet added inline comments.Thu, Dec 6, 4:59 PM
Mk/bsd.sites.mk
1059

Shouldn't it be optional since it defaults to PORTNAME?

1064

Regarding the URL, it seems we should use SF_PROJECT instead of PORTNAME here.

1066

I tried to download a snapshot from SF and it's a zip file.

As said, I'm not seeking for a review & approval so that I commit it. I'm not a ports committer. I'm seeking for a person who can finalize this ugly patch and commit. Thanks!