- Uninline epoch(9) entrance and exit. There is no proof that modern processors would benefit from avoiding a call, but bloating code. In fact, clang created an uninlined real function for many object files in the network stack.
- Remove private copies of critical_enter/exit.
- Move epoch_private.h into subr_epoch.c.
There is no functional change.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/kern/subr_epoch.c | ||
---|---|---|
245 ↗ | (On Diff #50095) | I totally agree. But this is exact what was taken from epoch_private.h. Per mmacy@'s request I'm splitting the bigger change in small once. This just uninlines stuff. |
256 ↗ | (On Diff #50095) | Same answer. To be addressed in next commits. |
321 ↗ | (On Diff #50095) | Agreed. Taken from another file as is. To be cleaned up later. |