First part of D17787:
ClosedPublic
Actions

Authored by glebius on Nov 6 2018, 11:17 PM.

Details

Reviewers

Commits

Summary

Uninline epoch(9) entrance and exit. There is no proof that modern processors would benefit from avoiding a call, but bloating code. In fact, clang created an uninlined real function for many object files in the network stack.
Remove private copies of critical_enter/exit.
Move epoch_private.h into subr_epoch.c.

There is no functional change.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

kib added inline comments.Nov 7 2018, 3:35 AM

sys/kern/subr_epoch.c
245 ↗	(On Diff #50095)	IMO thi sis an obfuscation.
256 ↗	(On Diff #50095)	Why using thread_lite and sched_pin_lite in a .c file, esp. when proc.h is already included ?
321 ↗	(On Diff #50095)	Wrong indent.

glebius marked 3 inline comments as done.Nov 7 2018, 9:23 PM

glebius added inline comments.

sys/kern/subr_epoch.c
245 ↗	(On Diff #50095)	I totally agree. But this is exact what was taken from epoch_private.h. Per mmacy@'s request I'm splitting the bigger change in small once. This just uninlines stuff.
256 ↗	(On Diff #50095)	Same answer. To be addressed in next commits.
321 ↗	(On Diff #50095)	Agreed. Taken from another file as is. To be cleaned up later.