Diffusion FreeBSD src repository - subversion rS342872

Mechanical cleanup of epoch(9) usage in network stack.
rS342872
Actions

Description

Mechanical cleanup of epoch(9) usage in network stack.

Remove macros that covertly create epoch_tracker on thread stack. Such macros a quite unsafe, e.g. will produce a buggy code if same macro is used in embedded scopes. Explicitly declare epoch_tracker always.

Unmask interface list IFNET_RLOCK_NOSLEEP(), interface address list IF_ADDR_RLOCK() and interface AF specific data IF_AFDATA_RLOCK() read locking macros to what they actually are - the net_epoch. Keeping them as is is very misleading. They all are named FOO_RLOCK(), while they no longer have lock semantics. Now they allow recursion and what's more important they now no longer guarantee protection against their companion WLOCK macros. Note: INP_HASH_RLOCK() has same problems, but not touched by this commit.

This is non functional mechanical change. The only functionally changed
functions are ni6_addrs() and ni6_store_addrs(), where we no longer enter
epoch recursively.

Mechanical cleanup of epoch(9) usage in network stack.rS342872Actions

Description

Details

Event Timeline

Changes (40)

rS342872

head/sys/compat/linuxkpi/common/include/linux/inetdevice.h

head/sys/dev/wtap/if_wtap.c

head/sys/net/altq/altq_subr.c

head/sys/net/bridgestp.c

head/sys/net/if.c

head/sys/net/if_llatbl.c

head/sys/net/if_var.h

head/sys/net/if_vlan.c

head/sys/net/route.c

head/sys/net/rtsock.c

head/sys/netinet/if_ether.c

head/sys/netinet/igmp.c

head/sys/netinet/in.c

head/sys/netinet/in_mcast.c

head/sys/netinet/in_pcb.c

head/sys/netinet/in_pcb.h

head/sys/netinet/ip_carp.c

head/sys/netinet/ip_divert.c

head/sys/netinet/ip_icmp.c

head/sys/netinet/ip_input.c

head/sys/netinet/ip_mroute.c

head/sys/netinet/ip_options.c

head/sys/netinet/ip_output.c

head/sys/netinet/netdump/netdump_client.c

head/sys/netinet/sctp_bsd_addr.c

head/sys/netinet6/icmp6.c

head/sys/netinet6/in6.c

head/sys/netinet6/in6_ifattach.c

head/sys/netinet6/in6_mcast.c

head/sys/netinet6/in6_pcb.c

head/sys/netinet6/in6_var.h

head/sys/netinet6/mld6.c

head/sys/netinet6/nd6.c

head/sys/netinet6/nd6_nbr.c

head/sys/netinet6/nd6_rtr.c

head/sys/netinet6/raw_ip6.c

head/sys/netinet6/scope6.c

head/sys/netpfil/pf/pf_if.c

head/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Mechanical cleanup of epoch(9) usage in network stack.
rS342872
Actions