okay, I'll take care of this.

In D26833#598620, @freqlabs wrote:

The page fault in t4_get_lb_stats with my T580-LP-SO-CR was fun.

I don't see any change in behavior. My test setup has a T6 card and cxgbe(4) is loaded. Then I run

Thanks for the review, kib@.

Serial all VXLAN start/stops (even across different VXLAN interfaces).

Add a global sx and hold it around the VXLAN start/stop events.

Remove debug leftovers.

And the refcount underflow check is for the case where a VXLAN is created/started before the NIC driver is kldloaded. It will miss the create/start event but will see the destroy/stop and get confused. The real fix would be to have a count of VXLAN interfaces somewhere and have the driver seed its initial refcount with this value. But if_vxlan itself is a loadable module so this counter would have to be in the kernel proper, or else there would have to be a query function in if_vxlan that is called indirectly (like the vlan functions). I thought all this was too complicated for an unusual case. If users make sure all NIC drivers are loaded before creating VXLANs then there is no problem with missed events.

In D25873#579567, @kib wrote:

This patch naturally splits into many chunks, for instance RFC7348 port, inner checksums infra, events, driver bits. Do you plan to do more fine-grained commits that one big ci ?

incorporate some feedback from kib@

Tx counters that track hw assistance should consider all inner traffic
irrespective of the IP version of the outer encapsulation.

Handle rxcsum and rxcsum6 correctly.