Page MenuHomeFreeBSD

Store the send tag type in the common send tag header.
ClosedPublic

Authored by jhb on Oct 5 2020, 9:16 PM.
Tags
None
Referenced Files
F169263038: D26689.id78225.diff
Tue, Sep 1, 2:21 AM
F169199964: D26689.id.diff
Mon, Aug 31, 7:29 PM
F169170156: D26689.id.diff
Mon, Aug 31, 4:30 PM
Unknown Object (File)
Sun, Aug 30, 11:28 AM
Unknown Object (File)
Sat, Aug 29, 4:24 PM
Unknown Object (File)
Wed, Aug 26, 7:28 PM
Unknown Object (File)
Wed, Aug 26, 5:09 PM
Unknown Object (File)
Mon, Aug 17, 6:01 AM

Details

Summary

Both cxgbe(4) and mlx5(4) wrapped the existing send tag header with
their own identical headers that stored the type that the
type-specific tag structures inherited from, so in practice it seems
drivers need this in the tag anyway. This permits removing these
extra header indirections (struct cxgbe_snd_tag and struct
mlx5e_snd_tag).

In addition, this permits driver-independent code to query the type of
a tag, e.g. to know what type of tag is being queried via
if_snd_query.

Test Plan
  • tested NIC TLS on T6
  • Drew tested this as part of the TLS ratelimit patches

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable