Differential D26875

Save the current TCP pacing rate in t_pacing_rate.
ClosedPublic
Actions

Authored by jhb on Oct 19 2020, 10:20 PM.

Tags

None

Referenced Files

	F154018754: D26875.id78879.diff
	Sat, Apr 25, 12:21 PM

	F153963552: D26875.id78879.diff
	Sat, Apr 25, 3:31 AM

	Unknown Object (File)
	Thu, Apr 23, 9:51 PM

	Unknown Object (File)
	Mon, Apr 20, 10:11 AM

	Unknown Object (File)
	Thu, Apr 16, 11:42 AM

	Unknown Object (File)
	Wed, Apr 15, 6:33 PM

	Unknown Object (File)
	Wed, Apr 15, 2:21 PM

	Unknown Object (File)
	Wed, Apr 15, 7:49 AM

Subscribers

Details

Reviewers

gallatin
rrs
gnn

Group Reviewers

Commits

rS367122: Save the current TCP pacing rate in t_pacing_rate.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 19 2020, 10:20 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 19 2020, 10:20 PM

Herald added a subscriber: melifaro. · View Herald Transcript

Harbormaster completed remote builds in B34271: Diff 78476.Oct 19 2020, 10:20 PM

jhb requested review of this revision.Oct 19 2020, 10:20 PM

Having this around avoids the need to query an existing tag for a rate for TLS + rate limit tags. It also makes the race window where TLS can "miss" a rate change smaller.

One question I have is if we have to use -1 as the rate for unlimited, or if a rate value of 0 (which feels a bit more natural) would work ok? If 0 works, then I'd change this to a uint64_t.

jhb mentioned this in D26691: Support hardware rate limiting (pacing) with TLS offload..Oct 19 2020, 10:49 PM

gnn accepted this revision as: gnn.Oct 19 2020, 11:24 PM

gallatin accepted this revision.Oct 22 2020, 2:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2020, 12:03 AM

Closed by commit rS367122: Save the current TCP pacing rate in t_pacing_rate. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS367122: Save the current TCP pacing rate in t_pacing_rate..

Herald added a subscriber: imp. · View Herald TranscriptOct 29 2020, 12:03 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_ratelimit.c

9 lines

1 line

1 line

Diff 78879

head/sys/netinet/tcp_ratelimit.c

Loading...

head/sys/netinet/tcp_subr.c

Loading...

head/sys/netinet/tcp_var.h

Loading...