In D17955#421328, @yamori813_yahoo.co.jp wrote:My understand is sys/gnu/dts have only openwrt(opneled) dts files. And sys/dts have freebsd original dts files. MZK-W04N-XX.dts is my missing add dts file then move to freebsd dts directory. Do you think how to sync openwrt(opneled) dts files ?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 22 2019
Mar 22 2019
Mar 21 2019
Mar 21 2019
Please remove the dts file from this review. Let's import it with the rest of the dts/dtsi files in https://reviews.freebsd.org/D17955
Why was MZK-W04N-XX.dts moved to sys/dts instead of sys/gnu/dts ?
Feb 22 2019
Feb 22 2019
Nov 19 2018
Nov 19 2018
Fix access to cpu_model[] in mtk_soc_set_cpu_model()
Nov 16 2018
Nov 16 2018
Implement support for sysctl hw.model for Mediatek/Ralink SoCs
! In D18001#384940, @yamori813_yahoo.co.jp wrote:
OK I will delete Mediatek in this review.
! In D18001#384940, @yamori813_yahoo.co.jp wrote:
Mediatek soc is some time CPU print name and CHIPID is different. I have one that is CPU printed RT3050F but CHIPID is RT3350. I think Mediatek code need check SYSCTL_CHIPID0_3 and SYSCTL_CHIPID4_7. Sure thing first is CHIPID and second is FDT I believe.
Please split Mediatek and Atheros in separate reviews.
Dec 8 2017
Dec 8 2017
Oct 17 2017
Oct 17 2017
as far as if_rt changes and dts additions go, I am ok with this.
Jul 31 2017
Jul 31 2017
Feb 20 2017
Feb 20 2017
etherswitch: Fix RT305x vlan group operation
Feb 16 2017
Feb 16 2017
OK, v2 patch is here:
https://people.freebsd.org/~sgalabov/mtkswitch_v2.patch
In D9607#198883, @yamori813_yahoo.co.jp wrote:This is always false in patch.
tmp = v->es_untagged_ports & v->es_member_ports; /* fail if untagged members are not a subset of all members */ if (tmp != v->es_untagged_ports) {Because of all v->es_untagged_ports bits contain in v->es_member_ports.
Feb 15 2017
Feb 15 2017
Can you please test with the patch found at:
https://people.freebsd.org/~sgalabov/mtkswitch.patch
OK, one issue exists with the existing code:
- if more ports are configured as "untagged" than are configured as "untagged members" for the given VLAN the check would fail.
Can you explain the problem in a bit more detail?
The code you're suggesting to change (from memory) is intended to do the following:
- check which ports are configured to untag VLANs
- get the subset of VLAN member ports that are also untagged.
- compare the 2 values and if they match - go ahead; if they don't match - error out.
Feb 9 2017
Feb 9 2017
Set GDMA1 Frames Destination Port to Port 0 (CPU)
Feb 6 2017
Feb 6 2017
sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()
sgalabov retitled D9460: ARM: Use a 32-bit variable for control register instead of 8-bit from to ARM: Use a 32-bit variable for control register instead of 8-bit.
Jan 23 2017
Jan 23 2017
I would like to eventually get rid of all the ifdef's (where possible, of course) related to SoC type (e.g., if defined MT7620, etc).. unfortunately at the moment I have absolutely no bandwidth to start doing that, so I am ok with this for now.
Nov 7 2016
Nov 7 2016
Generate an error if machine/armreg.h is included without sys/cdefs.h
sgalabov updated the diff for D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
In D8460#175967, @andrew wrote:In D8460#175966, @andrew wrote:Can you try with rS308408. It might pay to add an error if this file is included but _MACHINE_ASM_H_ is undefined.
Even better would be _SYS_CDEFS_H_.
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
Any other comments on this? If it's ok with everyone I'd like to commit it...
Only include sys/boot.h if LINUX_BOOT_ABI is defined
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
Hmm, this is weird, it still fails the same way for me, although I am using the default gcc:
gcc version 4.2.1 20070831 patched [FreeBSD]
sgalabov added a comment to D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.
In D8459#175948, @meloun-miracle-cz wrote:Hmm, right.
Btw, which compiler you use? It seems that clang doesn't generate error for unused external variables...
sgalabov added a comment to D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.
Actual build failure message is:
/src/current.git/sys/sys/boot.h:40: warning: 'howto_names' defined but not used
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
All files, which report an issue of __ARM_ARCH not being defined (and include machine/armreg.h):
sys/arm/arm/cpufunc_asm_sheeva.S
sys/arm/arm/fiq_subr.S
sys/arm/arm/setstack.s
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
In D8460#175937, @meloun-miracle-cz wrote:Are you sure? Also for D8459? I'm able to compile actual SHEEVAPLUG kernel without any issue.
sgalabov added a comment to D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
In D8460#175936, @andrew wrote:When is it the case that __ARM_ARCH is undefined? machine/acle-compat.h is included from sys/cdefs.h so this should have already been included.
sgalabov retitled D8460: ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined from to ARM: include machine/acle-compat.h in armreg.h if __ARM_ARCH is not defined.
sgalabov retitled D8459: ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly from to ARM: Allow systems that do not define LINUX_BOOT_ABI to compile properly.
Sep 7 2016
Sep 7 2016
Fix MIPS INTRNG (both FDT and non-FDT) behaviour broken by r304459
Sep 5 2016
Sep 5 2016
Yes, I was planning to commit it on Wednesday if I get a chance, but wouldn't mind if someone else does it in the meantime...
Sep 1 2016
Sep 1 2016
In D7692#160754, @adrian wrote:(Eg, it needs a bunch more testing on non-FDT, non-INTRNG platforms, but I bet that's going to be easy..)
The updated diff also fixes additional problems seen on Broadcom MIPS (INTRNG without FDT) as a result of the r304459 changes. The new diff was boot tested by mizhka.
Aug 31 2016
Aug 31 2016
Provide more diff context
In D7692#160205, @adrian wrote:Hm, can you get someone who does FDT stuff on #bsdmips to look at this?
Aug 30 2016
Aug 30 2016
Previous diff was not compiling for BCM kernel config, as BCM only uses INTRNG but not FDT.
Rework the fix, so that cpu_establish_[hard|soft]intr uses a different intr mapping strategy, which doesn't require FDT-specific data to be exposed to non-FDT kernels.
Aug 29 2016
Aug 29 2016
sgalabov retitled D7692: MIPS: Fix cpu_establish_[hard|soft]intr() post r304459 from to MIPS: Fix cpu_establish_[hard|soft]intr() post r304459.
Jun 6 2016
Jun 6 2016
Remove erroneous lock assertions
May 25 2016
May 25 2016
Build etherswitch support for appropriate Ralink/Mediatek SoCs
Bring ralink/mediatek DTS files in sync with LEDE
Align radiotap structures in ral(4)
May 19 2016
May 19 2016
Ralink: Add more SoC compatible strings
May 18 2016
May 18 2016
sgalabov retitled D6432: Ralink: Add more SoC compatible strings from to Ralink: Add more SoC compatible strings.
May 17 2016
May 17 2016
Add proper PCIe init for MT7628/MT7688 SoCs
Import LEDE dts files for Ralink/Mediatek
Fix issues with mt762x etherswitch driver
May 16 2016
May 16 2016
update diff
update diffs
update diffs
sgalabov retitled D6395: Add proper PCIe init for MT7628/MT7688 SoCs from to Add proper PCIe init for MT7628/MT7688 SoCs.
sgalabov retitled D6394: Import LEDE dts files for Ralink/Mediatek from to Import LEDE dts files for Ralink/Mediatek.
sgalabov retitled D6393: Fix issues with mt762x etherswitch driver from to Fix issues with mt762x etherswitch driver.
Introduce basic etherswitch support for Ralink SoCs
May 14 2016
May 14 2016
Add MT7620/MT7621 first pass driver as well.
May 13 2016
May 13 2016
add copyright to *.h files.
sgalabov retitled D6348: Introduce basic etherswitch support for Ralink SoCs from to Introduce basic etherswitch support for Ralink SoCs.
May 6 2016
May 6 2016
mtk_spi cleanup commented printfs
sgalabov closed D6223: mtk_spi cleanup commented printfs by committing rS299155: mtk_spi cleanup commented printfs.
May 5 2016
May 5 2016
sgalabov retitled D6223: mtk_spi cleanup commented printfs from to mtk_spi cleanup commented printfs.
Apr 23 2016
Apr 23 2016
Remove uart_dev_mtk_ns8250
sgalabov closed D6044: Remove uart_dev_mtk_ns8250 by committing rS298501: Remove uart_dev_mtk_ns8250.
Reduce the FreeBSD specific DTS files for Mediatek/Ralink
Use cpu_establish_hardintr in mtk_intr_gic
Introduce palmbus for Mediatek/Ralink SoCs
Minor pinctrl fixes for Mediatek/Ralink
Apr 21 2016
Apr 21 2016
Update diffs to remove MT7621 GIC stuff as it will be unneeded after D6045.
sgalabov retitled D6045: Use cpu_establish_hardintr in mtk_intr_gic from to Use cpu_establish_hardintr in mtk_intr_gic.
Update diffs so MT7621 can be built
sgalabov retitled D6043: Reduce the FreeBSD specific DTS files for Mediatek/Ralink from to Reduce the FreeBSD specific DTS files for Mediatek/Ralink.
sgalabov retitled D6042: Introduce palmbus for Mediatek/Ralink SoCs from to Introduce palmbus for Mediatek/Ralink SoCs.
sgalabov retitled D6041: Minor pinctrl fixes for Mediatek/Ralink from to Minor pinctrl fixes for Mediatek/Ralink.
Rework Mediatek/Ralink configuration files