rebase

rebase

rebase

Rebase

Rebase

LGTM

To be merged in the MFC process of D30629

As far as I can check, all those changes are outside of the hold lock, so this is fine.

In D30566#689964, @hselasky wrote:

Just putting my comment here.

Creating a pthread and caching the time, might be a better solution, from my point of view.

In D30277#689947, @hselasky wrote:

In D30277#689937, @hselasky wrote:

The major part of processing time in libalias is gettimeofday(3).

I suggest you make a separate thread which sleeps 1 second and updates a local variable with the timestamp you want to use. That way, if the number of packets is low, you don't get any side effects.

Can for example use a static constructor function to create this thread, to make integration seamless.

In D30277#689937, @hselasky wrote:

The major part of processing time in libalias is gettimeofday(3).

I suggest you make a separate thread which sleeps 1 second and updates a local variable with the timestamp you want to use. That way, if the number of packets is low, you don't get any side effects.

Ping?

• Test too few or too many vlans

• Depends on D30699

LTGM

Rebase

Rebase

• Style fixes

• Style fixes

• Style source

• Factor out common routines.

• Add reverse tests, going the other direction reverses the rotation

• Rebased to D30657

• Either expect known problems not related to ng_brigde or pass if they are fixed.

• Add msg_handler in order to receive messages to util.
• Add tests for the amount of learned mac addresses.

• Test for uplink in classic mode

• Add tests for uplink in private vlan mode

• Differentiate the tests by receiving hook expectations

• Test learned unicast

• Add cleanup before test to deal with broken or interrupted tests

• Remove cleanup functions. Does not work as expected.

• rebase
• Fix spacing

Would it be a hard rework to use is_dnctl() instead of is_ipfw()?
The special case is the new link, the default case is ipfw.
Background: If we factor out other parts, too, the current approach is not scalable.

• Add root requirement for the test

• Add root requirements to the tests

In D30629#688115, @kp wrote:

Minor issue: these tests don't carry the metadata to show they must be run as root, so 'kyua test' fails.