Differential D30110

netgraph/ng_base: Renaming a node to the same name is a noop
ClosedPublic
Actions

Authored by donner on May 4 2021, 7:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 22, 1:59 AM

	Unknown Object (File)
	Sun, Oct 19, 3:19 AM

	Unknown Object (File)
	Sat, Oct 18, 4:25 PM

	Unknown Object (File)
	Thu, Oct 16, 8:14 PM

	Unknown Object (File)
	Wed, Oct 15, 5:43 AM

	Unknown Object (File)
	Sun, Oct 5, 12:30 AM

	Unknown Object (File)
	Aug 31 2025, 9:54 AM

	Unknown Object (File)
	Aug 25 2025, 1:00 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Commits

rGb57a593cb2d6: netgraph/ng_base: Renaming a node to the same name is a noop
rGa0694da5d035: netgraph/ng_base: Renaming a node to the same name is a noop
rG37370a6773cd: netgraph/ng_base: Renaming a node to the same name is a noop
rG0345fd891fe1: netgraph/ng_base: Renaming a node to the same name is a noop

Summary

Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move. Because the name of the node is already known
(occupied by itself), the second call fails.

PR: 241954
Reported by: Paul Armstrong
MFC: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

donner created this revision.May 4 2021, 7:27 PM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 4 2021, 7:27 PM

donner requested review of this revision.May 4 2021, 7:27 PM

Harbormaster completed remote builds in B39006: Diff 88616.May 4 2021, 7:27 PM

donner added reviewers: network, pi.May 4 2021, 7:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2021, 9:22 AM

Closed by commit rG0345fd891fe1: netgraph/ng_base: Renaming a node to the same name is a noop (authored by donner). · Explain Why

This revision was automatically updated to reflect the committed changes.

donner added a commit: rG0345fd891fe1: netgraph/ng_base: Renaming a node to the same name is a noop.

donner added a commit: rG37370a6773cd: netgraph/ng_base: Renaming a node to the same name is a noop.Jun 10 2021, 9:31 AM

donner added a commit: rGa0694da5d035: netgraph/ng_base: Renaming a node to the same name is a noop.Jun 10 2021, 9:34 AM

donner added a commit: rGb57a593cb2d6: netgraph/ng_base: Renaming a node to the same name is a noop.

donner mentioned this in D30713: tests/netgraph: Check for PR241954.Jun 10 2021, 10:08 AM

donner mentioned this in rG43e4821315c3: tests/netgraph: Check for PR241954.Jun 13 2021, 8:32 PM

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

4 lines

Diff 90397

sys/netgraph/ng_base.c

Loading...