Page MenuHomeFreeBSD

netgraph/ng_base: Renaming a node to the same name is a noop
ClosedPublic

Authored by donner on May 4 2021, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 1:59 AM
Unknown Object (File)
Sun, Oct 19, 3:19 AM
Unknown Object (File)
Sat, Oct 18, 4:25 PM
Unknown Object (File)
Thu, Oct 16, 8:14 PM
Unknown Object (File)
Wed, Oct 15, 5:43 AM
Unknown Object (File)
Sun, Oct 5, 12:30 AM
Unknown Object (File)
Aug 31 2025, 9:54 AM
Unknown Object (File)
Aug 25 2025, 1:00 AM

Details

Summary

Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move. Because the name of the node is already known
(occupied by itself), the second call fails.

PR: 241954
Reported by: Paul Armstrong
MFC: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

donner requested review of this revision.May 4 2021, 7:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2021, 9:22 AM
This revision was automatically updated to reflect the committed changes.