Page MenuHomeFreeBSD

netgraph/ng_base: Renaming a node to the same name is a noop
ClosedPublic

Authored by donner on May 4 2021, 7:27 PM.

Details

Summary

Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move. Because the name of the node is already known
(occupied by itself), the second call fails.

PR: 241954
Reported by: Paul Armstrong
MFC: 1 week

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

donner requested review of this revision.May 4 2021, 7:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2021, 9:22 AM
This revision was automatically updated to reflect the committed changes.