Tested fine on a Ryzen 1700, passing through an em device to an 11.1 guest, and doing lots of network file transfers.

Thanks for this work. Let me give it a quick test (later today) to verify.

(interested in adding bhyve support for SGX)

Please credit Fabian Freyer (from D7029) as the original submitter of this code when committing.

There was already a review for this in D9033 where I pointed out the initial fix by myself that bumped the number of descs, and the subsequent backout when it broke Linux guests :(

I emailed Marcelo some changes I had to this - it doesn't work as is.

Any chance this could be committed ?

In D10014#219157, @glebius wrote:

I missed one thing yesterday. The default for vga is "on", not "io". Lines 363-364 of pci_fbuf.c.

Thanks for the clarification on v2.

You'll have to use openat(), with the fd set up prior to cap_enter(). Here's a small example from theraven@freebsd.org, who I'm sure will be happy to provide further advice :) http://www.informit.com/articles/article.aspx?p=1924012&seqNum=2

Any thoughts on the interaction with capsicum ? Seems like you just need blanket access underneath a particular directory.

Fine to commit after the max fbuf res added.

Fine by me. I didn't check, but were all the comments in this applied to the new revision ?

The most recent spec (Rev 3.00—December 2016, http://support.amd.com/TechDocs/48882_IOMMU.pdf) seems to indicate that v1 is the base features, and new features are described as options, so not sure how to determine if it's v2. The IVRS table does have a v1/v2 format discriminator, though that isn't printed out in the current code.

Tested fine on a Ryzen 1700 + Asus X370 mobo, with a dual-port Intel 82571 card. Both ports passed through to a FreeBSD 12-CURRENT amd64 4 vCPU guest, with iperf3/netperf stress tests run.

Many thanks for doing this. I'll get some detailed comments shortly.

That was mentioned in earlier review comments. Maybe something like a kassert_decl attribute (expanding to unused if INVARIANTS not defined) ?

Thanks for the info. I'll see if I can move this forward under a different phab review.

I emailed on 7/16/2016 asking for help on running gcc and didn't get a response.

Thanks for keeping this going Allan.

emaste - any suggestions for a good forum to discuss this ? Unfortunately it straddles the capsicum@ and virtualization@ lists :(

robak - this is fine to commit once the last minor changes are done.

Into the final straight now: doing a visual inspection and picking up minor style issues.

Click on the 'Download raw diff' button on the right-hand side menu. Apply that diff to a FreeBSD source tree and rebuild.

Still some of the test matrix to cover. Hopefully shortly.

Rebuilding with CURRENT to give it a tryout - thanks for the nudge.

Thanks for the update - I'll give this a tryout.

It fixes Windows but breaks other guests.

I don't think it's that simple (already tried - see r282922 and the subsequent backout in r283168)

Thanks for making the change. I'll try and give it a test with PCI passthru.

silence == Thanksgiving vacation.

Does VNC disconnect/reconnect work ? (I'll try and test this out)

Great catch.

This is a good start.

Thanks for this work - it will be very useful.

This is fine as it stands. The potential issues with ppt devices can be addressed separately.

Didn't want to sound alarmist - just that this type of thing can upset static analyzers.

Will need to be MFC'd asap.

Looks fine. userboot doesn't have the same resource constraints as the actual loader, so it's usually fine to bump limits.

Another issue exposed by the more dynamic nature of ppt's now is that the host domain needs to be updated when a device is moved to/from the ppt state (perhaps ppt detach ?).

The conditional code is a bit invasive - would it be better just to put an "__unused" attribute on the variables in question ?

Thanks, much nicer.

All fine by me.

Thanks for doing this. I'd started on it but hadn't made a lot of progress (couldn't get a complete full build with the amd64_gcc port - blew up in the loader).

I'm fine with this.

Looks fine. This also closes PR 202321

Anish knows SVM :)