Invert calloc(3) argument order.
ClosedPublic
Actions

Authored by araujo on Aug 23 2016, 1:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 4, 6:49 AM

	Unknown Object (File)
	Tue, Apr 2, 12:34 AM

	Unknown Object (File)
	Jan 14 2024, 7:22 PM

	Unknown Object (File)
	Jan 9 2024, 8:31 PM

	Unknown Object (File)
	Jan 9 2024, 8:31 PM

	Unknown Object (File)
	Jan 9 2024, 8:31 PM

	Unknown Object (File)
	Jan 9 2024, 8:15 PM

	Unknown Object (File)
	Dec 22 2023, 9:55 PM

View All 43 Files

Subscribers

imp

Details

Reviewers

grehan
mav

Commits

rS305061: Invert calloc(3) argument order.

Summary

Seemed some calloc(3) calls has its arguments inverted,
the manpage says, it should be used nitems and size, not the oposite.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

araujo updated this revision to Diff 19583.Aug 23 2016, 1:16 PM

araujo retitled this revision from to Invert calloc(3) argument order..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added a reviewer: grehan.

Herald added a subscriber: imp. · View Herald TranscriptAug 23 2016, 1:16 PM

Will need to be MFC'd asap.

This revision is now accepted and ready to land.Aug 26 2016, 6:25 AM

I have no objections, though don't really understand agitation about this.

Didn't want to sound alarmist - just that this type of thing can upset static analyzers.

Closed by commit rS305061: Invert calloc(3) argument order. (authored by araujo). · Explain WhyAug 30 2016, 12:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

pci_e82545.c

2 lines

Diff 19843

View Options

head/usr.sbin/bhyve/pci_e82545.c

Invert calloc(3) argument order.ClosedPublicActions