Jul 10 2017
Jul 6 2017
Tested fine on a Ryzen 1700, passing through an em device to an 11.1 guest, and doing lots of network file transfers.
Jul 5 2017
Thanks for this work. Let me give it a quick test (later today) to verify.
Jul 3 2017
(interested in adding bhyve support for SGX)
Jun 8 2017
Jun 1 2017
Please credit Fabian Freyer (from D7029) as the original submitter of this code when committing.
May 26 2017
May 25 2017
May 24 2017
There was already a review for this in D9033 where I pointed out the initial fix by myself that bumped the number of descs, and the subsequent backout when it broke Linux guests :(
May 18 2017
I emailed Marcelo some changes I had to this - it doesn't work as is.
Any chance this could be committed ?
May 2 2017
I missed one thing yesterday. The default for vga is "on", not "io". Lines 363-364 of pci_fbuf.c.
May 1 2017
Apr 27 2017
Apr 24 2017
Thanks for the clarification on v2.
Apr 13 2017
Apr 10 2017
You'll have to use openat(), with the fd set up prior to cap_enter(). Here's a small example from email@example.com, who I'm sure will be happy to provide further advice :) http://www.informit.com/articles/article.aspx?p=1924012&seqNum=2
Apr 9 2017
Any thoughts on the interaction with capsicum ? Seems like you just need blanket access underneath a particular directory.
Fine to commit after the max fbuf res added.
Apr 5 2017
Fine by me. I didn't check, but were all the comments in this applied to the new revision ?
Mar 25 2017
Mar 23 2017
Mar 22 2017
Mar 21 2017
The most recent spec (Rev 3.00—December 2016, http://support.amd.com/TechDocs/48882_IOMMU.pdf) seems to indicate that v1 is the base features, and new features are described as options, so not sure how to determine if it's v2. The IVRS table does have a v1/v2 format discriminator, though that isn't printed out in the current code.
Tested fine on a Ryzen 1700 + Asus X370 mobo, with a dual-port Intel 82571 card. Both ports passed through to a FreeBSD 12-CURRENT amd64 4 vCPU guest, with iperf3/netperf stress tests run.
Mar 20 2017
Mar 16 2017
Many thanks for doing this. I'll get some detailed comments shortly.
Mar 15 2017
Mar 8 2017
That was mentioned in earlier review comments. Maybe something like a kassert_decl attribute (expanding to unused if INVARIANTS not defined) ?
Thanks for the info. I'll see if I can move this forward under a different phab review.
I emailed on 7/16/2016 asking for help on running gcc and didn't get a response.
Mar 3 2017
Thanks for keeping this going Allan.
Feb 25 2017
Feb 16 2017
Feb 14 2017
emaste - any suggestions for a good forum to discuss this ? Unfortunately it straddles the capsicum@ and virtualization@ lists :(
Feb 12 2017
robak - this is fine to commit once the last minor changes are done.
Feb 8 2017
Into the final straight now: doing a visual inspection and picking up minor style issues.
Feb 6 2017
Click on the 'Download raw diff' button on the right-hand side menu. Apply that diff to a FreeBSD source tree and rebuild.
Feb 4 2017
Feb 1 2017
Jan 30 2017
Still some of the test matrix to cover. Hopefully shortly.
Jan 24 2017
Rebuilding with CURRENT to give it a tryout - thanks for the nudge.
Jan 11 2017
Thanks for the update - I'll give this a tryout.
Jan 8 2017
Jan 3 2017
It fixes Windows but breaks other guests.
I don't think it's that simple (already tried - see r282922 and the subsequent backout in r283168)
Dec 21 2016
Dec 15 2016
Thanks for making the change. I'll try and give it a test with PCI passthru.
Dec 12 2016
Dec 3 2016
silence == Thanksgiving vacation.
Nov 16 2016
Does VNC disconnect/reconnect work ? (I'll try and test this out)
Oct 29 2016
Oct 22 2016
Oct 20 2016
Sep 30 2016
Thanks for this work - it will be very useful.
Sep 12 2016
Aug 26 2016
This is fine as it stands. The potential issues with ppt devices can be addressed separately.
Didn't want to sound alarmist - just that this type of thing can upset static analyzers.
Will need to be MFC'd asap.
Aug 24 2016
Looks fine. userboot doesn't have the same resource constraints as the actual loader, so it's usually fine to bump limits.
Aug 14 2016
Another issue exposed by the more dynamic nature of ppt's now is that the host domain needs to be updated when a device is moved to/from the ppt state (perhaps ppt detach ?).
Aug 9 2016
Jul 27 2016
Jul 26 2016
Jul 17 2016
Jul 11 2016
The conditional code is a bit invasive - would it be better just to put an "__unused" attribute on the variables in question ?
Jul 6 2016
Thanks, much nicer.
Jul 5 2016
Thanks for doing this. I'd started on it but hadn't made a lot of progress (couldn't get a complete full build with the amd64_gcc port - blew up in the loader).
Jul 4 2016
Jun 24 2016
I'm fine with this.
May 27 2016
May 26 2016
Looks fine. This also closes PR 202321
Apr 22 2016
Anish knows SVM :)