Page MenuHomeFreeBSD
Feed Advanced Search

Jun 26 2022

tsoome closed D32316: Support of optional PMC classes..
Jun 26 2022, 9:19 AM · pmc

Jan 27 2022

gnn removed a member for pmc: gnn.
Jan 27 2022, 3:55 PM

Dec 19 2021

ray added a comment to D32316: Support of optional PMC classes..

@ray I assume you can go ahead with committing this one?

Dec 19 2021, 3:27 PM · pmc

Nov 4 2021

emaste added a comment to D32316: Support of optional PMC classes..

@ray I assume you can go ahead with committing this one?

Nov 4 2021, 6:04 PM · pmc

Oct 27 2021

mhorne accepted D32316: Support of optional PMC classes..
In D32316#737883, @ray wrote:

It seems to me that only the changes to pmc_arm64_initialize() should be necessary, because it handles optional classes in the same way that pmc_intel_initialize() does, by passing the correct nclasses value to pmc_mdep_alloc().

Problem here is in static machdep class numbers. If classes will be initialized in incorrect order, adjusted ri will be incorrect. So that modification may save some time on debugging such issue for new optional classes with just little time in hwpmc(4) init.

Oct 27 2021, 3:39 PM · pmc
ray added a comment to D32316: Support of optional PMC classes..

It seems to me that only the changes to pmc_arm64_initialize() should be necessary, because it handles optional classes in the same way that pmc_intel_initialize() does, by passing the correct nclasses value to pmc_mdep_alloc().

Oct 27 2021, 3:12 PM · pmc
mhorne added a comment to D32316: Support of optional PMC classes..

It seems to me that only the changes to pmc_arm64_initialize() should be necessary, because it handles optional classes in the same way that pmc_intel_initialize() does, by passing the correct nclasses value to pmc_mdep_alloc().

Oct 27 2021, 3:00 PM · pmc

Oct 26 2021

allanjude updated the summary of D32316: Support of optional PMC classes..
Oct 26 2021, 4:28 PM · pmc
ray updated the diff for D32316: Support of optional PMC classes..

Update classes base ri to handle optional classes out of order.

Oct 26 2021, 1:01 PM · pmc

Oct 6 2021

ray added reviewers for D32316: Support of optional PMC classes.: emaste, andrew.
Oct 6 2021, 12:33 PM · pmc

Oct 5 2021

ray retitled D32316: Support of optional PMC classes. from Support of optional classes. to Support of optional PMC classes..
Oct 5 2021, 2:23 PM · pmc

Aug 5 2021

mhorne added a member for pmc: mhorne.
Aug 5 2021, 2:11 PM

May 26 2021

allanjude closed D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 26 2021, 6:44 PM · pmc

May 5 2021

emaste accepted D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 5 2021, 4:21 PM · pmc
mhorne accepted D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 5 2021, 3:23 PM · pmc
emaste added a comment to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

Comment update LGTM

May 5 2021, 3:10 PM · pmc
ray updated the diff for D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

Squash commits.

May 5 2021, 2:57 PM · pmc
ray updated the diff for D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

Fix comment.

May 5 2021, 2:51 PM · pmc
ray added inline comments to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 5 2021, 2:43 PM · pmc
ray added a comment to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

This looks fine to me, thanks for fixing this.

It seems that pmc_id_t should be an opaque type for consumers of libpmc? I.e. the only userspace consumer of these bit macros should be libpmc itself.

If that is the case, then this change should be okay without a PMC_VERSION bump. There are no uses of PMC_ID_TO_MODE or PMC_ID_MAKE_ID in libpmc. However, I did not check if this was true for older releases.

May 5 2021, 2:43 PM · pmc
emaste added inline comments to D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
May 5 2021, 2:36 PM · pmc
mhorne accepted D30047: hwpmc: Move 4 bits of mode to extend class size to 8..

This looks fine to me, thanks for fixing this.

May 5 2021, 2:29 PM · pmc

May 3 2021

ray added a reviewer for D30047: hwpmc: Move 4 bits of mode to extend class size to 8.: pmc.
May 3 2021, 11:48 AM · pmc
ray added a member for pmc: ray.
May 3 2021, 11:47 AM

Apr 30 2021

ray updated the summary of D30047: hwpmc: Move 4 bits of mode to extend class size to 8..
Apr 30 2021, 3:00 PM · pmc

Jun 13 2017

zbb closed D10912: Fix INVARIANTS debug code in HWPMC by committing rS319913: Fix INVARIANTS debug code in HWPMC.
Jun 13 2017, 6:54 PM · pmc

May 25 2017

mw_semihalf.com created D10912: Fix INVARIANTS debug code in HWPMC.
May 25 2017, 3:34 PM · pmc

Jan 27 2016

rpaulo removed a member for pmc: rpaulo.
Jan 27 2016, 6:16 AM

May 13 2015

stas closed D2518: Fix pmcstat symbol resolution for userland processes.

This was submitted as r282866.

May 13 2015, 7:15 PM · pmc
rpaulo accepted D2518: Fix pmcstat symbol resolution for userland processes.
May 13 2015, 4:31 AM · pmc
rpaulo added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

Macro bulbasaur:
Macro rubberstamp:

May 13 2015, 4:31 AM · pmc

May 12 2015

stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.
In D2518#46456, @jhb wrote:

Ok. I think the longer term fix is to update the MAP_IN message to include the relative offset of the mapping to the backing object, then it wouldn't have to parse the header to see what offset of the file is mapped.

May 12 2015, 7:40 PM · pmc
jhb added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

Ok. I think the longer term fix is to update the MAP_IN message to include the relative offset of the mapping to the backing object, then it wouldn't have to parse the header to see what offset of the file is mapped.

May 12 2015, 12:15 PM · pmc
stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

Example running unixbench:

May 12 2015, 7:53 AM · pmc
stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

With this change pmcstat(8) still does not resolve symbols for some applications, but at least they show up in pmcstat -T and in the callgraph (before that pmcstat would mark their frames as "dubious").

May 12 2015, 7:30 AM · pmc
stas added a reviewer for D2518: Fix pmcstat symbol resolution for userland processes: rpaulo.
May 12 2015, 7:09 AM · pmc
stas retitled D2518: Fix pmcstat symbol resolution for userland processes from to Fix pmcstat symbol resolution for userland processes.
May 12 2015, 7:06 AM · pmc

May 8 2015

stas added a member for pmc: stas.
May 8 2015, 11:10 PM