Page MenuHomeFreeBSD

stas (Stanislav Sedov)
User

Projects

User Details

User Since
Jun 24 2014, 6:45 PM (277 w, 3 d)

Recent Activity

Oct 31 2016

stas accepted D8384: Add support for microcode update on newer AMD CPUs (10h+).

Looks good besides what kib@ already mentioned.

Oct 31 2016, 8:07 AM

Jun 21 2016

stas accepted D6895: Add support for a /etc/defaults/vendor.conf override file.
Jun 21 2016, 6:34 PM

Jun 20 2016

stas accepted D6895: Add support for a /etc/defaults/vendor.conf override file.

I see, thanks for the explanation. It would be perfect to add a short version of it to the commit message as well.

Jun 20 2016, 9:29 PM
stas added a comment to D6895: Add support for a /etc/defaults/vendor.conf override file.

This looks good, but I'm a little bit confused as to how it is different from rc.local? Does it provide anything which can't be achieved by using rc.local which seems to serve the same purpose?

Jun 20 2016, 6:55 PM

Jan 8 2016

stas committed rS293413: MFC r291545: make the number of fasttrap probes and the size of the trace….
MFC r291545: make the number of fasttrap probes and the size of the trace…
Jan 8 2016, 3:45 AM
stas committed rS293402: MFC r277938 (by hiren): make syncookie_mac() use 'tcp_seq irs' in computing….
MFC r277938 (by hiren): make syncookie_mac() use 'tcp_seq irs' in computing…
Jan 8 2016, 12:46 AM
stas committed rS293401: MFC r292047: RPC: populate local address for rendezvous transporter..
MFC r292047: RPC: populate local address for rendezvous transporter.
Jan 8 2016, 12:22 AM

Jan 7 2016

stas committed rS293382: Remove myself from the sizelimit file..
Remove myself from the sizelimit file.
Jan 7 2016, 10:36 PM

Dec 23 2015

stas accepted D4350: TCP Fast Open (TFO) [RFC7413] Server-side Implementation.
Dec 23 2015, 10:25 PM

Dec 10 2015

stas committed rS292047: RPC: populate local address for rendezvous transporter..
RPC: populate local address for rendezvous transporter.
Dec 10 2015, 5:17 AM
stas closed D4206: Populate local address for rendezvous transporter. by committing rS292047: RPC: populate local address for rendezvous transporter..
Dec 10 2015, 5:17 AM

Dec 2 2015

stas added inline comments to D4350: TCP Fast Open (TFO) [RFC7413] Server-side Implementation.
Dec 2 2015, 10:13 PM
stas accepted D4315: artifical frame should be 3 in arm platform..
Dec 2 2015, 3:33 AM
stas accepted D4315: artifical frame should be 3 in arm platform..

Looks good besides the SYSCTL_INT vs UINT issue.

Dec 2 2015, 3:11 AM

Dec 1 2015

stas committed rS291545: Make the number of fasttrap probes and the size of the trace points hash table.
Make the number of fasttrap probes and the size of the trace points hash table
Dec 1 2015, 12:25 AM

Nov 25 2015

stas accepted D4206: Populate local address for rendezvous transporter..

Looks good to me.

Nov 25 2015, 8:34 PM

Sep 10 2015

stas added a comment to D3593: Retire t_maxopd, leave t_maxseg..

Gleb, if we real world testing is needed we'd be happy to test it in our environment.

Sep 10 2015, 6:33 PM

Sep 4 2015

stas added a comment to D3567: ignore ICMP need frag with equal or larger MTU offer.

Another thing we discovered is that FreeBSD actually used to handle this case correctly up until r182851 where the relevant check was dropped by accident during the mtu handling refactoring. It used to check for the received MTU size and return early:

if (tp->t_maxopd <= mss)
    return (inp);
Sep 4 2015, 7:17 PM

Jul 20 2015

stas accepted D3129: MFC SMBIOS support for EFI to stable/10.
Jul 20 2015, 7:17 PM

May 31 2015

stas accepted D2685: Remove unused variable reported by CLANG..
May 31 2015, 9:10 AM

May 19 2015

stas accepted D2443: Make kerberos use the regular sqlite.

Looks good, thanks!

May 19 2015, 11:54 PM

May 15 2015

stas added a comment to D2559: Add initial process/thread NUMA policy configuration and management utility.

Looks good, mostly nitpicks for now. Will look deeper tonight.

May 15 2015, 11:10 PM

May 13 2015

stas closed D2518: Fix pmcstat symbol resolution for userland processes.

This was submitted as r282866.

May 13 2015, 7:15 PM · pmc
stas committed rS282866: Fix pmcstat symbol resolution for userland processes..
Fix pmcstat symbol resolution for userland processes.
May 13 2015, 6:52 PM

May 12 2015

stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.
In D2518#46456, @jhb wrote:

Ok. I think the longer term fix is to update the MAP_IN message to include the relative offset of the mapping to the backing object, then it wouldn't have to parse the header to see what offset of the file is mapped.

May 12 2015, 7:40 PM · pmc
stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

Example running unixbench:

May 12 2015, 7:53 AM · pmc
stas added a comment to D2518: Fix pmcstat symbol resolution for userland processes.

With this change pmcstat(8) still does not resolve symbols for some applications, but at least they show up in pmcstat -T and in the callgraph (before that pmcstat would mark their frames as "dubious").

May 12 2015, 7:30 AM · pmc
stas added a reviewer for D2518: Fix pmcstat symbol resolution for userland processes: rpaulo.
May 12 2015, 7:09 AM · pmc
stas retitled D2518: Fix pmcstat symbol resolution for userland processes from to Fix pmcstat symbol resolution for userland processes.
May 12 2015, 7:06 AM · pmc

May 9 2015

stas committed rS282673: Fix the double space in comment..
Fix the double space in comment.
May 9 2015, 12:48 AM

May 8 2015

stas added a member for pmc: stas.
May 8 2015, 11:10 PM

May 6 2015

stas accepted D2460: Add SLIT enumeration and memory locality table to VM/ACPI..

Looks good. Besides things ngie already commented on I don't see any issues.

May 6 2015, 6:01 AM

Nov 5 2014

stas added inline comments to D714: Installer Enhancement -- dpv.
Nov 5 2014, 2:47 AM

Oct 18 2014

stas added inline comments to D965: Add a driver for the TI watchdog..
Oct 18 2014, 11:47 PM

Jun 24 2014

stas accepted D283: devel/cunit: depend on libncurses.

Looks good, thanks!

Jun 24 2014, 6:47 PM