User Details
- User Since
- Jun 24 2014, 6:45 PM (546 w, 12 h)
Dec 13 2020
Oct 31 2016
Looks good besides what kib@ already mentioned.
Jun 21 2016
Jun 20 2016
I see, thanks for the explanation. It would be perfect to add a short version of it to the commit message as well.
This looks good, but I'm a little bit confused as to how it is different from rc.local? Does it provide anything which can't be achieved by using rc.local which seems to serve the same purpose?
Jan 8 2016
Jan 7 2016
Dec 23 2015
Dec 10 2015
Dec 2 2015
Looks good besides the SYSCTL_INT vs UINT issue.
Dec 1 2015
Nov 25 2015
Looks good to me.
Sep 10 2015
Gleb, if we real world testing is needed we'd be happy to test it in our environment.
Sep 4 2015
Another thing we discovered is that FreeBSD actually used to handle this case correctly up until r182851 where the relevant check was dropped by accident during the mtu handling refactoring. It used to check for the received MTU size and return early:
if (tp->t_maxopd <= mss) return (inp);
Jul 20 2015
May 31 2015
May 19 2015
May 15 2015
Looks good, mostly nitpicks for now. Will look deeper tonight.
May 13 2015
This was submitted as r282866.
May 12 2015
Example running unixbench:
With this change pmcstat(8) still does not resolve symbols for some applications, but at least they show up in pmcstat -T and in the callgraph (before that pmcstat would mark their frames as "dubious").
May 9 2015
May 8 2015
May 6 2015
Looks good. Besides things ngie already commented on I don't see any issues.