New port commit log format:

LGTM, nice root resolution and one less port with specific compiler dependency

Approved, please add clear ($reason) to MFH

So this fixes a runtime issue when built with Clang/LLVM, but that was mitigated with/by USE_GCC ?

Thanks for this @andrew_tao173.riddles.org.uk

Background on request/motivation:

Approval for FLAVORS for x11-toolkits/guile-gnome-platform please portmgr

Otherwise accepted. Thanks @kevans!

I added (blanket: build fix) to MFH line. This positive note allows ports-secteam not to manually respond to the automatic MFH email to approve it, since its blanket

LGTM, but passes QA? TEST PLAN is empty

Do you intent to commit this immediately, or later?

LGTM, accepted contingent on poudriere passing

These comments are applicable for the non-release version of pylibacl; pylibacl 0.5.4 supports 2.7 and doesn't support pytest: https://github.com/iustin/pylibacl/blob/pylibacl-v0.5.4/.travis.yml .

When the next version is released, the changes you requested should definitely be implemented.

• Please confirm portlint and poudriere (Py 2.x and Py 3.x) pass (ive added bullet points for these in TEST PLAN section)
• 0.5.3 and 0.5.4 are bugfix only releases, with specific FreeBSD bugfixes: MFH: 2010Q1
• Changelog says: Drop support (well, drop testing) for Python lower than 2.7. but setup.py contains python_requires = ">=3.4", which will fail for 2.x. This should be patched out of setup.py and reported upstream. Upstream should add that only when 2.7 is explicitly *not* supported. If upstream says its unsupported now, then port should USES=python:3.4+ accordingly
• Upstream switched from unittest to pytest and setup.py test has technically been deprecated. Switch [2] to:

Looks OK from my limited understanding of the context / semantics of the change. Over to @kai

Hey, meant to follow this up sooner but the last few weeks have been crazy. Shared dependencies are incompatible with the way Python tracks versions. The Python team will be discussing ways to ensure the accuracy of Python port dependencies, which shared/common macros preclude. We're looking to remove the existing ones once we're ready.

Does this need MFH'ing?

Not sure if you can (that would be cool), just add/change the reviewer type after attaching

Add maintainers for non-blanket (not implicitly approved) changes as blocking reviewers, eg: if @bapt and @manu are uboot@.

Approved if MOVEDlint.awk passes and after removing GL_PROJECT=python-crontab (assuming GL_PROJECT defaults to PORTNAME like GH does)

LGTM. Any committer taking this should verify QA (Python 2.x / 3.x and running test target)

Nice!

You can try to use USE_LOCAL=<locale> or TEST_ENV+=LANG=whatever to set a more appropriate locale (the one that tests 'rely' on)

Conversely, there will have and continue to be users that pkg install 'pyyaml' using the name referenced by upstream and in all current and future documentation, and the names used by all packages that depend on it, that dont/cant find it.

Nice review @kevans

@kai You have a deeper understanding of theQA implications and context of these changes. Approved if you're confident and happy and having addressed my prior review comments

If this is a bugfix (reads like it is), then MFH: <quarterly> (blanket: bugfix)

@0mp Thanks for this.

Ack on separate commits

Re removing PORTREVISIONS, we dont ''want'' ports to switch to use pillow6/pillow7 (based on / with new conditionals) after this commit?