In D16378#349810, @dbn wrote:FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Oct 6 2019
Oct 6 2019
Sep 22 2019
Sep 22 2019
May 10 2019
May 10 2019
May 2 2019
May 2 2019
Jul 28 2018
Jul 28 2018
FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)
Jul 27 2018
Jul 27 2018
LGTM
Remove unnecessary version check for FreeBSD < 10
Jul 26 2018
Jul 26 2018
The comments I mention are just suggestions. Happy for you to commit this patch without those changes.
Jul 24 2018
Jul 24 2018
Remove another unrelated patch that was accidentally slipped in
Update patches that enables bulid on FreeBSD 10+
Jul 23 2018
Jul 23 2018
Jul 22 2018
Jul 22 2018
Does the change pass QA (poudriere) on supported/expected FreeBSD versions/archs without regression?
Jul 21 2018
Jul 21 2018
Jul 7 2018
Jul 7 2018
Jul 6 2018
Jul 6 2018
Feb 13 2018
Feb 13 2018
Jan 14 2018
Jan 14 2018
Take maintainership and slightly modify pkg-message.
Add in pkg-message file.
Jan 12 2018
Jan 12 2018
I am marking those are "Done" since the subject was already discussed.
Built and installed naively it refuses to run until I set LANG to a UTF-8 locale (e.g. en_US.UTF-8), but that's more a Python 3.6 / Click problem than khal.
There is one already.
Jan 11 2018
Jan 11 2018
In D13432#290787, @lbdm_privacychain.ch wrote:Can it be merged already? :-)
Thanks!
Can it be merged already? :-)
Dec 30 2017
Dec 30 2017
Dec 29 2017
Dec 29 2017
Re-working install phase.
In D13432#285854, @adridg wrote:Please double-check upstream's comment about setup.cfg.
Please double-check upstream's comment about setup.cfg.
Dec 28 2017
Dec 28 2017
Fixing manual file.
I'll have a look at this later, I'll keep track of this in khal's issue tracker (see https://github.com/pimutils/khal/issues/745 ).
In D13432#285348, @github_lostpackets.de wrote:There are two different kind of errors here:
- the filesystem of the build service doesn't seem to support mtime of files, while we could mock this, it's kind of the point to test if an updated file is caught my khal. Do you know what kind of system the build is run on?
- the locale seems to be not/misconfigured, exporting the correct locale settings should fix those errors, something like exporting LC_ALL=en_US.utf-8 and LANG=en_US.utf-8 should do the tick ( see http://click.pocoo.org/5/python3/#python-3-surrogate-handling )
As the first issue is not easily fixable, I would suggest either patching the tests to make them xfail or not run them for now.
Removing TEST. The inclusion was making the things too cumbersome.
Dec 27 2017
Dec 27 2017
There are two different kind of errors here:
Dec 26 2017
Dec 26 2017
rigoletto retitled D13618: New port: net-p2p/py-tremc. from New port: net-p2p/tremc. to New port: net-p2p/py-tremc..
Minor.
I completely forgot about the PKGNAMEPREFIX.
One more thing you can expect python@ team to bring up is [1], specifically PKGNAMEPREFIX missing and the port being named net-p2p/py-tremc. Not sure if it needs to follow these policies though because its not a standard python port.
Updating distinfo.
Done.
Thanks!
Fixing.
Building fine now.
Fix typo in GEOIP_RUN_DEPENS.
Dec 25 2017
Dec 25 2017
rigoletto retitled D13618: New port: net-p2p/py-tremc. from New port net-p2p/tremc. to New port: net-p2p/tremc..
Please disregard the previous diff, that was mistakenly added in here.
Dec 22 2017
Dec 22 2017
Minor.
Updating with the suggested modifications, however still fail to test:
Dec 13 2017
Dec 13 2017
Dec 11 2017
Dec 11 2017
- bring "created by" back
- remove the empty OPTIONS_DEFAULT
Dec 10 2017
Dec 10 2017
I am out now and so I can't look for, but shouldn't the port header be cleanased and leave only the "# $freebsd$" line?
Yes, this patch started for a older version. I forgot to update the minimum python version to python:3.4+.
Dec 8 2017
Dec 8 2017
I guess it's good now
Dec 7 2017
Dec 7 2017
Dec 6 2017
Dec 6 2017
Done.
- switch to DISTVERSION
Done
- switch back to PORTVERSION
- remove BUILD_DEPENDS
Dec 1 2017
Dec 1 2017
python-pcre currently does support Python 2 and 3:
Fixing.
Oct 23 2017
Oct 23 2017
Oct 18 2017
Oct 18 2017
Since the previous version was python:2 only, I think it is safe to assume a python:3 slave port is currently not necessary.
Reverting it to python:2 but maintaining concurrent for eventual future use.
Oct 17 2017
Oct 17 2017
Oct 10 2017
Oct 10 2017
Done. Thanks!