Page MenuHomeFreeBSD
Feed Advanced Search

Nov 25 2024

andrew added inline comments to D47678: arm64: Implement pmap_map_io_transient.
Nov 25 2024, 9:14 AM

Nov 20 2024

andrew added inline comments to D47683: memcmp.3: clarify return value.
Nov 20 2024, 4:06 PM

Nov 19 2024

andrew committed rGce284dded5d5: arm64: Fix comparing ID register fields (authored by andrew).
arm64: Fix comparing ID register fields
Nov 19 2024, 5:48 PM
andrew closed D47437: arm64: Fix comparing ID register fields.
Nov 19 2024, 5:48 PM
andrew closed D47237: arm64: Adjust the MPASS in vfp_save_state_savectx.
Nov 19 2024, 5:48 PM
andrew committed rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx (authored by andrew).
arm64: Adjust the MPASS in vfp_save_state_savectx
Nov 19 2024, 5:48 PM
andrew closed D47487: acpi: Handle multiple interrupts.
Nov 19 2024, 5:48 PM
andrew committed rGa1330a71d20d: acpi: Handle multiple interrupts (authored by andrew).
acpi: Handle multiple interrupts
Nov 19 2024, 5:48 PM
andrew requested review of D47678: arm64: Implement pmap_map_io_transient.
Nov 19 2024, 5:02 PM
andrew requested review of D47670: acpi_gpiobus: Fix cleanup on set flags failure.
Nov 19 2024, 1:09 PM

Nov 8 2024

andrew added a comment to D45621: lib/libc/aarch64/string: add memcmp SIMD implementation.

I was running on a Neoverse-N2 CPU. I ran with your benchmark and received mixed results, some faster some slower.

Nov 8 2024, 5:38 PM
andrew requested review of D47487: acpi: Handle multiple interrupts.
Nov 8 2024, 4:29 PM
andrew added a comment to D45621: lib/libc/aarch64/string: add memcmp SIMD implementation.

Have you tried any other benchmarks? I tried testing against the glibc memcmp using their benchmarking tool as should be the same code as on FreeBSD and found this version was slower in most cases.

Nov 8 2024, 2:43 PM

Nov 7 2024

andrew added inline comments to D46272: lib/libc/aarch64/string: add strlcat SIMD implementation.
Nov 7 2024, 2:27 PM

Nov 4 2024

andrew requested review of D47437: arm64: Fix comparing ID register fields.
Nov 4 2024, 5:12 PM
andrew accepted D47432: scmi: raw: Add sysctl queues properties.
Nov 4 2024, 4:37 PM
andrew accepted D47431: scmi: Add RAW interface call hooks into the core.
Nov 4 2024, 4:36 PM
andrew added inline comments to D47429: scmi: raw: Add RAW interface for testing and developemnt.
Nov 4 2024, 4:35 PM
andrew accepted D47428: scmi: Add sysctl transport properties.
Nov 4 2024, 4:32 PM
andrew accepted D47426: scmi: Add optional asynchronous handling of replies.
Nov 4 2024, 4:31 PM
andrew accepted D47425: scmi: Refactor scmi_request internal logic.
Nov 4 2024, 4:17 PM
andrew accepted D47423: scmi: Add helper to manipulate scmi_msg descriptors.
Nov 4 2024, 4:16 PM
andrew accepted D47424: scmi: Add scmi_token_reserve helper.
Nov 4 2024, 4:15 PM
andrew added inline comments to D47422: scmi: Add devicetree transport properties.
Nov 4 2024, 3:59 PM
andrew added a comment to D47421: scmi: Redefine max message payload size.

Does scmi_buf_get need to be updated with SCMI_MAX_MSG_REPLY_SIZE changing?

Nov 4 2024, 3:50 PM
andrew added inline comments to D47420: scmi: Make transports report the effective length of the received messages.
Nov 4 2024, 3:46 PM
andrew accepted D47419: scmi: Fix race on timed out transmissions.
Nov 4 2024, 3:41 PM
andrew accepted D47418: scmi: Fix token bitmask.
Nov 4 2024, 3:39 PM

Nov 1 2024

andrew added a comment to D47358: rescue: Implement a direct dumper for arm64 and amd64.

How do you plan to handle the GICv3 ITS? It needs to use the same physical pages in both kernels. We already handle this when kexecing from Linux, but will need to pass the info needed to the rescue kernel.

Nov 1 2024, 2:54 PM

Oct 31 2024

andrew added inline comments to D47253: GPIO: Add ACPI _AEI support.
Oct 31 2024, 5:00 PM
andrew added inline comments to D47253: GPIO: Add ACPI _AEI support.
Oct 31 2024, 2:10 PM

Oct 30 2024

andrew updated subscribers of D47253: GPIO: Add ACPI _AEI support.
Oct 30 2024, 5:04 PM
andrew added a comment to D47317: psci: Teach the arm SMCCC code about KMSAN.

It seems like an unneeded level of indirection in the non-KMSAN case

Oct 30 2024, 2:21 PM
andrew updated the diff for D47317: psci: Teach the arm SMCCC code about KMSAN.
  • Move kmsan calls to asm
  • Add kmsan_check and kmsan_mark to arm_smccc_1_2_*
Oct 30 2024, 1:57 PM
andrew added inline comments to D47253: GPIO: Add ACPI _AEI support.
Oct 30 2024, 10:37 AM

Oct 29 2024

andrew added a comment to D47331: acpi_gpiobus: IoRestriction is only for type IO.

Don't we need to set GPIO_PIN_INPUT for interrupts?

Oct 29 2024, 5:10 PM
andrew added inline comments to D47253: GPIO: Add ACPI _AEI support.
Oct 29 2024, 2:36 PM
andrew committed rGd652801574f7: bus: Fix the non-debug build (authored by andrew).
bus: Fix the non-debug build
Oct 29 2024, 11:16 AM
andrew closed D47283: arm64: Use the common activate function in nexus.
Oct 29 2024, 10:35 AM
andrew closed D47282: bus: Activate INTRNG interrupts in common code.
Oct 29 2024, 10:35 AM
andrew committed rGc85855a72db9: bus: Activate INTRNG interrupts in common code (authored by andrew).
bus: Activate INTRNG interrupts in common code
Oct 29 2024, 10:35 AM
andrew committed rG60344d7e09d5: arm64: Use the common activate function in nexus (authored by andrew).
arm64: Use the common activate function in nexus
Oct 29 2024, 10:35 AM

Oct 28 2024

andrew requested review of D47317: psci: Teach the arm SMCCC code about KMSAN.
Oct 28 2024, 5:12 PM

Oct 25 2024

andrew added a comment to D47283: arm64: Use the common activate function in nexus.

Should I be testing this on Graviton (with my _AEI patches minus the bogus resource activation one)?

Oct 25 2024, 5:16 PM
andrew added a comment to D47283: arm64: Use the common activate function in nexus.

I think the other drivers can use bus_generic_rman_activate_resource directly, however I can't easily test them.

Oct 25 2024, 4:35 PM
andrew added a comment to D47279: intrng: address post-commit review feedback.

We don't build the kernel with -fshort-enums, and even if we did then the assembly for arm and arm64 would be identical to the current code as the enum is passed in via a register to intr_irq_handler

Oct 25 2024, 3:26 PM
andrew added a comment to D47252: acpi_gpiobus: Use non-rman resource activation.

See D47282 for teaching bus_generic_rman_activate_resource about INTRNG

Oct 25 2024, 2:29 PM
andrew added a reviewer for D47283: arm64: Use the common activate function in nexus: arm64.
Oct 25 2024, 2:20 PM
andrew requested review of D47283: arm64: Use the common activate function in nexus.
Oct 25 2024, 2:20 PM
andrew requested review of D47282: bus: Activate INTRNG interrupts in common code.
Oct 25 2024, 2:20 PM
andrew added a comment to D47279: intrng: address post-commit review feedback.

We can assume the size of an enum on arm and arm64 as the ABI requires it to be either an int or unsigned int (unless it needs to hold values that are too large so can't be expressed as either of these). This means we can assume the size of this enum is 32-bit on arm and arm64. I assume riscv has a similar requirement.

Oct 25 2024, 8:16 AM

Oct 24 2024

andrew committed rGd7f930b80e89: arm64: Implement efi_rt_arch_call (authored by andrew).
arm64: Implement efi_rt_arch_call
Oct 24 2024, 10:37 AM
andrew committed rG8efb1500d4f1: arm64: Enable handling EFI runtime service faults (authored by andrew).
arm64: Enable handling EFI runtime service faults
Oct 24 2024, 10:37 AM
andrew committed rGa84653c5db25: arm64: Don't enable interrupts when in a spinlock (authored by andrew).
arm64: Don't enable interrupts when in a spinlock
Oct 24 2024, 10:37 AM
andrew closed D47235: intrng: Store the IPI priority.
Oct 24 2024, 10:37 AM
andrew committed rG6204391e99ca: arm64: Check TDP_NOFAULTING in a data abort (authored by andrew).
arm64: Check TDP_NOFAULTING in a data abort
Oct 24 2024, 10:37 AM
andrew closed D46818: arm64: Enable handling EFI runtime service faults.
Oct 24 2024, 10:37 AM
andrew closed D46817: arm64: Implement efi_rt_arch_call.
Oct 24 2024, 10:37 AM
andrew committed rG3b03e1bb8615: intrng: Store the IPI priority (authored by andrew).
intrng: Store the IPI priority
Oct 24 2024, 10:37 AM
andrew closed D46816: arm64: Don't enable interrupts when in a spinlock.
Oct 24 2024, 10:37 AM
andrew closed D46815: arm64: Check TDP_NOFAULTING in a data abort.
Oct 24 2024, 10:37 AM
andrew committed rGb2dd4970c7b5: dev/gpio: Mask all pl011 interrupts (authored by andrew).
dev/gpio: Mask all pl011 interrupts
Oct 24 2024, 10:37 AM
andrew closed D46863: dev/gpio: Mask all pl011 interrupts.
Oct 24 2024, 10:36 AM

Oct 23 2024

andrew accepted D47002: sys/intr.h: formally depend on machine/intr.h.
Oct 23 2024, 2:36 PM
andrew added a comment to D47252: acpi_gpiobus: Use non-rman resource activation.

Is there a reason to not do it in bus_generic_rman_activate_resource on those archs? We could then replace nexus_activate_resource with bus_generic_rman_activate_resource on arm and riscv (it's missing non-posted memory support needed on arm64)

Oct 23 2024, 2:27 PM
andrew updated the diff for D46816: arm64: Don't enable interrupts when in a spinlock.

Also check I and F flags before enabling interrupts

Oct 23 2024, 1:43 PM
andrew updated the diff for D46815: arm64: Check TDP_NOFAULTING in a data abort.

Remove __predict_true

Oct 23 2024, 11:20 AM
andrew added a comment to D47252: acpi_gpiobus: Use non-rman resource activation.

The issue is we need to call into subr_intr.c to activate the interrupt. Currently this is done in nexus on arm, arm64, and riscv but this requires calling the parent bus_activate_resource in each bus driver.

Oct 23 2024, 11:19 AM
andrew accepted D47251: acpi_gpiobus: Narrow scope of NOT_YET.
Oct 23 2024, 11:09 AM
andrew accepted D47250: gpiobus: Make gpiobus_read_ivar extern.
Oct 23 2024, 11:08 AM
andrew added inline comments to D47253: GPIO: Add ACPI _AEI support.
Oct 23 2024, 11:08 AM

Oct 22 2024

andrew requested review of D47248: dev/psci: Add initial SDEI support.
Oct 22 2024, 5:37 PM
andrew requested review of D47247: arm64: Add PSR_M_EL_MASK.
Oct 22 2024, 5:37 PM
andrew requested review of D47246: dev/psci: Add a way to query the PSCI method.
Oct 22 2024, 5:37 PM
andrew requested review of D47245: dev/psci: Allow smccc.h to be included from asm.
Oct 22 2024, 5:37 PM
andrew requested review of D47244: arm64: Also populate tpidr_el2.
Oct 22 2024, 5:37 PM
andrew requested review of D47237: arm64: Adjust the MPASS in vfp_save_state_savectx.
Oct 22 2024, 2:24 PM
andrew requested review of D47236: intr: Support per-IPI devices.
Oct 22 2024, 2:05 PM
andrew requested review of D47235: intrng: Store the IPI priority.
Oct 22 2024, 1:51 PM

Oct 21 2024

andrew committed rGce5a07a9d2c5: arm64: Stop trashing x28 in savectx (authored by andrew).
arm64: Stop trashing x28 in savectx
Oct 21 2024, 3:06 PM
andrew committed rGee7cb98d4cd0: dev/psci: Create macros to simplify calling SMCCC (authored by andrew).
dev/psci: Create macros to simplify calling SMCCC
Oct 21 2024, 3:06 PM
andrew committed rG78b308e5a4a1: sys: Use the new arm_smccc_invoke macros (authored by andrew).
sys: Use the new arm_smccc_invoke macros
Oct 21 2024, 3:06 PM
andrew committed rGc0de8718a5c1: arm64: Support HWCAP2_AFP and HWCAP2_RPRES (authored by andrew).
arm64: Support HWCAP2_AFP and HWCAP2_RPRES
Oct 21 2024, 3:06 PM
andrew committed rG1f9635e2c213: arm64: Enable SVE in userspace (authored by andrew).
arm64: Enable SVE in userspace
Oct 21 2024, 3:06 PM
andrew committed rG1ee244a9c5da: arm64: add additional MDCR_EL2 fields (authored by zachary.leaf_arm.com).
arm64: add additional MDCR_EL2 fields
Oct 21 2024, 3:06 PM
andrew committed rGa16f10ab0aa7: arm64: Don't trap SVE to EL2 (authored by andrew).
arm64: Don't trap SVE to EL2
Oct 21 2024, 3:06 PM
andrew committed rGaa594ddcc854: arm64: Add an SVE sysarch (authored by andrew).
arm64: Add an SVE sysarch
Oct 21 2024, 3:06 PM
andrew committed rGf7caa6fb7489: arm64: Support SVE in ptrace and core dumps (authored by andrew).
arm64: Support SVE in ptrace and core dumps
Oct 21 2024, 3:06 PM
andrew committed rG2c5961fff4e5: arm64: Initial SVE support (authored by andrew).
arm64: Initial SVE support
Oct 21 2024, 3:06 PM
andrew committed rG7588c7024ed9: arm64: Add the SVE registers to the signal frame (authored by andrew).
arm64: Add the SVE registers to the signal frame
Oct 21 2024, 3:06 PM
andrew committed rG3f2ed1883896: arm64: Create a version of vfp_save_state for cpu_switch (authored by andrew).
arm64: Create a version of vfp_save_state for cpu_switch
Oct 21 2024, 3:06 PM
andrew committed rG2f0fe453bc70: arm64: add CONTEXTIDR_EL1 reg (authored by zachary.leaf_arm.com).
arm64: add CONTEXTIDR_EL1 reg
Oct 21 2024, 3:06 PM
andrew committed rG2db6ffac2497: arm64: Adjust the indentation of CPTR_EL2 values (authored by andrew).
arm64: Adjust the indentation of CPTR_EL2 values
Oct 21 2024, 3:05 PM
andrew committed rGe005eea2c977: arm64: Split out a savectx version of vfp_save_state (authored by andrew).
arm64: Split out a savectx version of vfp_save_state
Oct 21 2024, 3:05 PM
andrew committed rG064adb4ba083: armv8rng: Don't require toolchain to support FEAT_RNG (authored by jrtc27).
armv8rng: Don't require toolchain to support FEAT_RNG
Oct 21 2024, 3:05 PM
andrew committed rG6ac2d3cfb4ad: arm64: Add the tcr_el2 ds field (authored by andrew).
arm64: Add the tcr_el2 ds field
Oct 21 2024, 3:05 PM
andrew committed rGf87a9788a56d: arm64: Fix the ESR_EL1_op2 value (authored by andrew).
arm64: Fix the ESR_EL1_op2 value
Oct 21 2024, 3:05 PM
andrew committed rG77ea17e63134: arm64: Add EL1 and EL12 register alt names (authored by andrew).
arm64: Add EL1 and EL12 register alt names
Oct 21 2024, 3:05 PM
andrew committed rG11b099f8030b: Add an Armv8 rndr random number provider (authored by andrew).
Add an Armv8 rndr random number provider
Oct 21 2024, 3:05 PM
andrew committed rG3bd4724794a5: arm64: write PID in CONTEXTIDR_EL1 on ctx switch (authored by zachary.leaf_arm.com).
arm64: write PID in CONTEXTIDR_EL1 on ctx switch
Oct 21 2024, 12:25 PM