- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 24 2024
In D47199#1077896, @dev_submerge.ch wrote:In D47199#1077635, @christos wrote:So is the patch good to go?
I'm still undecided on the CHN_FOREACH() postcondition of ch == NULL. Tried to find precedence, but I only see implementations that set additional variables like found = true;. Although unlikely to change, this may result in a really hard to spot error when the postcondition doesn't hold.
Oct 23 2024
Approved, plus a minor nit.
Depends on D47268
Good catch, thanks!
So is the patch good to go?
Oct 22 2024
Tested on my VM.
Remove "FALLTHROUGH".
LGTM, except a minor nit.
Address Florian's comments for chn_mkname().
Remove redundant chn_mkname() call in vchan_passthrough().
Oct 21 2024
s/rec/record/ in chn_mkname().
Address Florian's comments:
- Get rid of chn_names[] and integrate it into a switch statement in chn_mkname().
- Refactor dsp_oss_engineinfo() to not use chn_mkname(). Should give us some performance boost as well.
Start from 1.
Oct 20 2024
Change to an enum.
In D47198#1076392, @dev_submerge.ch wrote:Could this be turned into an enum, to facilitate compiler checks in switch() statements? Or is there a policy on using enums in src? I see them far less often than I would expect.
Oct 19 2024
Make some cases fallthrough in chn_init() switch statement.
Use DSP_REGISTERED in dsp_close() as well.
Oct 18 2024
Committed.