Page MenuHomeFreeBSD
Feed Advanced Search

Oct 24 2024

christos committed rG802c78f5194e: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion (authored by christos).
sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion
Oct 24 2024, 11:38 AM
christos committed rGa4111e9dc722: sound: Change PCMDIR_* numbering (authored by christos).
sound: Change PCMDIR_* numbering
Oct 24 2024, 11:38 AM
christos committed rGbb5e3ac1a7b7: sound: Use DSP_REGISTERED in dsp_clone() (authored by christos).
sound: Use DSP_REGISTERED in dsp_clone()
Oct 24 2024, 11:38 AM
christos committed rG9693241188aa: sound: Call DSP_REGISTERED before PCM_DETACHING (authored by christos).
sound: Call DSP_REGISTERED before PCM_DETACHING
Oct 24 2024, 11:38 AM
christos closed D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 24 2024, 11:38 AM
christos closed D47198: sound: Change PCMDIR_* numbering.
Oct 24 2024, 11:38 AM
christos closed D47196: sound: Use DSP_REGISTERED in dsp_clone().
Oct 24 2024, 11:37 AM
christos closed D47195: sound: Call DSP_REGISTERED before PCM_DETACHING.
Oct 24 2024, 11:37 AM
christos added a comment to D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

So is the patch good to go?

I'm still undecided on the CHN_FOREACH() postcondition of ch == NULL. Tried to find precedence, but I only see implementations that set additional variables like found = true;. Although unlikely to change, this may result in a really hard to spot error when the postcondition doesn't hold.

Oct 24 2024, 10:59 AM
christos accepted D47274: git-arc: Use printf instead of echo.
Oct 24 2024, 10:43 AM
christos accepted D47273: git-arc: Quote echoed variables.
Oct 24 2024, 10:40 AM

Oct 23 2024

christos accepted D47264: rc: Remove rc_fast_and_loose.

Approved, plus a minor nit.

Oct 23 2024, 9:22 PM · rc
christos added a comment to D47269: sound: Retire channel refcount.

Depends on D47268

Oct 23 2024, 9:18 PM
christos requested review of D47269: sound: Retire channel refcount.
Oct 23 2024, 9:18 PM
christos requested review of D47268: sound: Remove redundant refcount checks in vchan_setnew().
Oct 23 2024, 9:12 PM
christos accepted D47243: devmatch: Catch truncated linker hints files.
Oct 23 2024, 4:30 PM
christos accepted D47266: mixer: Fix a bogus free() call in the main loop.

Good catch, thanks!

Oct 23 2024, 4:30 PM
christos added a comment to D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

So is the patch good to go?

Oct 23 2024, 3:53 PM
christos added a comment to D46700: sound: Introduce global driver lock.

Bump.

Oct 23 2024, 3:44 PM

Oct 22 2024

christos accepted D47240: linker: Handle a truncated hints file properly.

Tested on my VM.

Oct 22 2024, 5:06 PM
christos added inline comments to D47243: devmatch: Catch truncated linker hints files.
Oct 22 2024, 5:05 PM
christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

Remove "FALLTHROUGH".

Oct 22 2024, 4:35 PM
christos updated subscribers of D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 22 2024, 3:02 PM
christos accepted D47222: csa: Use pci_find_device to simplify clkrun_hack.

LGTM, except a minor nit.

Oct 22 2024, 2:52 PM
christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

Address Florian's comments for chn_mkname().

Oct 22 2024, 2:33 PM
christos added inline comments to D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 22 2024, 2:28 PM
christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

Remove redundant chn_mkname() call in vchan_passthrough().

Oct 22 2024, 1:26 PM
christos added inline comments to D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 22 2024, 11:45 AM

Oct 21 2024

christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

s/rec/record/ in chn_mkname().

Oct 21 2024, 6:51 PM
christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

Address Florian's comments:

  • Get rid of chn_names[] and integrate it into a switch statement in chn_mkname().
  • Refactor dsp_oss_engineinfo() to not use chn_mkname(). Should give us some performance boost as well.
Oct 21 2024, 6:49 PM
christos updated the diff for D47198: sound: Change PCMDIR_* numbering.

Start from 1.

Oct 21 2024, 6:49 PM
christos updated the summary of D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 21 2024, 6:49 PM
christos accepted D46862: rc.d/sendmail: Return non-zero if the daemon fails to start or is not running.
Oct 21 2024, 6:42 PM · rc

Oct 20 2024

christos added inline comments to D47195: sound: Call DSP_REGISTERED before PCM_DETACHING.
Oct 20 2024, 8:09 PM
christos updated the diff for D47198: sound: Change PCMDIR_* numbering.

Change to an enum.

Oct 20 2024, 7:26 PM
christos added a comment to D47198: sound: Change PCMDIR_* numbering.

Could this be turned into an enum, to facilitate compiler checks in switch() statements? Or is there a policy on using enums in src? I see them far less often than I would expect.

Oct 20 2024, 7:23 PM
christos committed rG4f11a5312370: snd_hda: Identify NVIDIA GM204 (authored by Jani Salonen <salojan@goto10.co>).
snd_hda: Identify NVIDIA GM204
Oct 20 2024, 11:22 AM
christos committed rG565a9b8f86b2: sound: Improve /dev/sndstat channel info readability (authored by christos).
sound: Improve /dev/sndstat channel info readability
Oct 20 2024, 11:22 AM
christos committed rGe609dfa98fd3: onyx: Remove unreachable if condition (authored by christos).
onyx: Remove unreachable if condition
Oct 20 2024, 11:22 AM
christos committed rG1a8cd08d8ae6: vmm.4: Add ppt device detach example (authored by christos).
vmm.4: Add ppt device detach example
Oct 20 2024, 11:22 AM
christos committed rG867b2ee99995: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries (authored by christos).
snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
Oct 20 2024, 11:22 AM
christos committed rG28dc9f54efa9: sound: Use M_WAITOK where possible (authored by christos).
sound: Use M_WAITOK where possible
Oct 20 2024, 11:22 AM
christos committed rG7a7ba76aa6f0: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND (authored by christos).
sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
Oct 20 2024, 11:22 AM
christos committed rG84f361c9e367: sound: Do not cast return value of malloc(9) (authored by christos).
sound: Do not cast return value of malloc(9)
Oct 20 2024, 11:22 AM
christos committed rGf0eee0fbde8e: sound: Shorten channel names (authored by christos).
sound: Shorten channel names
Oct 20 2024, 11:22 AM
christos committed rG3b5b485d7436: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate() (authored by christos).
sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
Oct 20 2024, 11:22 AM
christos committed rG86e10d11ca3c: sound: Simplify channel creation and deletion process (authored by christos).
sound: Simplify channel creation and deletion process
Oct 20 2024, 11:22 AM
christos committed rGbf058bde2bca: sound: Simplify vchan_create() error paths (authored by christos).
sound: Simplify vchan_create() error paths
Oct 20 2024, 11:22 AM
christos committed rG1f4d968a299e: sound: Move root feeder initialization to separate function (authored by christos).
sound: Move root feeder initialization to separate function
Oct 20 2024, 11:22 AM
christos committed rG8065f1af82d1: snd_dummy: Drain callout during detach (authored by christos).
snd_dummy: Drain callout during detach
Oct 20 2024, 11:22 AM
christos committed rGebdf08844534: sound: Retire SND_MAXHWCHAN (authored by christos).
sound: Retire SND_MAXHWCHAN
Oct 20 2024, 11:22 AM
christos committed rG6cf4db422c21: sound: Move global variable initialization to sound_modevent() (authored by christos).
sound: Move global variable initialization to sound_modevent()
Oct 20 2024, 11:22 AM
christos committed rG1b0acff71fe8: sound: Fix indendation in sound_modevent() switch statement (authored by christos).
sound: Fix indendation in sound_modevent() switch statement
Oct 20 2024, 11:22 AM
christos committed rG463eafcff98f: sound: Use unr(9) to produce unique channel unit numbers (authored by christos).
sound: Use unr(9) to produce unique channel unit numbers
Oct 20 2024, 11:22 AM
christos committed rG30a64793aa6c: sound: Sort channels by unit number as well (authored by christos).
sound: Sort channels by unit number as well
Oct 20 2024, 11:22 AM
christos committed rGe1eaa312d592: sound: Remove KASSERT from vchan_setnew() (authored by christos).
sound: Remove KASSERT from vchan_setnew()
Oct 20 2024, 11:22 AM
christos committed rG9834b6fc77ff: sound: Get rid of pnum and max variables in chn_init() (authored by christos).
sound: Get rid of pnum and max variables in chn_init()
Oct 20 2024, 11:22 AM
christos committed rG4cf4144d8f7f: sound: Simplify pcm_chnalloc() and fix infinite loop bug (authored by christos).
sound: Simplify pcm_chnalloc() and fix infinite loop bug
Oct 20 2024, 11:22 AM

Oct 19 2024

christos updated the diff for D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.

Make some cases fallthrough in chn_init() switch statement.

Oct 19 2024, 5:13 PM
christos requested review of D47199: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion.
Oct 19 2024, 5:06 PM
christos requested review of D47198: sound: Change PCMDIR_* numbering.
Oct 19 2024, 5:06 PM
christos requested review of D47196: sound: Use DSP_REGISTERED in dsp_clone().
Oct 19 2024, 4:03 PM
christos updated the diff for D47195: sound: Call DSP_REGISTERED before PCM_DETACHING.

Use DSP_REGISTERED in dsp_close() as well.

Oct 19 2024, 4:01 PM
christos requested review of D47195: sound: Call DSP_REGISTERED before PCM_DETACHING.
Oct 19 2024, 4:01 PM
christos closed D47165: audio/sound-juicer: Update to 3.40.0.
Oct 19 2024, 3:05 PM
christos committed R11:033cb8d33abb: audio/sound-juicer: Update to 3.40.0 (authored by Laurent Chardon <laurent.chardon@gmail.com>).
audio/sound-juicer: Update to 3.40.0
Oct 19 2024, 3:05 PM
christos closed D47192: RELNOTES: Add mididump(1).

Committed: https://cgit.freebsd.org/src/commit/?id=6e24259590a3c3b7784c5c656f6be1bee72d0bfe

Oct 19 2024, 2:38 PM
christos committed rG53314e34d5e8: mididump(1): Use nitems() (authored by christos).
mididump(1): Use nitems()
Oct 19 2024, 2:35 PM
christos committed rGfeb9ba2993cf: mididump(1): Use LIBADD instead of LDFLAGS (authored by christos).
mididump(1): Use LIBADD instead of LDFLAGS
Oct 19 2024, 2:35 PM
christos committed rG6e24259590a3: RELNOTES: Add mididump(1) (authored by christos).
RELNOTES: Add mididump(1)
Oct 19 2024, 2:35 PM
christos closed D47191: mididump(1): Use nitems().
Oct 19 2024, 2:35 PM
christos closed D47190: mididump(1): Use LIBADD instead of LDFLAGS.
Oct 19 2024, 2:35 PM
christos requested review of D47192: RELNOTES: Add mididump(1).
Oct 19 2024, 12:05 PM
christos added a comment to D46418: mididump(1): Initial revision.

D47190, D47191

Oct 19 2024, 11:49 AM
christos requested review of D47191: mididump(1): Use nitems().
Oct 19 2024, 11:49 AM
christos requested review of D47190: mididump(1): Use LIBADD instead of LDFLAGS.
Oct 19 2024, 11:49 AM
christos closed D46560: sound: Re-arrange vchan_setnew() initial checks and improve errno values.
Oct 19 2024, 11:41 AM

Oct 18 2024

christos closed D46857: sound: Improve /dev/sndstat channel info readability.

Committed.

Oct 18 2024, 12:43 PM
christos closed D47167: onyx: Remove unreachable if condition.
Oct 18 2024, 8:51 AM
christos closed D46836: sound: Shorten channel names.
Oct 18 2024, 8:50 AM
christos committed rGf57efe95cc25: mididump(1): Initial revision (authored by christos).
mididump(1): Initial revision
Oct 18 2024, 8:46 AM
christos committed rG9ad289155872: vmm.4: Add ppt device detach example (authored by christos).
vmm.4: Add ppt device detach example
Oct 18 2024, 8:46 AM
christos committed rG6f96ef84b359: onyx: Remove unreachable if condition (authored by christos).
onyx: Remove unreachable if condition
Oct 18 2024, 8:46 AM
christos committed rGd643e82356d4: snd_hda: Identify NVIDIA GM204 (authored by Jani Salonen <salojan@goto10.co>).
snd_hda: Identify NVIDIA GM204
Oct 18 2024, 8:46 AM
christos committed rGaaf84d0e9683: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND (authored by christos).
sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
Oct 18 2024, 8:46 AM
christos committed rG5e33eca8e8f3: sound: Use M_WAITOK where possible (authored by christos).
sound: Use M_WAITOK where possible
Oct 18 2024, 8:46 AM
christos committed rGde009cf68ba6: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries (authored by christos).
snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
Oct 18 2024, 8:46 AM
christos committed rG3cc01caa26e4: sound: Do not cast return value of malloc(9) (authored by christos).
sound: Do not cast return value of malloc(9)
Oct 18 2024, 8:46 AM
christos closed D46418: mididump(1): Initial revision.
Oct 18 2024, 8:46 AM
christos committed rGc30f531ddb62: sound: Shorten channel names (authored by christos).
sound: Shorten channel names
Oct 18 2024, 8:46 AM
christos closed D46811: vmm.4: Add ppt device detach example.
Oct 18 2024, 8:46 AM
christos committed rG9263f854e9a6: sound: Simplify channel creation and deletion process (authored by christos).
sound: Simplify channel creation and deletion process
Oct 18 2024, 8:46 AM
christos committed rG3cab66d12d43: sound: Simplify vchan_create() error paths (authored by christos).
sound: Simplify vchan_create() error paths
Oct 18 2024, 8:46 AM
christos committed rGf3092614bcae: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate() (authored by christos).
sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
Oct 18 2024, 8:46 AM
christos closed D47166: snd_hda: Identify NVIDIA GM204.
Oct 18 2024, 8:46 AM
christos closed D47152: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries.
Oct 18 2024, 8:46 AM
christos committed rG248aced26eee: sound: Retire SND_MAXHWCHAN (authored by christos).
sound: Retire SND_MAXHWCHAN
Oct 18 2024, 8:46 AM
christos closed D46846: sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND.
Oct 18 2024, 8:45 AM
christos closed D46845: sound: Use M_WAITOK where possible.
Oct 18 2024, 8:45 AM
christos committed rGe42c82678219: snd_dummy: Drain callout during detach (authored by christos).
snd_dummy: Drain callout during detach
Oct 18 2024, 8:45 AM