mixer: Fix a bogus free() call in the main loop
ClosedPublic
Actions

Authored by markj on Oct 23 2024, 4:15 PM.

Tags

None

Referenced Files

	F144701076: D47266.id145391.diff
	Wed, Feb 11, 8:47 AM

	F144693417: D47266.diff
	Wed, Feb 11, 5:54 AM

	Unknown Object (File)
	Tue, Feb 10, 3:15 PM

	Unknown Object (File)
	Sun, Feb 8, 8:36 AM

	Unknown Object (File)
	Sat, Feb 7, 9:33 PM

	Unknown Object (File)
	Mon, Feb 2, 1:33 AM

	Unknown Object (File)
	Sat, Jan 31, 4:36 AM

	Unknown Object (File)
	Dec 26 2025, 7:31 AM

View All 78 Files

Subscribers

imp

Details

Reviewers

christos

Commits

rGbf2145f361b8: mixer: Fix a bogus free() call in the main loop
rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop

Summary

After a strsep() call, p might not point at the original allocation
anymore.

Reported by: CHERI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 23 2024, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2024, 4:15 PM

markj requested review of this revision.Oct 23 2024, 4:15 PM

Harbormaster completed remote builds in B60172: Diff 145391.Oct 23 2024, 4:15 PM

Good catch, thanks!

This revision is now accepted and ready to land.Oct 23 2024, 4:30 PM

Closed by commit rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop (authored by markj). · Explain WhyOct 23 2024, 10:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop.

markj added a commit: rGbf2145f361b8: mixer: Fix a bogus free() call in the main loop.Oct 30 2024, 1:22 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

mixer.c

6 lines

Diff 145405

View Options

mixer: Fix a bogus free() call in the main loopClosedPublicActions